Issue metadata
Sign in to add a comment
|
Regression : Unwanted 'Arrow' stays forever in tab-strip on dropping any content in omnibox.
Reported by
avsha...@etouch.net,
May 2 2018
|
||||||||||||||||||||||
Issue descriptionChrome Version : 68.0.3417.0 (Official Build) dd2d3effe08392fcd5277bf052c2d3ebbeaf8cd1-refs/heads/master@{#555217} 32/64-bit OS : Windows(7,8,8.1,10) What steps will reproduce the problem? 1. Launch chrome and open NTP. 2. Drag 'Chrome Web Store' thumbnail and drop it in omnibox. 3. Observe the omnibox. Actual Result : Unwanted arrow icon stays forever in tab strip on dropping any content in omnibox. Expected Result : Arrow icon should disappear from tab strip after dropping any content in omnibox. This is a regression issue, broken in M-68 and will soon update remaining info. Good Build : 68.0.3416.0 Bad Build : 68.0.3417.0
,
May 2 2018
,
May 2 2018
marking as RBS, please change if required.
,
May 3 2018
Yes. My CL seems to be the culprit. Thank you for reporting this :)
,
May 4 2018
,
May 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8d70f4adc331afac1cec67ad6f4c538173de6fe3 commit 8d70f4adc331afac1cec67ad6f4c538173de6fe3 Author: sangwoo.ko <sangwoo108@chromium.org> Date: Sat May 05 03:11:46 2018 Clear drop info after performing drops Otherwise, arrow can stay forever. Bug: 838791 Change-Id: I2fe13be530a66b587511484ea3d093bc39ad4194 Reviewed-on: https://chromium-review.googlesource.com/1041366 Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#556302} [modify] https://crrev.com/8d70f4adc331afac1cec67ad6f4c538173de6fe3/chrome/browser/ui/views/frame/browser_root_view.cc [modify] https://crrev.com/8d70f4adc331afac1cec67ad6f4c538173de6fe3/chrome/browser/ui/views/frame/browser_root_view.h [add] https://crrev.com/8d70f4adc331afac1cec67ad6f4c538173de6fe3/chrome/browser/ui/views/frame/browser_root_view_browsertest.cc [modify] https://crrev.com/8d70f4adc331afac1cec67ad6f4c538173de6fe3/chrome/test/BUILD.gn
,
May 5 2018
,
May 8 2018
Seem like the issue is fixed, avshaikh@ please verify.
,
May 9 2018
Update : Retested above issue in Latest canary build #68.0.3425.0 on Windows(7,8,8.1,10) and Linux (14.04 LTS)OS and the issue is fixed. Arrow icon disappear from tab strip after dropping any content in omnibox. Kindly review an attached screen-cast. Thank you..! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by avsha...@etouch.net
, May 2 2018Owner: sangwoo108@chromium.org
Status: Assigned (was: Unconfirmed)