New issue
Advanced search Search tips

Issue 838789 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 3
Type: Task



Sign in to add a comment

Remove password_manager::features::kPasswordExport

Project Member Reported by vabr@chromium.org, May 2 2018

Issue description

password_manager::features::kPasswordExport is on by default since version 66. There seem to be no catastrophic crashes or other fundamental issues with the new code, so all code paths for the feature disabled, and the feature flag itself, should be removed.

Owners: cfroussios@ for desktop, ioanap@ for iOS, vabr@ for Android
 
Cc: dpa...@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, May 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32bbd5cfe72d1a3b9b93f1aca62af6b801da2d03

commit 32bbd5cfe72d1a3b9b93f1aca62af6b801da2d03
Author: Christos Froussios <cfroussios@chromium.org>
Date: Fri May 11 19:27:03 2018

[Password Manager] Inline the Export Passwords feature in the MD settings

The feature is now fully rolled out.

Bug:  838789 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Icdd315779899230fe78b7d90a17680736722a2ea
Reviewed-on: https://chromium-review.googlesource.com/1047867
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557976}
[modify] https://crrev.com/32bbd5cfe72d1a3b9b93f1aca62af6b801da2d03/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js
[modify] https://crrev.com/32bbd5cfe72d1a3b9b93f1aca62af6b801da2d03/chrome/browser/ui/webui/settings/md_settings_ui.cc

Comment 3 by vabr@chromium.org, Jun 1 2018

Cc: vabr@chromium.org
 Issue 824069  has been merged into this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 31

Owner: ioanap@chromium.org
Now that the flag was removed on desktop and Android, the last platform to clean-up is iOS.
Over to you, ioanap@ :).
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/afdfb291c7484c71125fe6bd773eb143e1428028

commit afdfb291c7484c71125fe6bd773eb143e1428028
Author: Ioana Pandele <ioanap@chromium.org>
Date: Thu Sep 06 16:07:37 2018

Remove password export feature flag

This feature has been enabled for the past few stable releases, so the
flag is not needed anymore.

Bug:  838789 , 792840
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ib79921d30792dbd8e03fd2ec7652c15a76e84b73
Reviewed-on: https://chromium-review.googlesource.com/1203956
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589182}
[modify] https://crrev.com/afdfb291c7484c71125fe6bd773eb143e1428028/components/password_manager/core/common/password_manager_features.cc
[modify] https://crrev.com/afdfb291c7484c71125fe6bd773eb143e1428028/components/password_manager/core/common/password_manager_features.h
[modify] https://crrev.com/afdfb291c7484c71125fe6bd773eb143e1428028/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/afdfb291c7484c71125fe6bd773eb143e1428028/ios/chrome/browser/about_flags.mm
[modify] https://crrev.com/afdfb291c7484c71125fe6bd773eb143e1428028/ios/chrome/browser/ios_chrome_flag_descriptions.cc
[modify] https://crrev.com/afdfb291c7484c71125fe6bd773eb143e1428028/ios/chrome/browser/ios_chrome_flag_descriptions.h
[modify] https://crrev.com/afdfb291c7484c71125fe6bd773eb143e1428028/ios/chrome/browser/ui/settings/passwords_settings_egtest.mm
[modify] https://crrev.com/afdfb291c7484c71125fe6bd773eb143e1428028/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm
[modify] https://crrev.com/afdfb291c7484c71125fe6bd773eb143e1428028/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller_unittest.mm

Status: Fixed (was: Assigned)
Thanks, ioanap@!
AFAIK, this all done, so marking as such. Please reopen if you disagree.
Cc: -vabr@chromium.org

Sign in to add a comment