Extension API tests chromium.runtime GetPlatformInfo functions return NULL.
Reported by
wangqing...@loongson.cn,
May 2 2018
|
||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.181 Safari/537.36 Steps to reproduce the problem: 1. build browser_tests 2. run browser_tests case:ExtensionApiTest.ChromeRuntimeGetPlatformInfo What is the expected behavior? passed What went wrong? Note: Google Test filter = ExtensionApiTest.ChromeRuntimeGetPlatformInfo [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from ExtensionApiTest, where TypeParam = [ RUN ] ExtensionApiTest.ChromeRuntimeGetPlatformInfo ../../chrome/browser/extensions/extension_function_test_utils.cc:115: Failure Value of: function->GetError().empty() Actual: false Expected: true Unexpected error: Platform information unavailable. ../../extensions/browser/api/runtime/runtime_apitest.cc:59: Failure Value of: result.get() != NULL Actual: false Expected: true [ FAILED ] ExtensionApiTest.ChromeRuntimeGetPlatformInfo, where TypeParam = and GetParam() = (1801 ms) [----------] 1 test from ExtensionApiTest (1801 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test case ran. (1801 ms total) [ PASSED ] 0 tests. [ FAILED ] 1 test, listed below: [ FAILED ] ExtensionApiTest.ChromeRuntimeGetPlatformInfo, where TypeParam = and GetParam() = 1 FAILED TEST [1/1] ExtensionApiTest.ChromeRuntimeGetPlatformInfo (2094 ms) Did this work before? N/A Does this work in other browsers? Yes Chrome version: 60.0.3096.2 Channel: n/a OS Version: fedora 21 Flash Version:
,
May 2 2018
Initial patch that [MIPS] Add chromium.runtime API support for Loongson has just been submitted for a review. It can be viewed at: https://chromium-review.googlesource.com/c/chromium/src/+/1038912
,
May 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1cb26c473a8f56db45580c413fa2e70705f63785 commit 1cb26c473a8f56db45580c413fa2e70705f63785 Author: Wang Qing <wangqing-hf@loongson.cn> Date: Fri May 04 01:48:55 2018 [MIPS] Add chromium.runtime API support for Loongson. Extension API tests chromium.runtime GetPlatformInfo functions return NULL. Bug comes from automated test unit: browser_tests BUG= 838783 R= tbarzic@chromium.org Change-Id: I4f6b04835fb949f15218c5adc4401950ba14b0a3 Reviewed-on: https://chromium-review.googlesource.com/1038912 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: 汪 清 <wangqing-hf@loongson.cn> Cr-Commit-Position: refs/heads/master@{#555957} [modify] https://crrev.com/1cb26c473a8f56db45580c413fa2e70705f63785/chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc [modify] https://crrev.com/1cb26c473a8f56db45580c413fa2e70705f63785/extensions/common/api/runtime.json
,
May 11 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by wangqing...@loongson.cn
, May 2 2018