Failing test: virtual/modern-media-controls/media/controls/modern/singletap-on-overlay-closes-overflow-menu.html

This is a crash:

STDERR: [4756:6152:0501/132255.378:FATAL:media_control_overflow_menu_list_element.cc(58)] Check failed: !current_task_handle_.IsActive(). 
STDERR: Backtrace:
STDERR: 	base::debug::StackTrace::StackTrace [0x6DB244A6+102]
STDERR: 	base::debug::StackTrace::StackTrace [0x6DB2319B+27]
STDERR: 	logging::LogMessage::~LogMessage [0x6DB98D04+148]
STDERR: 	blink::MediaControlOverflowMenuListElement::SetIsWanted [0x045F57F6+470]
STDERR: 	blink::MediaControlPopupMenuElement::RemovedFrom [0x04601C20+48]
STDERR: 	blink::ContainerNode::NotifyNodeRemoved [0x52BCF984+228]
STDERR: 	blink::ContainerNode::NotifyNodeRemoved [0x52BCF9AA+266]
STDERR: 	blink::ContainerNode::RemoveChildren [0x52BCFD40+304]
STDERR: 	blink::Node::setTextContent [0x52DDF463+387]
STDERR: 	blink::V8Node::textContentAttributeSetterCallback [0x549B27BE+574]
STDERR: 	blink::V8Node::textContentAttributeSetterCallback [0x549B2685+261]
STDERR: 	v8::internal::FunctionCallbackArguments::Call [0x58F3CBC2+626]
STDERR: 	v8::internal::Builtins::InvokeApiFunction [0x58F3B31E+5566]
STDERR: 	v8::internal::Builtins::InvokeApiFunction [0x58F3A190+1072]
STDERR: 	v8::internal::Object::SetPropertyWithAccessor [0x5972BADE+910]
STDERR: 	v8::internal::Object::SetPropertyInternal [0x59744B22+530]
STDERR: 	v8::internal::Object::SetProperty [0x5974480A+74]
STDERR: 	v8::internal::StoreIC::Store [0x595FB421+1121]
STDERR: 	v8::internal::Runtime_StoreIC_Miss [0x5960415E+1182]
STDERR: 	v8::internal::Runtime_StoreIC_Miss [0x59603D87+199]

Note: Sheriff-O-Matic is reporting 41 tests failing:
...... too many results, data snipped.... ( Code Search )
external/wpt/credential-management/federatedcredential-framed-get.sub.https.html ( Code Search )
external/wpt/credential-management/passwordcredential-framed-get.sub.https.html ( Code Search )
external/wpt/css/css-flexbox/ttwf-reftest-flex-wrap-reverse.html ( Code Search )
external/wpt/css/css-flexbox/ttwf-reftest-flex-wrap.html ( Code Search )
external/wpt/css/css-fonts/font-variant-ligatures-11.html ( Code Search )
external/wpt/css/css-shapes/shape-outside/shape-image/shape-image-010.html ( Code Search )
external/wpt/css/css-shapes/shape-outside/supported-shapes/circle/shape-outside-circle-027.html ( Code Search )
external/wpt/css/css-text/text-align/text-align-end-003.html ( Code Search )
external/wpt/css/css-text/text-align/text-align-end-016.html ( Code Search )
external/wpt/css/css-text/text-align/text-align-start-004.html ( Code Search )
external/wpt/css/css-text/text-justify/text-justify-001.html ( Code Search )
external/wpt/css/css-text/white-space/pre-wrap-004.html ( Code Search )
external/wpt/css/css-text/white-space/pre-wrap-011.html ( Code Search )
external/wpt/css/css-text/white-space/pre-wrap-013.html ( Code Search )
external/wpt/css/css-text/white-space/textarea-pre-wrap-005.html ( Code Search )
external/wpt/css/css-text/white-space/textarea-pre-wrap-014.html ( Code Search )
external/wpt/css/css-transforms/transform3d-perspective-008.html ( Code Search )
external/wpt/css/css-writing-modes/bidi-override-005.html ( Code Search )
external/wpt/css/css-writing-modes/bidi-plaintext-001.html ( Code Search )
external/wpt/css/css-writing-modes/sizing-orthog-htb-in-vlr-016.xht ( Code Search )
external/wpt/css/css-writing-modes/sizing-orthog-htb-in-vrl-016.xht ( Code Search )
external/wpt/css/css-writing-modes/sizing-orthog-prct-htb-in-vlr-005.xht ( Code Search )
external/wpt/css/css-writing-modes/sizing-orthog-prct-htb-in-vlr-006.xht ( Code Search )
external/wpt/css/css-writing-modes/sizing-orthog-prct-htb-in-vrl-005.xht ( Code Search )
external/wpt/css/css-writing-modes/sizing-orthog-prct-htb-in-vrl-006.xht ( Code Search )
external/wpt/css/geometry/interfaces.worker.html ( Code Search )
external/wpt/css/selectors/focus-within-004.html ( Code Search )
external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-baseline-multi-item-vert-001b.html ( Code Search )
external/wpt/html/dom/documents/dom-tree-accessors/Document.currentScript.html ( Code Search )
external/wpt/html/semantics/scripting-1/the-script-element/async_007.htm ( Code Search )
external/wpt/html/semantics/scripting-1/the-script-element/async_010.htm ( Code Search )
external/wpt/offscreen-canvas/the-offscreen-canvas/offscreencanvas.getcontext.worker.html ( Code Search )
external/wpt/requestidlecallback/basic.html ( Code Search )
external/wpt/requestidlecallback/callback-iframe.html ( Code Search )
external/wpt/requestidlecallback/callback-invoked.html ( Code Search )
external/wpt/requestidlecallback/cancel-invoked.html ( Code Search )
external/wpt/websockets/constructor/014.html?wss ( Code Search )
external/wpt/websockets/keeping-connection-open/001.html?wss ( Code Search )
external/wpt/webvr/idlharness.https.html ( Code Search )
fast/events/wheel/mainthread-touchpad-fling-latching.html ( Code Search )

None of these are visible in the bot list, just the one I reported above. So I'll try to investigate that one.

One build crashed a bunch of other tests (above) but I'm ignoring that for this bug.

singletap-on-overlay-closes-overflow-menu.html started reliably failing from build 68792 onwards. Blame range from r555068 to r555107:
https://chromium.googlesource.com/chromium/src/+log/cfc90f0da40144386230f8ff93924c1a13883ce6%5E..568b57dc88616bed37360f4e2c6ec3d60533bb5c

Of this, the obvious culprit is r555083 which modifies the file that is crashing.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e43caa6014719bd4cf5476e76404dfb208e97a8a

commit e43caa6014719bd4cf5476e76404dfb208e97a8a
Author: Matt Giuca <mgiuca@chromium.org>
Date: Wed May 02 06:37:47 2018

Revert "Media Controls: remove window event listener and listen to event on popup."

This reverts commit 92d457976874c99ded44a48ab92e768f2f274ca9.

Reason for revert: Suspect cause of crash in WebKit layout tests on
Windows ( https://crbug.com/838782 ).

Original change's description:
> Media Controls: remove window event listener and listen to event on popup.
> 
> This is moving the logic to hide the popups to the popup element class.
> It will hide when the popup no longer has focus, when the window is
> resized or scrolled. It slightly improves memory usage by only creating
> the event listener object on demand.
> 
> Bug: 833461
> Change-Id: I979f0882108fcd89fdf84b2612437209b080eb95
> Reviewed-on: https://chromium-review.googlesource.com/1023345
> Reviewed-by: Becca Hughes <beccahughes@chromium.org>
> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#555083}

TBR=mlamouri@chromium.org,beccahughes@chromium.org

Change-Id: Ic0bdd6a3422447424c4c00037e57005c9ba1de05
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 833461,  838782 
Reviewed-on: https://chromium-review.googlesource.com/1039116
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Commit-Queue: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555321}
[delete] https://crrev.com/498ff64dc11978dcfdd294d466454ddb8cb0dd5c/third_party/WebKit/LayoutTests/media/controls/overflow-menu-hide-on-click-item.html
[delete] https://crrev.com/498ff64dc11978dcfdd294d466454ddb8cb0dd5c/third_party/WebKit/LayoutTests/media/controls/overflow-menu-hide-on-click-outside-stoppropagation.html
[delete] https://crrev.com/498ff64dc11978dcfdd294d466454ddb8cb0dd5c/third_party/WebKit/LayoutTests/media/controls/overflow-menu-hide-on-click-outside.html
[delete] https://crrev.com/498ff64dc11978dcfdd294d466454ddb8cb0dd5c/third_party/WebKit/LayoutTests/media/controls/overflow-menu-hide-on-click-panel.html
[delete] https://crrev.com/498ff64dc11978dcfdd294d466454ddb8cb0dd5c/third_party/WebKit/LayoutTests/media/controls/overflow-menu-hide-on-resize.html
[delete] https://crrev.com/498ff64dc11978dcfdd294d466454ddb8cb0dd5c/third_party/WebKit/LayoutTests/media/controls/overflow-menu-hide-on-scroll.html
[delete] https://crrev.com/498ff64dc11978dcfdd294d466454ddb8cb0dd5c/third_party/WebKit/LayoutTests/media/controls/overflow-menu-visibility.html
[add] https://crrev.com/e43caa6014719bd4cf5476e76404dfb208e97a8a/third_party/WebKit/LayoutTests/media/controls/video-controls-overflow-menu-hide-on-click-outside.html
[add] https://crrev.com/e43caa6014719bd4cf5476e76404dfb208e97a8a/third_party/WebKit/LayoutTests/media/controls/video-controls-overflow-menu-hide-on-click-panel.html
[add] https://crrev.com/e43caa6014719bd4cf5476e76404dfb208e97a8a/third_party/WebKit/LayoutTests/media/controls/video-controls-overflow-menu-hide-on-click.html
[add] https://crrev.com/e43caa6014719bd4cf5476e76404dfb208e97a8a/third_party/WebKit/LayoutTests/media/controls/video-controls-overflow-menu-hide-on-resize.html
[add] https://crrev.com/e43caa6014719bd4cf5476e76404dfb208e97a8a/third_party/WebKit/LayoutTests/media/controls/video-controls-overflow-menu-visibility.html
[add] https://crrev.com/e43caa6014719bd4cf5476e76404dfb208e97a8a/third_party/WebKit/LayoutTests/media/media-controls-hide-menu-stoppropagation.html
[modify] https://crrev.com/e43caa6014719bd4cf5476e76404dfb208e97a8a/third_party/blink/renderer/modules/media_controls/BUILD.gn
[modify] https://crrev.com/e43caa6014719bd4cf5476e76404dfb208e97a8a/third_party/blink/renderer/modules/media_controls/elements/media_control_input_element.cc
[modify] https://crrev.com/e43caa6014719bd4cf5476e76404dfb208e97a8a/third_party/blink/renderer/modules/media_controls/elements/media_control_overflow_menu_list_element.cc
[modify] https://crrev.com/e43caa6014719bd4cf5476e76404dfb208e97a8a/third_party/blink/renderer/modules/media_controls/elements/media_control_overflow_menu_list_element.h
[modify] https://crrev.com/e43caa6014719bd4cf5476e76404dfb208e97a8a/third_party/blink/renderer/modules/media_controls/elements/media_control_popup_menu_element.cc
[modify] https://crrev.com/e43caa6014719bd4cf5476e76404dfb208e97a8a/third_party/blink/renderer/modules/media_controls/elements/media_control_popup_menu_element.h
[modify] https://crrev.com/e43caa6014719bd4cf5476e76404dfb208e97a8a/third_party/blink/renderer/modules/media_controls/elements/media_control_toggle_closed_captions_button_element.cc
[modify] https://crrev.com/e43caa6014719bd4cf5476e76404dfb208e97a8a/third_party/blink/renderer/modules/media_controls/media_controls_impl.cc
[modify] https://crrev.com/e43caa6014719bd4cf5476e76404dfb208e97a8a/third_party/blink/renderer/modules/media_controls/media_controls_impl.h
[modify] https://crrev.com/e43caa6014719bd4cf5476e76404dfb208e97a8a/third_party/blink/renderer/modules/media_controls/media_controls_impl_test.cc
[add] https://crrev.com/e43caa6014719bd4cf5476e76404dfb208e97a8a/third_party/blink/renderer/modules/media_controls/media_controls_window_event_listener.cc
[add] https://crrev.com/e43caa6014719bd4cf5476e76404dfb208e97a8a/third_party/blink/renderer/modules/media_controls/media_controls_window_event_listener.h

Crash should be fixed after revert.

Note: This is crashing Mac builders also:
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.11%20%28dbg%29/