Currently we have several VideoCaptureDeviceClient mock implementations scattering around in several places: [0]: https://cs.chromium.org/chromium/src/content/browser/media/capture/desktop_capture_device_aura_unittest.cc?q=content/browser/media/capture/desktop_capture_device_aura_unittest.cc&sq=package:chromium&l=44 [1]: https://cs.chromium.org/chromium/src/content/browser/media/capture/screen_capture_device_android_unittest.cc?sq=package:chromium&l=18 [2]: https://cs.chromium.org/chromium/src/media/capture/video/fake_video_capture_device_unittest.cc?l=101 [3]: https://cs.chromium.org/chromium/src/media/capture/video/video_capture_device_unittest.cc?l=149 [4]: https://cs.chromium.org/chromium/src/media/capture/video/file_video_capture_device_unittest.cc?rcl=99d5821e952e2c6b025e4e80443a9b078630a7f7&l=25 [5]: https://cs.chromium.org/chromium/src/media/capture/video/win/video_capture_device_mf_win_unittest.cc?rcl=99d5821e952e2c6b025e4e80443a9b078630a7f7&l=27 [6]: https://cs.chromium.org/chromium/src/media/capture/video/linux/v4l2_capture_delegate_unittest.cc?rcl=99d5821e952e2c6b025e4e80443a9b078630a7f7&l=175 [7]: https://cs.chromium.org/chromium/src/media/capture/video/chromeos/mock_video_capture_client.cc We should consolidate them into one mock_video_capture_device_client.{h|cc} and put it next to the video_capture_device.h header file.
One more: [8]: https://cs.chromium.org/chromium/src/content/browser/media/capture/desktop_capture_device_unittest.cc?l=66
Not sure why this was assigned to me. In the future, please check with me before assigning a bug to me.
Comment 1 by jcliang@chromium.org
, May 2 2018