Many style errors on blink/renderer/build/scripts/make_html_entity_table.py |
||
Issue descriptionChrome Version: ToT What steps will reproduce the problem? (1) cd third_party/blink (2) ./tools/check_blink_style.py renderer/build/scripts/make_html_entity_table.py What is the expected result? The command shows no errors. What happens instead? The command shows 30 errors. The file was recently renamed from 'create-html-entity-table', and check_blink_style.py had never assumed it was a python file.
,
May 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f87f1ff9687690baded89f989ce66113001c9786 commit f87f1ff9687690baded89f989ce66113001c9786 Author: Kent Tamura <tkent@chromium.org> Date: Tue May 08 10:35:55 2018 Fix all of style errors on make_html_entity_table.py. - Avoid global variables Wrap the whole code with 'main()' function - Don't use obsolete 'string' module - Don't add parenthesis to assert. - Remove trailing whitespace - Remove unused variable 'saved_by_reusing' - Remove whitespace around a keyword argument =. This CL has no behavior changes. Bug: 838772 Change-Id: Ib79344a4c5a671c24a528ed918156e22b0d2c65d Reviewed-on: https://chromium-review.googlesource.com/1049407 Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#556749} [modify] https://crrev.com/f87f1ff9687690baded89f989ce66113001c9786/third_party/blink/renderer/build/scripts/make_html_entity_table.py
,
May 8 2018
,
May 8 2018
Awesome, thanks for cleaning this up too :-D |
||
►
Sign in to add a comment |
||
Comment 1 by tkent@chromium.org
, May 8 2018Status: Started (was: Available)