Issue metadata
Sign in to add a comment
|
Extension dev mode bubble nigh unclosable on mac with cocoa |
||||||||||||||||||||||
Issue descriptionWhat steps will reproduce the problem? 0. Ensure chrome://flags/#secondary-ui-md is *disabled*. 1. Load unpacked extensions into chrome through chrome://extensions 2. Restart Chrome 3. Observe the bubble warning about developer mode extensions What is the expected result? It should be closeable. What happens instead of that? It's very difficult to close (only achievable by focusing it and hitting "escape", AFAICT). This was a regression from revision 6de866ade456810e3105dfa33980b4c2c1325188, which removed the dismiss button for MAC_VIEWS_BROWSER mac builds. However, MAC_VIEWS_BROWSER doesn't mean that Cocoa UI won't be displayed. Instead, we need to rely on whether features::kSecondaryUiMd is enabled.
,
May 2 2018
Removing releaseblock due to recent discoveries.
,
May 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6916170ca5977fc9ef36359fd7f9b789618fd5f2 commit 6916170ca5977fc9ef36359fd7f9b789618fd5f2 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Thu May 03 05:25:28 2018 [Extensions + Cocoa] Ensure dev mode bubble has cancel button The dev mode extension bubble does not have a close button ('x') on cocoa, but does on views. This means that it should not have a cancel button on views (since it would be redundant with the 'x'), but it should on cocoa (since otherwise there's no way to close it, short of hitting the escape key). It looks like there was logic to try and ensure that the cocoa bubble always had a cancel button, but it was insufficient, since it uses MAC_VIEWS_BROWSER to check. However, MAC_VIEWS_BROWSER may be true, while Cocoa UI is still shown. This means that the Cocoa bubble may be shown without a cancel button, which is very bad (since it is exceedingly hard to close). Add the dismiss button back in for non-views-enabled mac builds. Bug: 838768 Change-Id: I61cf06bb3612607462fff28b72e4bfdd156a017b Reviewed-on: https://chromium-review.googlesource.com/1038231 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#555668} [modify] https://crrev.com/6916170ca5977fc9ef36359fd7f9b789618fd5f2/chrome/browser/extensions/dev_mode_bubble_delegate.cc [add] https://crrev.com/6916170ca5977fc9ef36359fd7f9b789618fd5f2/chrome/browser/extensions/dev_mode_bubble_delegate_unittest.cc [modify] https://crrev.com/6916170ca5977fc9ef36359fd7f9b789618fd5f2/chrome/test/BUILD.gn
,
May 4 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rdevlin....@chromium.org
, May 2 2018