New issue
Advanced search Search tips

Issue 838764 link

Starred by 2 users
Status: Verified
Owner:
manojgupta@chromium.org
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Build-Toolchain



Sign in to add a comment

v8_snapshot is using an unsupported -fno-delete-null-pointer-checks flag

Project Member Reported by manojgupta@chromium.org, May 2 2018 
Too many warnings are issued when building v8_snapshot.

https://logs.chromium.org/v/?s=chromeos%2Fbb%2Fchromeos%2Fcaroline-release%2F1604%2F%2B%2Frecipes%2Fsteps%2FBuildPackages__afdo_use_%2F0%2Fstdout

chromeos-chrome-67.0.3383.0_rc-r1: [3525/41991] CXX v8_snapshot/obj/buildtools/third_party/libc++/libc++/chrono.o
chromeos-chrome-67.0.3383.0_rc-r1: clang++: warning: optimization flag '-fno-delete-null-pointer-checks' is not supported [-Wignored-optimization-argument]
chromeos-chrome-67.0.3383.0_rc-r1: 
chromeos-chrome-67.0.3383.0_rc-r1: [3525/41991] CXX newlib_pnacl_nonsfi/obj/third_party/icu/icui18n/cpdtrans.o
chromeos-chrome-67.0.3383.0_rc-r1: [3526/41991] CXX v8_snapshot/obj/buildtools/third_party/libc++/libc++/any.o
chromeos-chrome-67.0.3383.0_rc-r1: clang++: warning: optimization flag '-fno-delete-null-pointer-checks' is not supported [-Wignored-optimization-argument]
chromeos-chrome-67.0.3383.0_rc-r1: 
chromeos-chrome-67.0.3383.0_rc-r1: [3526/41991] CXX newlib_pnacl_nonsfi/obj/third_party/icu/icui18n/csdetect.o
chromeos-chrome-67.0.3383.0_rc-r1: [3527/41991] CXX v8_snapshot/obj/buildtools/third_party/libc++/libc++/bind.o
chromeos-chrome-67.0.3383.0_rc-r1: clang++: warning: optimization flag '-fno-delete-null-pointer-checks' is not supported [-Wignored-optimization-argument]
chromeos-chrome-67.0.3383.0_rc-r1: 
chromeos-chrome-67.0.3383.0_rc-r1: [3527/41991] CXX newlib_pnacl_nonsfi/obj/third_party/icu/icui18n/csmatch.o
chromeos-chrome-67.0.3383.0_rc-r1: [3528/41991] CXX v8_snapshot/obj/buildtools/third_party/libc++/libc++/algorithm.o
chromeos-chrome-67.0.3383.0_rc-r1: clang++: warning: optimization flag '-fno-delete-null-pointer-checks' is not supported [-Wignored-optimization-argument]
Project Member

Comment 1 by bugdroid1@chromium.org, May 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/17cfe0762d75d6f308044b61d547ce899cb454a9

commit 17cfe0762d75d6f308044b61d547ce899cb454a9
Author: Manoj Gupta <manojgupta@google.com>
Date: Wed May 02 06:42:11 2018

chromeos-chrome: set cros_v8_snapshot_is_clang.

v8_snapshot is picking a non-clang config since
cros_v8_snapshot_is_clang is not set. This makes
v8_snapshot build to use unsupported clang options resulting
in unnecessary warnings.

BUG= chromium:838764 
TEST=cros_v8_snapshot_is_clang is set in GN args.
TEST=No more  -fno-delete-null-pointer-checks warnings.

Change-Id: Ifa6053552bd038d65305b127718480b293fb984a
Reviewed-on: https://chromium-review.googlesource.com/1039146
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Trybot-Ready: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Ilja H. Friedel <ihf@chromium.org>

[modify] https://crrev.com/17cfe0762d75d6f308044b61d547ce899cb454a9/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild

Comment 2 by manojgupta@chromium.org, May 3 2018

Status: Verified (was: Untriaged)
Don't see the warning anymore.
►

Sign in to add a comment