New issue
Advanced search Search tips

Issue 838759 link

Starred by 4 users
Status: Fixed
Owner:
falken@chromium.org
Closed: Nov 29
Cc:
peter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

"PushMessagingBrowserTest.UnsubscribeSuccess" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, May 2 2018 
"PushMessagingBrowserTest.UnsubscribeSuccess" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyNgsSBUZsYWtlIitQdXNoTWVzc2FnaW5nQnJvd3NlclRlc3QuVW5zdWJzY3JpYmVTdWNjZXNzDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

Comment 1 by jonr...@chromium.org, May 3 2018

Owner: peter@chromium.org
Status: Assigned (was: Untriaged)
Hey Peter, I'm assigning this to you as you were the last to modify the test.

This seems similar to  issue 835382 . Both are variants of unsubscribing. Both began flaking around April 17/18. Something likely landed around then to introduce this flakiness.
Project Member

Comment 2 by bugdroid1@chromium.org, May 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c71774d9b84896fd1ff61bc76e64c052ef5c1d2

commit 2c71774d9b84896fd1ff61bc76e64c052ef5c1d2
Author: jonross <jonross@chromium.org>
Date: Thu May 03 14:29:45 2018

Disable Flaky PushMessagingBrowserTest.UnsubscribeSuccess

PushMessagingBrowserTest.UnsubscribeSuccess is flaking on Windows, so I'm
disabling it.

TBR=peter@chromium.org
TEST=PushMessagingBrowserTest.UnsubscribeSuccess

Bug:  838759 
Change-Id: I7cf36aa034f8666639830a510aa1d18da6189911
Reviewed-on: https://chromium-review.googlesource.com/1042366
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555723}
[modify] https://crrev.com/2c71774d9b84896fd1ff61bc76e64c052ef5c1d2/chrome/browser/push_messaging/push_messaging_browsertest.cc

Comment 3 by jonr...@chromium.org, May 3 2018

Labels: -Sheriff-Chromium

Comment 4 by peter@chromium.org, May 3 2018

Cc: peter@chromium.org
 Issue 835382  has been merged into this issue.

Comment 5 by peter@chromium.org, May 3 2018

Cc: -peter@chromium.org
Components: Blink>PushAPI
Labels: OS-Windows
I agree with #c1, both flakes started around April 17, so let's figure out what happened there.

Comment 6 by awdf@chromium.org, May 10 2018

Cc: falken@chromium.org
Components: Blink>ServiceWorker
Here's the relevant logs from the test failure:

[7264:5912:0501/164945.004:INFO:CONSOLE(44)] "sendResultToTest: ok - service worker registered", source: https://127.0.0.1:62260/result_queue.js (44)
[7264:5912:0501/164945.020:INFO:CONSOLE(44)] "sendResultToTest: permission status - granted", source: https://127.0.0.1:62260/result_queue.js (44)
[7264:5912:0501/164945.094:INFO:CONSOLE(44)] "sendResultToTest: https://android.googleapis.com/gcm/send/5680295398850591303", source: https://127.0.0.1:62260/result_queue.js (44)
[7264:5912:0501/164945.094:INFO:CONSOLE(44)] "sendResultToTest: ok - stored", source: https://127.0.0.1:62260/result_queue.js (44)
[7264:5912:0501/164945.125:INFO:CONSOLE(44)] "sendResultToTest: unsubscribe result: true", source: https://127.0.0.1:62260/result_queue.js (44)
[7264:5912:0501/164945.125:INFO:CONSOLE(44)] "sendResultToTest: unsubscribe result: false", source: https://127.0.0.1:62260/result_queue.js (44)
[7264:5912:0501/164945.140:INFO:CONSOLE(44)] "sendResultToTest: ok - service worker registered", source: https://127.0.0.1:62260/result_queue.js (44)
[7264:5912:0501/164945.140:INFO:CONSOLE(44)] "sendResultToTest: permission status - granted", source: https://127.0.0.1:62260/result_queue.js (44)
[7264:5912:0501/164945.156:INFO:CONSOLE(44)] "sendResultToTest: https://android.googleapis.com/gcm/send/6612778229948865603", source: https://127.0.0.1:62260/result_queue.js (44)
[7264:5912:0501/164945.172:INFO:CONSOLE(44)] "sendResultToTest: ok - stored", source: https://127.0.0.1:62260/result_queue.js (44)
[7264:5912:0501/164945.276:INFO:CONSOLE(44)] "sendResultToTest: ok - service worker replaced", source: https://127.0.0.1:62260/result_queue.js (44)
[7264:5912:0501/164945.305:INFO:CONSOLE(44)] "sendResultToTest: unsubscribe result: true", source: https://127.0.0.1:62260/result_queue.js (44)
[7264:5912:0501/164945.422:INFO:CONSOLE(44)] "sendResultToTest: ok - service worker registered", source: https://127.0.0.1:62260/result_queue.js (44)
[7264:5912:0501/164945.437:INFO:CONSOLE(44)] "sendResultToTest: permission status - granted", source: https://127.0.0.1:62260/result_queue.js (44)
[7264:5912:0501/164945.453:INFO:CONSOLE(44)] "sendResultToTest: https://android.googleapis.com/gcm/send/2567223356524781153", source: https://127.0.0.1:62260/result_queue.js (44)
[7264:5912:0501/164945.469:INFO:CONSOLE(44)] "sendResultToTest: ok - stored", source: https://127.0.0.1:62260/result_queue.js (44)
[7264:5912:0501/164945.469:INFO:CONSOLE(44)] "sendResultToTest: service worker unregistration status: true", source: https://127.0.0.1:62260/result_queue.js (44)
[7264:5912:0501/164945.469:INFO:CONSOLE(44)] "sendResultToTest: unsubscribe result: false", source: https://127.0.0.1:62260/result_queue.js (44)
Received fatal exception EXCEPTION_ACCESS_VIOLATION
Backtrace:
	(No symbol) [0x73657571]
	std::_Tree<std::_Tmap_traits<unsigned __int64,std::unique_ptr<mojo::MessageReceiver,std::default_delete<mojo::MessageReceiver> >,std::less<unsigned __int64>,std::allocator<std::pair<unsigned __int64 const ,std::unique_ptr<mojo::MessageReceiver,std::defaul [0x0421C450+42]
	std::_Tree<std::_Tmap_traits<unsigned __int64,std::unique_ptr<mojo::MessageReceiver,std::default_delete<mojo::MessageReceiver> >,std::less<unsigned __int64>,std::allocator<std::pair<unsigned __int64 const ,std::unique_ptr<mojo::MessageReceiver,std::defaul [0x0421C3C8+50]
	content::ServiceWorkerProviderHost::~ServiceWorkerProviderHost [0x028EB390+498]
	content::ServiceWorkerProviderHost::`vector deleting destructor' [0x028F1090+16]
	std::list<std::pair<int const ,std::unique_ptr<content::ServiceWorkerProviderHost,std::default_delete<content::ServiceWorkerProviderHost> > >,std::allocator<std::pair<int const ,std::unique_ptr<content::ServiceWorkerProviderHost,std::default_delete<conten [0x028B51AB+49]
	std::_Hash<std::_Umap_traits<int,std::unique_ptr<content::ServiceWorkerProviderHost,std::default_delete<content::ServiceWorkerProviderHost> >,std::_Uhash_compare<int,std::hash<int>,std::equal_to<int> >,std::allocator<std::pair<int const ,std::unique_ptr<c [0x028B516C+22]
	base::IDMap<std::unique_ptr<content::ServiceWorkerProviderHost,std::default_delete<content::ServiceWorkerProviderHost> >,int>::~IDMap<std::unique_ptr<content::ServiceWorkerProviderHost,std::default_delete<content::ServiceWorkerProviderHost> >,int> [0x028B5148+32]
	std::unique_ptr<base::IDMap<std::unique_ptr<content::ServiceWorkerProviderHost,std::default_delete<content::ServiceWorkerProviderHost> >,int>,std::default_delete<base::IDMap<std::unique_ptr<content::ServiceWorkerProviderHost,std::default_delete<content::S [0x028B511B+17]
	std::list<std::pair<int const ,std::unique_ptr<base::IDMap<std::unique_ptr<content::ServiceWorkerProviderHost,std::default_delete<content::ServiceWorkerProviderHost> >,int>,std::default_delete<base::IDMap<std::unique_ptr<content::ServiceWorkerProviderHost [0x028B51E6+38]
	std::_Hash<std::_Umap_traits<int,std::unique_ptr<base::IDMap<std::unique_ptr<content::ServiceWorkerProviderHost,std::default_delete<content::ServiceWorkerProviderHost> >,int>,std::default_delete<base::IDMap<std::unique_ptr<content::ServiceWorkerProviderHo [0x028B50C4+64]
	base::IDMap<std::unique_ptr<base::IDMap<std::unique_ptr<content::ServiceWorkerProviderHost,std::default_delete<content::ServiceWorkerProviderHost> >,int>,std::default_delete<base::IDMap<std::unique_ptr<content::ServiceWorkerProviderHost,std::default_delet [0x028B0AE2+270]
	content::ServiceWorkerContextCore::RemoveAllProviderHostsForProcess [0x028B0530+116]
	content::ServiceWorkerContextCore::RemoveDispatcherHost [0x028B0496+104]
	content::ServiceWorkerDispatcherHost::OnFilterRemoved [0x028D1039+121]
	IPC::ChannelProxy::Context::OnChannelClosed [0x04202B34+116]
	base::debug::TaskAnnotator::RunTask [0x03880D54+308]
	base::internal::IncomingTaskQueue::RunTask [0x038ACA49+105]
	base::MessageLoop::RunTask [0x03847207+519]

Adding the ServiceWorker component since the exception seems to occur in service worker code.

Comment 7 by awdf@chromium.org, May 10 2018 

I also wonder if this could be related to whatever is causing Issue 707528 (Flaky native crash during PushMessagingTest#testPushPermissionDenied)

Comment 8 by falken@chromium.org, Nov 28

Cc: -falken@chromium.org peter@chromium.org
Owner: falken@chromium.org
The stack in comment 6 looks like issue 854993.  I think this test might just be passing now. I'll try to re-enable it.
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/991f7405123ee6480d687bf021c507a98534957c

commit 991f7405123ee6480d687bf021c507a98534957c
Author: Matt Falkenhagen <falken@chromium.org>
Date: Wed Nov 28 02:25:03 2018

Re-enable PushMessagingBrowserTest.UnsubscribeSuccess

It was disabled due to a crash that looks similar to a bug that was
fixed, issue 854993. Try re-enabling it.

Bug:  838759 
Change-Id: Ia3e21a9fdccd5239af270987e6c432612f5ae15c
TBR: peter
Reviewed-on: https://chromium-review.googlesource.com/c/1352082
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611522}
[modify] https://crrev.com/991f7405123ee6480d687bf021c507a98534957c/chrome/browser/push_messaging/push_messaging_browsertest.cc
►

Sign in to add a comment