New issue
Advanced search Search tips

Issue 838756 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: WorkspaceLayoutManagerBackdropTest.OpenAppListInOverviewMode



Sign in to add a comment

WorkspaceLayoutManagerBackdropTest.OpenAppListInOverviewMode is Flaky

Project Member Reported by Findit, May 2 2018

Issue description

Findit has detected a flake at test WorkspaceLayoutManagerBackdropTest.OpenAppListInOverviewMode.

Culprit (100.0% confidence): https://chromium-review.googlesource.com/q/I3589702b278ac5fa556e1f77c7d8ec71d834547f
Regression range: None

Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy1gELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKfAWNocm9taXVtLm1lbW9yeS9MaW51eCBDaHJvbWl1bSBPUyBBU2FuIExTYW4gVGVzdHMgKDEpLzI3Mjc1L21hc2hfYXNoX3VuaXR0ZXN0cy9WMjl5YTNOd1lXTmxUR0Y1YjNWMFRXRnVZV2RsY2tKaFkydGtjbTl3VkdWemRDNVBjR1Z1UVhCd1RHbHpkRWx1VDNabGNuWnBaWGROYjJSbAwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM

If this result was incorrect, apply the label Findit-Incorrect-Result, mark the bug as Untriaged and the component Tools>Test>Findit>Flakiness.
 

Comment 1 by treib@chromium.org, May 3 2018

Owner: minch@chromium.org
Status: Assigned (was: Available)
The patch that introduced the flakiness has also been merged. So I will disable this test until it can be updated.
Project Member

Comment 3 by bugdroid1@chromium.org, May 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f84f1651cc79986e851bebcbb5c3e9bc124ab63e

commit f84f1651cc79986e851bebcbb5c3e9bc124ab63e
Author: jonross <jonross@chromium.org>
Date: Thu May 03 15:23:44 2018

Disable WorkspaceLayoutManagerBackdropTest.OpenAppListInOverviewMode

The test WorkspaceLayoutManagerBackdropTest.OpenAppListInOverviewMode is flaking
so I'm disabling.

TBR= xiyuan@chromium.org
TEST=WorkspaceLayoutManagerBackdropTest.OpenAppListInOverviewMode

Bug: 838756
Change-Id: I68f90b668996a885ef37e047d453e6ecca12217c
Reviewed-on: https://chromium-review.googlesource.com/1042350
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555739}
[modify] https://crrev.com/f84f1651cc79986e851bebcbb5c3e9bc124ab63e/ash/wm/workspace/workspace_layout_manager_unittest.cc

Labels: -Sheriff-Chromium
It was suspected that https://chromium-review.googlesource.com/c/chromium/src/+/1040533 would fix the mash crash. (rev 555538)

However the failure has shown on newer runs (rev 555717):
https://luci-milo.appspot.com/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/27302
The new failure is

[ RUN      ] WorkspaceLayoutManagerBackdropTest.OpenAppListInOverviewMode
[28967:28967:0503/090443.840635:3665664633:FATAL:scoped_render_pass_texture.cc(110)] Check failed: context_provider_->ContextCapabilities().texture_npot.

related to issue 803286. Not sure why this test triggers it though.
Project Member

Comment 7 by bugdroid1@chromium.org, May 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d730ee7e25d0c76ea769914442de439f32c3611

commit 6d730ee7e25d0c76ea769914442de439f32c3611
Author: Min Chen <minch@google.com>
Date: Fri May 04 18:44:38 2018

Disable WorkspaceLayoutManagerBackdropTest.OpenAppListInOverviewMode in asan.

Bug: 838756,  838822 ,  837092 
Change-Id: I9f7fcb79a8305632ca264324f69aee1ae7d2ac71
Reviewed-on: https://chromium-review.googlesource.com/1042868
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556132}
[modify] https://crrev.com/6d730ee7e25d0c76ea769914442de439f32c3611/ash/wm/workspace/workspace_layout_manager_unittest.cc

Comment 8 by minch@chromium.org, May 9 2018

Status: Fixed (was: Assigned)

Comment 9 by thakis@chromium.org, Jun 13 2018

Status: Assigned (was: Fixed)
This test is flaky in non-asan too, failed e.g. here: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux-chromeos-rel/23993
Project Member

Comment 10 by chromium...@appspot.gserviceaccount.com, Jun 14 2018

Labels: Sheriff-Chromium
Detected 21 new flakes for test/step "WorkspaceLayoutManagerBackdropTest.OpenAppListInOverviewMode". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyRwsSBUZsYWtlIjxXb3Jrc3BhY2VMYXlvdXRNYW5hZ2VyQmFja2Ryb3BUZXN0Lk9wZW5BcHBMaXN0SW5PdmVydmlld01vZGUM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).

Comment 11 Deleted

Comment 12 Deleted

Labels: -Pri-1 Pri-2
Project Member

Comment 15 by chromium...@appspot.gserviceaccount.com, Jun 15 2018

Detected 21 new flakes for test/step "WorkspaceLayoutManagerBackdropTest.OpenAppListInOverviewMode". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyRwsSBUZsYWtlIjxXb3Jrc3BhY2VMYXlvdXRNYW5hZ2VyQmFja2Ryb3BUZXN0Lk9wZW5BcHBMaXN0SW5PdmVydmlld01vZGUM. This message was posted automatically by the chromium-try-flakes app.
Project Member

Comment 16 by chromium...@appspot.gserviceaccount.com, Jun 16 2018

Detected 7 new flakes for test/step "WorkspaceLayoutManagerBackdropTest.OpenAppListInOverviewMode". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyRwsSBUZsYWtlIjxXb3Jrc3BhY2VMYXlvdXRNYW5hZ2VyQmFja2Ryb3BUZXN0Lk9wZW5BcHBMaXN0SW5PdmVydmlld01vZGUM. This message was posted automatically by the chromium-try-flakes app.
Project Member

Comment 17 by chromium...@appspot.gserviceaccount.com, Jun 18 2018

Detected 4 new flakes for test/step "WorkspaceLayoutManagerBackdropTest.OpenAppListInOverviewMode". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyRwsSBUZsYWtlIjxXb3Jrc3BhY2VMYXlvdXRNYW5hZ2VyQmFja2Ryb3BUZXN0Lk9wZW5BcHBMaXN0SW5PdmVydmlld01vZGUM. This message was posted automatically by the chromium-try-flakes app.

Comment 18 by treib@chromium.org, Jun 18 2018

I'll go ahead and disable the test.
Project Member

Comment 19 by bugdroid1@chromium.org, Jun 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/200e86c1d76d0c83ee18951695bcbad016d7f2fc

commit 200e86c1d76d0c83ee18951695bcbad016d7f2fc
Author: Marc Treib <treib@chromium.org>
Date: Mon Jun 18 13:29:18 2018

Disable flaky WorkspaceLayoutManagerBackdropTest.OpenAppListInOverviewMode

TBR=minch@chromium.org
NOTRY=true

Bug: 838756
Change-Id: I3cf207f31b7063f64c87d7cc0d8a93e6299ed5cd
Reviewed-on: https://chromium-review.googlesource.com/1104418
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567986}
[modify] https://crrev.com/200e86c1d76d0c83ee18951695bcbad016d7f2fc/ash/wm/workspace/workspace_layout_manager_unittest.cc

Comment 20 by treib@chromium.org, Jun 18 2018

Labels: -Pri-2 -Sheriff-Chromium Test-Disabled Pri-1
Project Member

Comment 21 by chromium...@appspot.gserviceaccount.com, Jun 19 2018

Labels: Sheriff-Chromium
Detected 3 new flakes for test/step "WorkspaceLayoutManagerBackdropTest.OpenAppListInOverviewMode". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyRwsSBUZsYWtlIjxXb3Jrc3BhY2VMYXlvdXRNYW5hZ2VyQmFja2Ryb3BUZXN0Lk9wZW5BcHBMaXN0SW5PdmVydmlld01vZGUM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Labels: -Sheriff-Chromium

Sign in to add a comment