Temporary fix for BlueZ's StartDiscovery and StopDiscovery retryable errors |
||||
Issue descriptionThe temporary fix is by having retry and backoff logic in bluetoothd for StartDiscovery and StopDiscovery. By freeing BlueZ's discovery API from retryable errors, it makes clients easier to use the API. The ideal fix requires major refactoring of StartDiscovery and StopDiscovery and will be done in the future as it's more risky.
,
May 2 2018
If we're going to put in retry, do you think it would be a good idea to put it in the dispatcher?
,
May 2 2018
We had a discussion about the possible implementations of this (go/magic-tether-metrics-improvement). Since we only need this for scanning (but not advertising), it's simpler to implement this in bluetoothd itself. If we needed a more general retrier (e.g. for both scanning and advertising), it would be simpler to have a general retrier in dispatcher.
,
May 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/bluez/+/bd1f37e94b4d2b2b2018a6a99cbb2dd939d3eef4 commit bd1f37e94b4d2b2b2018a6a99cbb2dd939d3eef4 Author: Sonny Sasaka <sonnysasaka@chromium.org> Date: Mon May 07 06:51:23 2018 CHROMIUM: Add retries for StartDiscovery and StopDiscovery This is a temporary fix for making StartDiscovery and StopDiscovery free from retryable errors. This works by having a retry and backoff logic inside bluetoothd for those methods. BUG= chromium:838755 TEST=Tested with simulated busy errors on StartDiscovery/StopDiscovery Change-Id: Iea86678916ab2a4ea552b212f6aae999d163cb64 Reviewed-on: https://chromium-review.googlesource.com/1039024 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Sonny Sasaka <sonnysasaka@chromium.org> Reviewed-by: Miao-chen Chou <mcchou@chromium.org> [modify] https://crrev.com/bd1f37e94b4d2b2b2018a6a99cbb2dd939d3eef4/src/adapter.c
,
Sep 5
,
Oct 4
|
||||
►
Sign in to add a comment |
||||
Comment 1 by sonnysasaka@chromium.org
, May 2 2018