Issue metadata
Sign in to add a comment
|
Launcher: Folders are not visible after updating device to ToT |
||||||||||||||||||||||
Issue descriptionChromeOS 10635.0.0, 68.0.3416.0 dev-channel Eve What steps will reproduce the problem? 1. Device on M67 build (10575.22.0, 67.0.3396.26). 2. Login to user account, open launcher and create folders by grouping few apps. 3. AU to M68 build (10635.0.0, 68.0.3416.0) and log-in to user account 4. Open launcher and check for the folders What is the expected result? Folders should be visible What happens instead? Folders are not visible. Empty fields are seen in place of folders. On clicking the empty field, folder view with apps is displayed. Attached screenshots.
,
May 2 2018
Debug logs: https://storage.cloud.google.com/chromiumos-test-logs/bugfiles/cr/838750/debug-logs_20180501-171705.tgz?_ga=2.32022715.-400827326.1524506579
,
May 2 2018
,
May 2 2018
,
May 2 2018
Able to reproduce the Issue on latest M-68 68.0.3416.0/10636.0.0 dev-channel Reks
,
May 2 2018
Possibly triggered by 828209 which is in 68.0.3416.0. khmel@ can you take a look since you authored the fix for 828209?
,
May 3 2018
,
May 4 2018
,
May 4 2018
Also reproducible on M67
,
May 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/65c26bd27a6315ed72e179b8a338f35572cf440c commit 65c26bd27a6315ed72e179b8a338f35572cf440c Author: khmel@google.com <khmel@google.com> Date: Sat May 05 00:01:36 2018 app_launcher: Prevent empty folders in app list. Fix issue when in some cases (usually reproducible on next user login) folders are rendered blank. Test: Locally Bug: 838750 Change-Id: I9249204c9416ad4a27d1754c308ffb5aa5a85453 Reviewed-on: https://chromium-review.googlesource.com/1045518 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#556260} [modify] https://crrev.com/65c26bd27a6315ed72e179b8a338f35572cf440c/ash/app_list/app_list_controller_impl.cc
,
May 5 2018
,
May 7 2018
Is #10 a confirmed resolution requiring a merge? If so please tag as such so we can unblock the RBB for M67. Thanks.
,
May 7 2018
Changing to RBS per IM with the owner
,
May 9 2018
Seeing this issue on M67 beta build (10575.32.0, 67.0.3396.41) but not repro'd on M68 build (10658.0.0, 68.0.3423.0). Tested on eve device.
,
May 11 2018
,
May 14 2018
,
May 16 2018
#12 -I cannot build M67 locally due simplechrome is currently broken for M67. But I am pretty sure that fixes chain of problems. So requesting merge and let see if this is fixed on m67 official builds.
,
May 16 2018
This bug requires manual review: We are only 12 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 16 2018
Approving merge to M67 Chrome OS.
,
May 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/93e99599f214d95ad40ccee138dd2a4e96fc7866 commit 93e99599f214d95ad40ccee138dd2a4e96fc7866 Author: khmel@google.com <khmel@google.com> Date: Thu May 17 23:47:52 2018 [Merge M67] app_launcher: Prevent empty folders in app list. Fix issue when in some cases (usually reproducible on next user login) folders are rendered blank. TBR=khmel@google.com (cherry picked from commit 65c26bd27a6315ed72e179b8a338f35572cf440c) Test: Locally Bug: 838750 Change-Id: I9249204c9416ad4a27d1754c308ffb5aa5a85453 Reviewed-on: https://chromium-review.googlesource.com/1045518 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#556260} Reviewed-on: https://chromium-review.googlesource.com/1064893 Reviewed-by: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#630} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/93e99599f214d95ad40ccee138dd2a4e96fc7866/ash/app_list/app_list_controller_impl.cc
,
May 17 2018
,
Jul 3
Verified on ChromeOS 10718.34.0, 68.0.3440.40 beta-channel eve |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by sdantul...@chromium.org
, May 2 2018