Issue metadata
Sign in to add a comment
|
Two finger navigation on touchpad broken on M-67 / Tot |
||||||||||||||||||||||
Issue descriptionversions: M-68 -- 68.0.3416.0 / 10635.0.0 M-67 -- 67.0.3396.29 / 10575.23.0 Steps: 1.Try to use two finger navigation on touchpad for history navigation ( to move back/forward) Observed: The two finger navigation is broken. Note: Two finger navigation works fine on M-66 66.0.3359.149/10452.81.0 build feedback report : https://listnr.corp.google.com/report/85386492353
,
May 2 2018
,
May 2 2018
,
May 2 2018
,
May 2 2018
I'll take a look, +chaopeng since he had a recent patch for disabling history navigation on Windows, and this might be a side effect regression. pbathini@ could you please explain what you mean by broken? Does it work or not work at all? Is it non-smooth animation, or delays? What should I look for if I want to reproduce the bug?
,
May 2 2018
I can reproduce this one. We should also check !defined(OS_CHROMEOS) in the disable condition.
,
May 2 2018
,
May 2 2018
I can also reproduce. For me, there is no animation at all, or any effect. It's as if the feature was completely removed.
,
May 2 2018
,
May 2 2018
,
May 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9da6a79f00b05144ed9784be63a9df70ef97c339 commit 9da6a79f00b05144ed9784be63a9df70ef97c339 Author: chaopeng <chaopeng@chromium.org> Date: Thu May 03 17:45:35 2018 Enable TouchpadOverscrollHistoryNavigation on CrOS In crrev.com/c/1013221, we want to disable TouchpadOverscrollHistoryNavigation on Windows and Linux. But we also disable it on CrOS because I forgot checking OS_CHROMEOS. In this patch, we enable TouchpadOverscrollHistoryNavigation on OS_CHROMEOS which is same as today stable. TouchpadOverscrollHistoryNavigation is Aura only, OS_MACOSX does not check this flag. Bug: 838741 Change-Id: Ib9362bc74af1cb800fab665079017fbcb7880402 Reviewed-on: https://chromium-review.googlesource.com/1039867 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#555799} [modify] https://crrev.com/9da6a79f00b05144ed9784be63a9df70ef97c339/content/public/common/content_features.cc
,
May 3 2018
,
May 3 2018
Duplicate issue. #CBC-RS/TC-watchlist. 839014 - 2-finger touchpad horizontal forward/back navigation gestures are broken - chromium - Monorail https://bugs.chromium.org/p/chromium/issues/detail?id=839014
,
May 3 2018
Duplicate - 838985 - two-finger swipe on touchpad for back/forward no longer works https://bugs.chromium.org/p/chromium/issues/detail?id=838985
,
May 4 2018
This bug requires manual review: M67 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 4 2018
Issue 839014 has been merged into this issue.
,
May 4 2018
Issue 839079 has been merged into this issue.
,
May 4 2018
Issue 838985 has been merged into this issue.
,
May 4 2018
Issue 837886 has been merged into this issue.
,
May 4 2018
There is a lot documented in this bug, can you provide test specifics for the merge approval? Thanks.
,
May 4 2018
The two finger navigation on touchpad now works on 68.0.3419.0 / 10646.0.0 build
,
May 4 2018
,
May 4 2018
,
May 7 2018
Thanks for #21, but why did this move from verified on #23? Lingering issues? Did you also test for unanticipated outcomes? Thanks
,
May 7 2018
I just want to keep it open to reminder me this issue still need to merge.
,
May 7 2018
approving for M67 per IM with owner. Thanks!
,
May 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/54b8b4e9903b6c320b3863fe053c2831b5ff18a6 commit 54b8b4e9903b6c320b3863fe053c2831b5ff18a6 Author: chaopeng <chaopeng@chromium.org> Date: Tue May 08 14:47:27 2018 Enable TouchpadOverscrollHistoryNavigation on CrOS In crrev.com/c/1013221, we want to disable TouchpadOverscrollHistoryNavigation on Windows and Linux. But we also disable it on CrOS because I forgot checking OS_CHROMEOS. In this patch, we enable TouchpadOverscrollHistoryNavigation on OS_CHROMEOS which is same as today stable. TouchpadOverscrollHistoryNavigation is Aura only, OS_MACOSX does not check this flag. TBR=chaopeng@chromium.org (cherry picked from commit 9da6a79f00b05144ed9784be63a9df70ef97c339) Bug: 838741 Change-Id: I895f089b8082c3ee627f5636cac236ee35b954b5 Reviewed-on: https://chromium-review.googlesource.com/1039867 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#555799} Reviewed-on: https://chromium-review.googlesource.com/1049958 Reviewed-by: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#515} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/54b8b4e9903b6c320b3863fe053c2831b5ff18a6/content/public/common/content_features.cc
,
May 8 2018
Has the merge been completed? Can this bug be closed out? Thanks.
,
May 8 2018
The fix landed at 68.0.3419.0 and merged to M67.
,
May 9 2018
If this issue is fixed; how do I fix it on my Chromebook? Is there going to be an uodate available soon? Thanks Asus Flip c302 / Version 67.0.3396.26 (Build officiel) beta (64 bits)
,
May 9 2018
RE croussel@gmail.com: Please wait for next beta update.
,
May 10 2018
Confirmed fixed on veron_minnie Google Chrome 67.0.3396.41 (Official Build) beta (32-bit) Revision 34ee466ffc8021ecae0f505e30eec2f41f4bc8d5-refs/branch-heads/3396@{#531} Platform 10575.32.0 (Official Build) beta-channel veyron_minnie Firmware Version Google_Veyron_Minnie.6588.237.0 ARC 4765583 JavaScript V8 6.7.288.32 Flash 29.0.0.171 /opt/google/chrome/pepper/libpepflashplayer.so User Agent Mozilla/5.0 (X11; CrOS armv7l 10575.32.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.41 Safari/537.36
,
May 11 2018
Issue 841108 has been merged into this issue. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by pbath...@chromium.org
, May 1 2018