New issue
Advanced search Search tips

Issue 838739 link

Starred by 3 users
Status: Fixed
Owner:
emir...@chromium.org
Closed: May 2018
Cc:
brandtr@chromium.org
mflodman@chromium.org
sprang@chromium.org
terelius@chromium.org
holmer@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocked on:
issue webrtc:7314


Sign in to add a comment

Set ImplementationName() correctly in webrtc::Video*coder implementations

Project Member Reported by emir...@chromium.org, May 1 2018 
Currently we do not implement these methods or set CodecSpecificInfo::codec_name field correctly. As a result, we get wrong results in codecImplementationName field of webrtc-internals.
Project Member

Comment 1 by bugdroid1@chromium.org, May 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f128bbe0913226faf2a06a9ccd4d9c796cab6f54

commit f128bbe0913226faf2a06a9ccd4d9c796cab6f54
Author: Emircan Uysaler <emircan@chromium.org>
Date: Fri May 04 20:15:09 2018

Set ImplementationName() correctly in webrtc::Video*coder implementations

We should set this field to distinguish HW codec implementations of Chromium
from SW codecs of WebRTC. googCodecName field already sets VP8/VP9/H264
information, so setting this field to a generic name "HW*coder" should be
enough.

Bug:  838739 
Change-Id: I9936daef9a53b6f004ede357e37fd976ca0d9c9e
Reviewed-on: https://chromium-review.googlesource.com/1039023
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556167}
[modify] https://crrev.com/f128bbe0913226faf2a06a9ccd4d9c796cab6f54/content/renderer/media/webrtc/rtc_video_decoder.cc
[modify] https://crrev.com/f128bbe0913226faf2a06a9ccd4d9c796cab6f54/content/renderer/media/webrtc/rtc_video_decoder.h
[modify] https://crrev.com/f128bbe0913226faf2a06a9ccd4d9c796cab6f54/content/renderer/media/webrtc/rtc_video_encoder.cc
[modify] https://crrev.com/f128bbe0913226faf2a06a9ccd4d9c796cab6f54/content/renderer/media/webrtc/rtc_video_encoder.h

Comment 2 by emir...@chromium.org, May 4 2018

Status: Fixed (was: Started)
►

Sign in to add a comment