[Omnibox] enable New Answer Layout |
||||||||||||||
Issue descriptionThe chrome Omnibox Answers in Suggest is getting is getting a new layout experiment. In this New Answer Layout the image is larger and to the left of the content text.
,
May 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f9a4ee477aef5783ddbdd8a1656c9bfb05dd5f5f commit f9a4ee477aef5783ddbdd8a1656c9bfb05dd5f5f Author: Dave Schuyler <dschuyler@chromium.org> Date: Wed May 09 18:55:06 2018 [Omnibox] Allow rich suggestion descriptions to wrap lines Most answers and entities have single line descriptions, but dictionary definitions are allowed to wrap. This CL allows for that wrapping. Also, fixes bug where the cached font_height_ wasn't updated properly. (Which would occasionally cause a line to be too tall). Bug: 838733 Change-Id: Ic1478acd6c62420f3bfd426b206973590b625729 Reviewed-on: https://chromium-review.googlesource.com/1048865 Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#557264} [modify] https://crrev.com/f9a4ee477aef5783ddbdd8a1656c9bfb05dd5f5f/chrome/browser/ui/views/omnibox/omnibox_match_cell_view.cc [modify] https://crrev.com/f9a4ee477aef5783ddbdd8a1656c9bfb05dd5f5f/chrome/browser/ui/views/omnibox/omnibox_match_cell_view.h [modify] https://crrev.com/f9a4ee477aef5783ddbdd8a1656c9bfb05dd5f5f/chrome/browser/ui/views/omnibox/omnibox_result_view.cc [modify] https://crrev.com/f9a4ee477aef5783ddbdd8a1656c9bfb05dd5f5f/chrome/browser/ui/views/omnibox/omnibox_text_view.cc [modify] https://crrev.com/f9a4ee477aef5783ddbdd8a1656c9bfb05dd5f5f/chrome/browser/ui/views/omnibox/omnibox_text_view.h
,
May 9 2018
,
May 12 2018
,
May 15 2018
,
Jun 16 2018
,
Jun 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/175bd6b8a999165c5b47598d3a0b53ad5ea8a3cc commit 175bd6b8a999165c5b47598d3a0b53ad5ea8a3cc Author: Dave Schuyler <dschuyler@chromium.org> Date: Wed Jun 20 18:26:12 2018 [Omnibox] Add png icon for translation answers This CL adds PNG icons for translation answers. Most answer icons are vector icons, but this one is a bit too complex. We should either simplify it or use a PNG. Bug: 838733 Change-Id: Ia8fbba3400dd4bb27d183e5422e4f2d08e4d973d Reviewed-on: https://chromium-review.googlesource.com/1107162 Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#568936} [add] https://crrev.com/175bd6b8a999165c5b47598d3a0b53ad5ea8a3cc/chrome/app/theme/default_100_percent/chromium/translate_round_32.png [add] https://crrev.com/175bd6b8a999165c5b47598d3a0b53ad5ea8a3cc/chrome/app/theme/default_200_percent/chromium/translate_round_32.png [modify] https://crrev.com/175bd6b8a999165c5b47598d3a0b53ad5ea8a3cc/chrome/app/theme/theme_resources.grd [modify] https://crrev.com/175bd6b8a999165c5b47598d3a0b53ad5ea8a3cc/chrome/browser/ui/views/omnibox/omnibox_match_cell_view.cc
,
Jun 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae3c206077f01e049c577598f0f59ddc597ffb52 commit ae3c206077f01e049c577598f0f59ddc597ffb52 Author: Dave Schuyler <dschuyler@chromium.org> Date: Wed Jun 20 20:39:31 2018 [Omnibox] Default answer icon This CL adds a default (or fallback) icon for Answers in Suggest that don't have a specific icon. Bug: 838733 Change-Id: I723d64e29f8222e873345c6e04d90e1b26cb1631 Reviewed-on: https://chromium-review.googlesource.com/1108514 Reviewed-by: Mark Pearson <mpearson@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#568999} [modify] https://crrev.com/ae3c206077f01e049c577598f0f59ddc597ffb52/chrome/browser/ui/views/omnibox/omnibox_match_cell_view.cc [modify] https://crrev.com/ae3c206077f01e049c577598f0f59ddc597ffb52/components/omnibox/browser/BUILD.gn [add] https://crrev.com/ae3c206077f01e049c577598f0f59ddc597ffb52/components/omnibox/browser/vector_icons/answer_default.icon
,
Jun 21 2018
,
Jun 25 2018
,
Jun 26 2018
Re-opening and assigning to orinj for any subsequent polish work.
,
Jun 26 2018
,
Jun 29 2018
,
Jul 11
orinj: Aside from the row order issue, which we're tracking in bug 855783 , I think the remaining thing to do here is to adjust the color and size of the text to mach the spec (redlines) I just sent you.
,
Jul 11
The remaining tasks here (see previous comment) are P2.
,
Jul 12
,
Jul 12
,
Jul 18
Color and text size looks correct to me in today's Canary (69.0.3495.0). There are some other minor issues but emilyschechter filed separate bugs for those.
,
Jul 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d2dd1db0e33c582d6b2336bb6b32e241d25295c0 commit d2dd1db0e33c582d6b2336bb6b32e241d25295c0 Author: Orin Jaworski <orinj@chromium.org> Date: Wed Jul 18 17:25:53 2018 [omnibox] Leave "= " in calculator result match contents The "= " was getting removed from start of calculator answers but now it will be left in when new answer layout is enabled. Bug: 838733 Change-Id: Ice7bf2087cc51cd052744164018ff74f4aeb68a7 Reviewed-on: https://chromium-review.googlesource.com/1141126 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#576109} [modify] https://crrev.com/d2dd1db0e33c582d6b2336bb6b32e241d25295c0/components/omnibox/browser/search_suggestion_parser.cc
,
Jul 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/84450b053a085a1a5c019362e241a8e4344a6d3c commit 84450b053a085a1a5c019362e241a8e4344a6d3c Author: Orin Jaworski <orinj@chromium.org> Date: Thu Jul 19 07:46:01 2018 [omnibox] Use new text context instead of an explicit size delta To deemphasize answer descriptions, a font with explicit size delta was being used, resulting in two font fetches. Now there is a new entry in ChromeTextContext so only one is needed. The appearance and behavior should remain the same, but this follow-up CL simplifies API usage, speed, and maintainability. Change-Id: I3a171cddf7b6e1620879b76239cfdf4f975615a1 Bug: 838733 Change-Id: I3a171cddf7b6e1620879b76239cfdf4f975615a1 Reviewed-on: https://chromium-review.googlesource.com/1142019 Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#576412} [modify] https://crrev.com/84450b053a085a1a5c019362e241a8e4344a6d3c/chrome/browser/ui/views/harmony/chrome_typography.cc [modify] https://crrev.com/84450b053a085a1a5c019362e241a8e4344a6d3c/chrome/browser/ui/views/harmony/chrome_typography.h [modify] https://crrev.com/84450b053a085a1a5c019362e241a8e4344a6d3c/chrome/browser/ui/views/omnibox/omnibox_result_view.cc [modify] https://crrev.com/84450b053a085a1a5c019362e241a8e4344a6d3c/chrome/browser/ui/views/omnibox/omnibox_text_view.cc [modify] https://crrev.com/84450b053a085a1a5c019362e241a8e4344a6d3c/chrome/browser/ui/views/omnibox/omnibox_text_view.h |
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by bugdroid1@chromium.org
, May 3 2018