Floating accessibility keyboard overscrolls |
||
Issue descriptionChrome Version: 68.0.3415.0 OS: ChromeOS Eve What steps will reproduce the problem? (1) Turn on accessibility keyboard (2) Switch to floating keyboard (3) Focus and unfocus a textfield. What happens? Overscrolling is triggered. Seems weird since non-accessibility floating keyboard doesn't do overscrolling. Not sure if it's intended behaviour. Does overscrolling even make sense for floating?
,
May 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8bc2d0a333289d3ec45677672a61c8a343e6a106 commit 8bc2d0a333289d3ec45677672a61c8a343e6a106 Author: Darren Shen <shend@chromium.org> Date: Wed May 16 23:33:09 2018 [VK] Prevent floating keyboard from moving the focused window. Currently, when the keyboard is shown, we check if it obscures the focused window. If it does, we move the focused window upwards so that it's no longer obscured by the text field. While this works well for the docked keyboard, it doesn't make much sense for the floating keyboard. Thus, we change the logic to use the occluded bounds of the keyboard to check whether it obscures the focused window. The occluded bounds is the same as the actual bounds for the docked keyboard, but is empty for the floating keyboard. This means that the floating keyboard will no longer cause the focused window to move upwards. Bug: 838731 Change-Id: Id5de5c35980c69443be114631840bdfb64f26b3e Reviewed-on: https://chromium-review.googlesource.com/1059976 Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#559336} [modify] https://crrev.com/8bc2d0a333289d3ec45677672a61c8a343e6a106/ash/root_window_controller_unittest.cc [modify] https://crrev.com/8bc2d0a333289d3ec45677672a61c8a343e6a106/ui/keyboard/BUILD.gn [modify] https://crrev.com/8bc2d0a333289d3ec45677672a61c8a343e6a106/ui/keyboard/keyboard_controller.cc [modify] https://crrev.com/8bc2d0a333289d3ec45677672a61c8a343e6a106/ui/keyboard/keyboard_controller_unittest.cc [modify] https://crrev.com/8bc2d0a333289d3ec45677672a61c8a343e6a106/ui/keyboard/keyboard_ui.cc [modify] https://crrev.com/8bc2d0a333289d3ec45677672a61c8a343e6a106/ui/keyboard/keyboard_ui.h
,
May 17 2018
Seems to be fixed from my testing on ToT. |
||
►
Sign in to add a comment |
||
Comment 1 by yhanada@chromium.org
, May 15 2018Status: Assigned (was: Untriaged)