New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 838725 link

Starred by 4 users
Status: Assigned
Owner:
█ vikassoni@chromium.org
Last visit > 30 days ago
Cc:
vmi...@chromium.org
sande...@chromium.org
ericrk@chromium.org
liber...@chromium.org
dalecur...@chromium.org
kkinnu...@nvidia.com
mcasas@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Task



Sign in to add a comment

New Video decode path using AImageReader

Project Member Reported by vikassoni@chromium.org, May 1 2018 
Currently Video decoding path on android (both AVDA and MCVD) uses surface textures. Surface textures can be used to create only GL textures from the video frames.
Going forward we need to have capability to create Vulkan textures as well.

Hence to support this we need to use Android ImageReader (available from OREO). Using this new api we will be able to create both GL and vulkan texture from a video frame.

To implement this new AImageReader video decode path, we are breaking this task into following smaller subtasks :

1. Refactor existing surface texture gl owner code (/media/gpu/android/surface_texture_gl_owner.h) to remove the  surface texture gl owner interface (SurfaceTextureGLOwner) from its implementation (SurfaceTextureGLOwnerImpl). Currently both interface and implementation are in single header file.
Also rename the interface from SurfaceTextureGLOwner to a generic name TextureOwner. This is because now we will have 2 different implementation of this interface - a.using surface texture, b. using AImageReader.
Link to patch - https://chromium-review.googlesource.com/c/chromium/src/+/1038125


2. Write a new utility/helper class to dynamically load the AImageReader functions for android versions >=OREO at runtime. Currently we are not able to directly bump up the android NDK version as it will not be backward compatible. Hence the only way to newer OS api is to dynamically load it.
Link to patch - https://chromium-review.googlesource.com/c/chromium/src/+/1031113/11


3. Implement new video decode path using AImageReader.
Link to patch - https://chromium-review.googlesource.com/c/chromium/src/+/963506/23
Project Member

Comment 1 by bugdroid1@chromium.org, May 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eef5fab4c2246926eec7347918f5480864f94ffe

commit eef5fab4c2246926eec7347918f5480864f94ffe
Author: Vikas Soni <vikassoni@chromium.org>
Date: Thu May 03 00:51:38 2018

Load Android Image Reader functions at run-time.

This CL is adding a new class that provides run-time support
for working with AImage, AImageReader and ANativeWindow
objects on Android O systems without requiring building for
the Android O NDK level.

Bug : 838725

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I30b3cd69af1f387344301bb6b8472f98b8ff0cf3
Reviewed-on: https://chromium-review.googlesource.com/1031113
Commit-Queue: vikas soni <vikassoni@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555633}
[modify] https://crrev.com/eef5fab4c2246926eec7347918f5480864f94ffe/media/base/media_switches.cc
[modify] https://crrev.com/eef5fab4c2246926eec7347918f5480864f94ffe/media/base/media_switches.h
[modify] https://crrev.com/eef5fab4c2246926eec7347918f5480864f94ffe/media/gpu/BUILD.gn
[add] https://crrev.com/eef5fab4c2246926eec7347918f5480864f94ffe/media/gpu/android/android_image_reader_abi.h
[add] https://crrev.com/eef5fab4c2246926eec7347918f5480864f94ffe/media/gpu/android/android_image_reader_compat.cc
[add] https://crrev.com/eef5fab4c2246926eec7347918f5480864f94ffe/media/gpu/android/android_image_reader_compat.h
[add] https://crrev.com/eef5fab4c2246926eec7347918f5480864f94ffe/media/gpu/android/android_image_reader_compat_unittest.cc

Comment 2 by khushals...@chromium.org, May 4 2018

Labels: -Type-Bug Type-Task
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, May 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5eda88894d1ec81029f54ea888d837aecbac844

commit e5eda88894d1ec81029f54ea888d837aecbac844
Author: Vikas Soni <vikassoni@chromium.org>
Date: Tue May 08 18:30:58 2018

Rename SurfaceTextureGLOwner interface and its usage.

Rename SurfaceTextureGLOwner interface to a more generic name TextureOwner.
This is because in future this interface will have multiple different
implementations. Also rename current implementation of this interface
SurfaceTextureGLOwnerImpl to SurfaceTextureGLOwner.
Rename all the usage of this surface texture interface to texture owner.
Please see crbug for more details.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I17ae56c12ac86cb09e57ad9c8e7a91d9927d4b1b
Bug: 838725
Reviewed-on: https://chromium-review.googlesource.com/1038125
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: vikas soni <vikassoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556888}
[modify] https://crrev.com/e5eda88894d1ec81029f54ea888d837aecbac844/cc/resources/video_resource_updater.cc
[modify] https://crrev.com/e5eda88894d1ec81029f54ea888d837aecbac844/content/renderer/media/webrtc/rtc_video_decoder.cc
[modify] https://crrev.com/e5eda88894d1ec81029f54ea888d837aecbac844/media/base/video_frame_metadata.h
[modify] https://crrev.com/e5eda88894d1ec81029f54ea888d837aecbac844/media/filters/gpu_video_decoder.cc
[modify] https://crrev.com/e5eda88894d1ec81029f54ea888d837aecbac844/media/gpu/BUILD.gn
[modify] https://crrev.com/e5eda88894d1ec81029f54ea888d837aecbac844/media/gpu/android/android_video_decode_accelerator.cc
[modify] https://crrev.com/e5eda88894d1ec81029f54ea888d837aecbac844/media/gpu/android/android_video_decode_accelerator.h
[modify] https://crrev.com/e5eda88894d1ec81029f54ea888d837aecbac844/media/gpu/android/android_video_decode_accelerator_unittest.cc
[modify] https://crrev.com/e5eda88894d1ec81029f54ea888d837aecbac844/media/gpu/android/android_video_surface_chooser.h
[modify] https://crrev.com/e5eda88894d1ec81029f54ea888d837aecbac844/media/gpu/android/android_video_surface_chooser_impl.cc
[modify] https://crrev.com/e5eda88894d1ec81029f54ea888d837aecbac844/media/gpu/android/android_video_surface_chooser_impl.h
[modify] https://crrev.com/e5eda88894d1ec81029f54ea888d837aecbac844/media/gpu/android/android_video_surface_chooser_impl_unittest.cc
[modify] https://crrev.com/e5eda88894d1ec81029f54ea888d837aecbac844/media/gpu/android/avda_codec_image.cc
[modify] https://crrev.com/e5eda88894d1ec81029f54ea888d837aecbac844/media/gpu/android/avda_codec_image.h
[modify] https://crrev.com/e5eda88894d1ec81029f54ea888d837aecbac844/media/gpu/android/avda_picture_buffer_manager.cc
[modify] https://crrev.com/e5eda88894d1ec81029f54ea888d837aecbac844/media/gpu/android/avda_picture_buffer_manager.h
[modify] https://crrev.com/e5eda88894d1ec81029f54ea888d837aecbac844/media/gpu/android/avda_shared_state.cc
[modify] https://crrev.com/e5eda88894d1ec81029f54ea888d837aecbac844/media/gpu/android/avda_shared_state.h
[modify] https://crrev.com/e5eda88894d1ec81029f54ea888d837aecbac844/media/gpu/android/avda_surface_bundle.cc
[modify] https://crrev.com/e5eda88894d1ec81029f54ea888d837aecbac844/media/gpu/android/avda_surface_bundle.h
[modify] https://crrev.com/e5eda88894d1ec81029f54ea888d837aecbac844/media/gpu/android/codec_image.cc
[modify] https://crrev.com/e5eda88894d1ec81029f54ea888d837aecbac844/media/gpu/android/codec_image.h
[modify] https://crrev.com/e5eda88894d1ec81029f54ea888d837aecbac844/media/gpu/android/codec_image_unittest.cc
[modify] https://crrev.com/e5eda88894d1ec81029f54ea888d837aecbac844/media/gpu/android/fake_codec_allocator.cc
[modify] https://crrev.com/e5eda88894d1ec81029f54ea888d837aecbac844/media/gpu/android/fake_codec_allocator.h
[modify] https://crrev.com/e5eda88894d1ec81029f54ea888d837aecbac844/media/gpu/android/media_codec_video_decoder.cc
[modify] https://crrev.com/e5eda88894d1ec81029f54ea888d837aecbac844/media/gpu/android/media_codec_video_decoder.h
[modify] https://crrev.com/e5eda88894d1ec81029f54ea888d837aecbac844/media/gpu/android/media_codec_video_decoder_unittest.cc
[modify] https://crrev.com/e5eda88894d1ec81029f54ea888d837aecbac844/media/gpu/android/mock_android_video_surface_chooser.cc
[modify] https://crrev.com/e5eda88894d1ec81029f54ea888d837aecbac844/media/gpu/android/mock_android_video_surface_chooser.h
[delete] https://crrev.com/516cc36eb209e416ee9560b994ab47abf75830d9/media/gpu/android/mock_surface_texture_gl_owner.cc
[add] https://crrev.com/e5eda88894d1ec81029f54ea888d837aecbac844/media/gpu/android/mock_texture_owner.cc
[rename] https://crrev.com/e5eda88894d1ec81029f54ea888d837aecbac844/media/gpu/android/mock_texture_owner.h
[modify] https://crrev.com/e5eda88894d1ec81029f54ea888d837aecbac844/media/gpu/android/surface_chooser_helper.cc
[modify] https://crrev.com/e5eda88894d1ec81029f54ea888d837aecbac844/media/gpu/android/surface_chooser_helper.h
[modify] https://crrev.com/e5eda88894d1ec81029f54ea888d837aecbac844/media/gpu/android/surface_chooser_helper_unittest.cc
[modify] https://crrev.com/e5eda88894d1ec81029f54ea888d837aecbac844/media/gpu/android/surface_texture_gl_owner_unittest.cc
[rename] https://crrev.com/e5eda88894d1ec81029f54ea888d837aecbac844/media/gpu/android/texture_owner.cc
[rename] https://crrev.com/e5eda88894d1ec81029f54ea888d837aecbac844/media/gpu/android/texture_owner.h
[modify] https://crrev.com/e5eda88894d1ec81029f54ea888d837aecbac844/media/gpu/android/video_frame_factory.h
[modify] https://crrev.com/e5eda88894d1ec81029f54ea888d837aecbac844/media/gpu/android/video_frame_factory_impl.cc
[modify] https://crrev.com/e5eda88894d1ec81029f54ea888d837aecbac844/media/gpu/android/video_frame_factory_impl.h
[modify] https://crrev.com/e5eda88894d1ec81029f54ea888d837aecbac844/media/gpu/android/video_frame_factory_impl_unittest.cc
[modify] https://crrev.com/e5eda88894d1ec81029f54ea888d837aecbac844/media/gpu/ipc/client/gpu_video_decode_accelerator_host.cc
[modify] https://crrev.com/e5eda88894d1ec81029f54ea888d837aecbac844/media/gpu/ipc/service/gpu_video_decode_accelerator.cc
[modify] https://crrev.com/e5eda88894d1ec81029f54ea888d837aecbac844/media/gpu/ipc/service/picture_buffer_manager.cc
[modify] https://crrev.com/e5eda88894d1ec81029f54ea888d837aecbac844/media/video/picture.cc
[modify] https://crrev.com/e5eda88894d1ec81029f54ea888d837aecbac844/media/video/picture.h
[modify] https://crrev.com/e5eda88894d1ec81029f54ea888d837aecbac844/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/e5eda88894d1ec81029f54ea888d837aecbac844/tools/metrics/histograms/histograms.xml
Project Member

Comment 4 by bugdroid1@chromium.org, May 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ba01b68b6994fee65e8bbdbace12a85ea7bc4c9

commit 0ba01b68b6994fee65e8bbdbace12a85ea7bc4c9
Author: Vikas Soni <vikassoni@chromium.org>
Date: Wed May 09 21:01:55 2018

Refactor TextureOwner interface.

Seperate out TextureOwner interface and its implementation
SurfaceTextureGLOwner from a single file.

Bug : 838725

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I2d9d0aab0326aed9acd6800ad45a9f333a56cf93
Reviewed-on: https://chromium-review.googlesource.com/1045905
Commit-Queue: vikas soni <vikassoni@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557313}
[modify] https://crrev.com/0ba01b68b6994fee65e8bbdbace12a85ea7bc4c9/media/gpu/BUILD.gn
[modify] https://crrev.com/0ba01b68b6994fee65e8bbdbace12a85ea7bc4c9/media/gpu/android/avda_picture_buffer_manager.h
[modify] https://crrev.com/0ba01b68b6994fee65e8bbdbace12a85ea7bc4c9/media/gpu/android/avda_surface_bundle.h
[modify] https://crrev.com/0ba01b68b6994fee65e8bbdbace12a85ea7bc4c9/media/gpu/android/codec_image.h
[add] https://crrev.com/0ba01b68b6994fee65e8bbdbace12a85ea7bc4c9/media/gpu/android/surface_texture_gl_owner.cc
[add] https://crrev.com/0ba01b68b6994fee65e8bbdbace12a85ea7bc4c9/media/gpu/android/surface_texture_gl_owner.h
[modify] https://crrev.com/0ba01b68b6994fee65e8bbdbace12a85ea7bc4c9/media/gpu/android/surface_texture_gl_owner_unittest.cc
[modify] https://crrev.com/0ba01b68b6994fee65e8bbdbace12a85ea7bc4c9/media/gpu/android/texture_owner.cc
[modify] https://crrev.com/0ba01b68b6994fee65e8bbdbace12a85ea7bc4c9/media/gpu/android/texture_owner.h
[modify] https://crrev.com/0ba01b68b6994fee65e8bbdbace12a85ea7bc4c9/media/gpu/android/video_frame_factory_impl.h
Project Member

Comment 5 by bugdroid1@chromium.org, May 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/158fa75a987d97f1ecb7b776df83395a1860f09b

commit 158fa75a987d97f1ecb7b776df83395a1860f09b
Author: Vikas Soni <vikassoni@chromium.org>
Date: Fri May 25 20:11:25 2018

Implement Video decode path using AImageReader.

Implement a new video decode path using Android Image
Reader API which is available from OREO+. Using android
image reader, both GL and Vulkan textures can be created
from video frames which is the main motivation behind this
new path. Existing SurfaceTexture based path will be the
used for android versions < OREO.

Bug : 838725

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ib44ac6128340b1419c2bdcc786e3d9d59614e462
Reviewed-on: https://chromium-review.googlesource.com/963506
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: vikas soni <vikassoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561988}
[modify] https://crrev.com/158fa75a987d97f1ecb7b776df83395a1860f09b/media/gpu/BUILD.gn
[modify] https://crrev.com/158fa75a987d97f1ecb7b776df83395a1860f09b/media/gpu/android/android_image_reader_abi.h
[modify] https://crrev.com/158fa75a987d97f1ecb7b776df83395a1860f09b/media/gpu/android/android_image_reader_compat.cc
[modify] https://crrev.com/158fa75a987d97f1ecb7b776df83395a1860f09b/media/gpu/android/android_image_reader_compat.h
[modify] https://crrev.com/158fa75a987d97f1ecb7b776df83395a1860f09b/media/gpu/android/avda_picture_buffer_manager.cc
[add] https://crrev.com/158fa75a987d97f1ecb7b776df83395a1860f09b/media/gpu/android/image_reader_gl_owner.cc
[add] https://crrev.com/158fa75a987d97f1ecb7b776df83395a1860f09b/media/gpu/android/image_reader_gl_owner.h
[add] https://crrev.com/158fa75a987d97f1ecb7b776df83395a1860f09b/media/gpu/android/image_reader_gl_owner_unittest.cc
[modify] https://crrev.com/158fa75a987d97f1ecb7b776df83395a1860f09b/media/gpu/android/surface_texture_gl_owner.cc
[modify] https://crrev.com/158fa75a987d97f1ecb7b776df83395a1860f09b/media/gpu/android/surface_texture_gl_owner.h
[modify] https://crrev.com/158fa75a987d97f1ecb7b776df83395a1860f09b/media/gpu/android/texture_owner.cc
[modify] https://crrev.com/158fa75a987d97f1ecb7b776df83395a1860f09b/media/gpu/android/texture_owner.h
[modify] https://crrev.com/158fa75a987d97f1ecb7b776df83395a1860f09b/media/gpu/android/video_frame_factory_impl.cc
[modify] https://crrev.com/158fa75a987d97f1ecb7b776df83395a1860f09b/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/158fa75a987d97f1ecb7b776df83395a1860f09b/tools/metrics/histograms/histograms.xml
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42ce1ccee475c715d67138163bdb952702206cda

commit 42ce1ccee475c715d67138163bdb952702206cda
Author: Vikas Soni <vikassoni@chromium.org>
Date: Mon Jun 04 22:48:12 2018

Fieldtrial config for AImageReaderVideoOutput.

Bug: 838725
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ibb47e67bf4eb8d89545ad3753175a4fba6921988
Reviewed-on: https://chromium-review.googlesource.com/1081306
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Victor Miura <vmiura@chromium.org>
Commit-Queue: vikas soni <vikassoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564280}
[modify] https://crrev.com/42ce1ccee475c715d67138163bdb952702206cda/testing/variations/fieldtrial_testing_config.json
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/acd0a968bee3673d45d85e48c8d92e520a13e873

commit acd0a968bee3673d45d85e48c8d92e520a13e873
Author: Vikas Soni <vikassoni@chromium.org>
Date: Tue Jul 17 22:47:59 2018

Relocate AndroidImageReader class and a media flag.

Move AndroidImageReader class out from media/gpu/android to
a more generic location base/android as this helper class will also be
used outside of the media/gpu/android.
Also make the media flag kAImageReaderVideoOutput static member of
this class since this flag is only used inside this class.

Bug: 838725
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ie4da6bd555db3c3ebfa3f0f01b4009010d53e704
Reviewed-on: https://chromium-review.googlesource.com/1135812
Reviewed-by: Frank Liberato <liberato@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: vikas soni <vikassoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575823}
[modify] https://crrev.com/acd0a968bee3673d45d85e48c8d92e520a13e873/base/BUILD.gn
[rename] https://crrev.com/acd0a968bee3673d45d85e48c8d92e520a13e873/base/android/android_image_reader_abi.h
[rename] https://crrev.com/acd0a968bee3673d45d85e48c8d92e520a13e873/base/android/android_image_reader_compat.cc
[rename] https://crrev.com/acd0a968bee3673d45d85e48c8d92e520a13e873/base/android/android_image_reader_compat.h
[rename] https://crrev.com/acd0a968bee3673d45d85e48c8d92e520a13e873/base/android/android_image_reader_compat_unittest.cc
[modify] https://crrev.com/acd0a968bee3673d45d85e48c8d92e520a13e873/media/gpu/BUILD.gn
[modify] https://crrev.com/acd0a968bee3673d45d85e48c8d92e520a13e873/media/gpu/android/image_reader_gl_owner.cc
[modify] https://crrev.com/acd0a968bee3673d45d85e48c8d92e520a13e873/media/gpu/android/image_reader_gl_owner.h
[modify] https://crrev.com/acd0a968bee3673d45d85e48c8d92e520a13e873/media/gpu/android/image_reader_gl_owner_unittest.cc
[modify] https://crrev.com/acd0a968bee3673d45d85e48c8d92e520a13e873/media/gpu/android/texture_owner.cc

Comment 8 by dalecur...@chromium.org, Jul 25 

There's a huge increase in PIPELINE_ERROR_DECODE within the experiment group that needs some investigation before this launches any further:
https://uma.googleplex.com/p/chrome/variations/?sid=b0653170edd3d11822f15c66ef297819

Comment 9 by vikassoni@chromium.org, Jul 25 

ok sure. Thank dale for letting me know. I will check why this is happening.

Comment 10 by vikassoni@chromium.org, Jul 25 

dalecurtis@  -> Also are there other histograms or a list of histograms which i should monitor. Please let me know.

Comment 11 by dalecur...@chromium.org, Jul 25

Cc: sande...@chromium.org
The Media.WatchTime.AudioVideo.All and Media.PipelineStatus.AudioVideo.H264.HW linked in c#8 are good catch alls. You can look at any of the Media.PipelineStatus.*.HW ones to capture MediaCodec issues.

I don't see any other MediaCodecVideoDecoder ones beyond that. Maybe liberato@ or sandersd@ knows of some other ones that would be useful to look into.
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/882982e15ffc00ea3e0e6abe2e47a083821e29ff

commit 882982e15ffc00ea3e0e6abe2e47a083821e29ff
Author: Vikas Soni <vikassoni@chromium.org>
Date: Sun Aug 05 19:50:58 2018

AImagereader based implementation for MediaPlayer.

Create an AImageReader based implementation to be used
for running videos via MediaPlayer. This new implementation
will be used for android O+ whereas SurfaceTexture based
implementation will continue to be used for older android
versions.
Added a feature flag to enable/disable this feature and to
allow rollout using Finch experiment.

Bug: 838725
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I5047b162b6d1729cc4a5c4c8dd31507252a5a389
Reviewed-on: https://chromium-review.googlesource.com/1133966
Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: vikas soni <vikassoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580782}
[modify] https://crrev.com/882982e15ffc00ea3e0e6abe2e47a083821e29ff/content/app/android/content_child_process_service_delegate.cc
[modify] https://crrev.com/882982e15ffc00ea3e0e6abe2e47a083821e29ff/content/browser/android/scoped_surface_request_manager.cc
[modify] https://crrev.com/882982e15ffc00ea3e0e6abe2e47a083821e29ff/content/browser/android/scoped_surface_request_manager.h
[modify] https://crrev.com/882982e15ffc00ea3e0e6abe2e47a083821e29ff/content/browser/android/scoped_surface_request_manager_unittest.cc
[modify] https://crrev.com/882982e15ffc00ea3e0e6abe2e47a083821e29ff/content/public/android/java/src/org/chromium/content/app/ContentChildProcessServiceDelegate.java
[modify] https://crrev.com/882982e15ffc00ea3e0e6abe2e47a083821e29ff/gpu/config/gpu_finch_features.cc
[modify] https://crrev.com/882982e15ffc00ea3e0e6abe2e47a083821e29ff/gpu/config/gpu_finch_features.h
[modify] https://crrev.com/882982e15ffc00ea3e0e6abe2e47a083821e29ff/gpu/ipc/common/BUILD.gn
[add] https://crrev.com/882982e15ffc00ea3e0e6abe2e47a083821e29ff/gpu/ipc/common/android/android_image_reader_utils.cc
[add] https://crrev.com/882982e15ffc00ea3e0e6abe2e47a083821e29ff/gpu/ipc/common/android/android_image_reader_utils.h
[modify] https://crrev.com/882982e15ffc00ea3e0e6abe2e47a083821e29ff/gpu/ipc/common/android/scoped_surface_request_conduit.h
[add] https://crrev.com/882982e15ffc00ea3e0e6abe2e47a083821e29ff/gpu/ipc/common/android/surface_owner_android.cc
[add] https://crrev.com/882982e15ffc00ea3e0e6abe2e47a083821e29ff/gpu/ipc/common/android/surface_owner_android.h
[modify] https://crrev.com/882982e15ffc00ea3e0e6abe2e47a083821e29ff/gpu/ipc/service/stream_texture_android.cc
[modify] https://crrev.com/882982e15ffc00ea3e0e6abe2e47a083821e29ff/gpu/ipc/service/stream_texture_android.h
[modify] https://crrev.com/882982e15ffc00ea3e0e6abe2e47a083821e29ff/media/gpu/BUILD.gn
[modify] https://crrev.com/882982e15ffc00ea3e0e6abe2e47a083821e29ff/media/gpu/android/image_reader_gl_owner.cc
[modify] https://crrev.com/882982e15ffc00ea3e0e6abe2e47a083821e29ff/tools/metrics/histograms/histograms.xml
Project Member

Comment 13 by bugdroid1@chromium.org, Aug 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e015a2536d02e21d516c544d85615e844b391cce

commit e015a2536d02e21d516c544d85615e844b391cce
Author: Vikas Soni <vikassoni@chromium.org>
Date: Thu Aug 16 20:06:26 2018

Add usage flag to AImageReader.

Use a different api to create AImageReader which also requires a flag.
This flag tells the usage of the images generated by AImageReader. If
the images are going to be used by GPU as a texture, we need to set
the usage flag as AHARDWAREBUFFER_USAGE_GPU_SAMPLED_IMAGE.

Bug: 838725
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I871183dd4b9b8dfcd723b40dd2162998c3f3a601
Reviewed-on: https://chromium-review.googlesource.com/1176541
Commit-Queue: vikas soni <vikassoni@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Martin Barbella <mbarbella@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583785}
[modify] https://crrev.com/e015a2536d02e21d516c544d85615e844b391cce/base/android/android_image_reader_abi.h
[modify] https://crrev.com/e015a2536d02e21d516c544d85615e844b391cce/base/android/android_image_reader_compat.cc
[modify] https://crrev.com/e015a2536d02e21d516c544d85615e844b391cce/base/android/android_image_reader_compat.h
[modify] https://crrev.com/e015a2536d02e21d516c544d85615e844b391cce/gpu/ipc/common/android/surface_owner_android.cc
[modify] https://crrev.com/e015a2536d02e21d516c544d85615e844b391cce/media/gpu/android/image_reader_gl_owner.cc
Project Member

Comment 14 by bugdroid1@chromium.org, Aug 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2364c68c3dca2b4fe489362c703355dfc210d07f

commit 2364c68c3dca2b4fe489362c703355dfc210d07f
Author: Vikas Soni <vikassoni@chromium.org>
Date: Fri Aug 31 02:22:21 2018

Disable AImageReader on ARM GPU devices.

Add gpu driver workaround to disable AImageReader on devices which have
ARM GPU.

Bug: 838725
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ia60d5ee9e16a4f309a99d04212af245411319040
Reviewed-on: https://chromium-review.googlesource.com/1194680
Commit-Queue: vikas soni <vikassoni@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Martin Barbella <mbarbella@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587919}
[modify] https://crrev.com/2364c68c3dca2b4fe489362c703355dfc210d07f/base/android/android_image_reader_compat.cc
[modify] https://crrev.com/2364c68c3dca2b4fe489362c703355dfc210d07f/base/android/android_image_reader_compat.h
[modify] https://crrev.com/2364c68c3dca2b4fe489362c703355dfc210d07f/gpu/config/gpu_driver_bug_list.json
[modify] https://crrev.com/2364c68c3dca2b4fe489362c703355dfc210d07f/gpu/config/gpu_workaround_list.txt
[modify] https://crrev.com/2364c68c3dca2b4fe489362c703355dfc210d07f/gpu/ipc/common/android/surface_owner_android.cc
[modify] https://crrev.com/2364c68c3dca2b4fe489362c703355dfc210d07f/gpu/ipc/service/gpu_init.cc
[modify] https://crrev.com/2364c68c3dca2b4fe489362c703355dfc210d07f/media/gpu/android/texture_owner.cc
Project Member

Comment 15 by bugdroid1@chromium.org, Sep 10

Labels: merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4324ae72c4357d08ff32178300a07f8a662ab17d

commit 4324ae72c4357d08ff32178300a07f8a662ab17d
Author: Vikas Soni <vikassoni@chromium.org>
Date: Mon Sep 10 19:30:51 2018

Merge to M70: Disable AImageReader on ARM GPU devices.

Add gpu driver workaround to disable AImageReader on devices which have
ARM GPU.

Bug: 838725
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ia60d5ee9e16a4f309a99d04212af245411319040
Reviewed-on: https://chromium-review.googlesource.com/1194680
Commit-Queue: vikas soni <vikassoni@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Martin Barbella <mbarbella@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#587919}(cherry picked from commit 2364c68c3dca2b4fe489362c703355dfc210d07f)
Reviewed-on: https://chromium-review.googlesource.com/1215466
Reviewed-by: Victor Miura <vmiura@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#239}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/4324ae72c4357d08ff32178300a07f8a662ab17d/base/android/android_image_reader_compat.cc
[modify] https://crrev.com/4324ae72c4357d08ff32178300a07f8a662ab17d/base/android/android_image_reader_compat.h
[modify] https://crrev.com/4324ae72c4357d08ff32178300a07f8a662ab17d/gpu/config/gpu_driver_bug_list.json
[modify] https://crrev.com/4324ae72c4357d08ff32178300a07f8a662ab17d/gpu/config/gpu_workaround_list.txt
[modify] https://crrev.com/4324ae72c4357d08ff32178300a07f8a662ab17d/gpu/ipc/common/android/surface_owner_android.cc
[modify] https://crrev.com/4324ae72c4357d08ff32178300a07f8a662ab17d/gpu/ipc/service/gpu_init.cc
[modify] https://crrev.com/4324ae72c4357d08ff32178300a07f8a662ab17d/media/gpu/android/texture_owner.cc
Project Member

Comment 16 by cr-audit...@appspot.gserviceaccount.com, Sep 10

Labels: CommitLog-Audit-Violation Merge-Without-Approval M-70
Here's a summary of the rules that were executed: 
 - OnlyMergeApprovedChange: Rule Failed -- Revision 4324ae72c4357d08ff32178300a07f8a662ab17d was merged to refs/branch-heads/3538 branch with no merge approval from a TPM! 
Please explain why this change was merged to the branch!
Project Member

Comment 17 by bugdroid1@chromium.org, Sep 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c0784dcdafc8853229be19aaf4f360cf7254d42

commit 6c0784dcdafc8853229be19aaf4f360cf7254d42
Author: Vikas Soni <vikassoni@chromium.org>
Date: Fri Sep 14 20:24:01 2018

Update fieldtrial config for AImageReaderVideoOutput.

Bug: 838725
Change-Id: I379b72f1c1c3e428e9892d94a6c554da74bbf5db
Reviewed-on: https://chromium-review.googlesource.com/1225971
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: vikas soni <vikassoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591453}
[modify] https://crrev.com/6c0784dcdafc8853229be19aaf4f360cf7254d42/testing/variations/fieldtrial_testing_config.json

Comment 18 by benmason@chromium.org, Sep 28

Labels: -CommitLog-Audit-Violation -Merge-Without-Approval
This was approved in 882031
Project Member

Comment 19 by bugdroid1@chromium.org, Oct 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02e8d48ee85acf06fb9c2c810fe1ed6083c3ebfd

commit 02e8d48ee85acf06fb9c2c810fe1ed6083c3ebfd
Author: Vikas Soni <vikassoni@chromium.org>
Date: Mon Oct 08 20:45:48 2018

Fieldtrial config for AImageReaderMediaPlayer.

Bug: 838725
Change-Id: I4b8b7f8ecd182deebfca170d54dacf45525504f8
Reviewed-on: https://chromium-review.googlesource.com/c/1268899
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597674}
[modify] https://crrev.com/02e8d48ee85acf06fb9c2c810fe1ed6083c3ebfd/testing/variations/fieldtrial_testing_config.json
Project Member

Comment 20 by bugdroid1@chromium.org, Oct 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/952ff9f989cc800514f558272c93f9b1da5b95fa

commit 952ff9f989cc800514f558272c93f9b1da5b95fa
Author: Vikas Soni <vikassoni@chromium.org>
Date: Fri Oct 26 06:38:44 2018

Fieldtrial config update for AImageReaderMediaPlayer.

Add a new experiment group which is used for finch on stable release.

Bug: 838725
Change-Id: Ib4e140270e4a1aa70cc676aaae3c8eea8ab8abfc
Reviewed-on: https://chromium-review.googlesource.com/c/1300533
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603008}
[modify] https://crrev.com/952ff9f989cc800514f558272c93f9b1da5b95fa/testing/variations/fieldtrial_testing_config.json
Project Member

Comment 21 by bugdroid1@chromium.org, Oct 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/554b17d548aa2f8b23d39a5e535a02ae41a81bc5

commit 554b17d548aa2f8b23d39a5e535a02ae41a81bc5
Author: Vikas Soni <vikassoni@chromium.org>
Date: Wed Oct 31 03:45:05 2018

Disable AImageReader on Imagination and NVIDIA GPU.

Disable AImageReader on Imagination and NVIDIA gpu as they are buggy.
Remove android version checks for disabling AImageReader as its not
required.

Bug: 838725
Change-Id: Ie05ecffbec4f758175a38bed81da98aed2aebeb3
Reviewed-on: https://chromium-review.googlesource.com/c/1308602
Reviewed-by: Frank Liberato <liberato@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: vikas soni <vikassoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604139}
[modify] https://crrev.com/554b17d548aa2f8b23d39a5e535a02ae41a81bc5/gpu/config/gpu_driver_bug_list.json

Comment 22 by dalecur...@chromium.org, Oct 31

Cc: kkinnu...@nvidia.com
+active nvidia folk for c#21.

Comment 23 by vikassoni@google.com, Nov 26

Labels: Merge-Request-71
Project Member

Comment 24 by sheriffbot@chromium.org, Nov 26

Labels: -Merge-Request-71 Hotlist-Merge-Review Merge-Review-71
This bug requires manual review: We are only 7 days from stable.
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 25 by benmason@chromium.org, Nov 27

Labels: -Hotlist-Merge-Review -Merge-Review-71 Merge-Approved-71
CL in c#21 approved for merge to 71, branch 3578.
Project Member

Comment 26 by bugdroid1@chromium.org, Nov 28

Labels: -merge-approved-71 merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9abadcd3cf91807a5f86a02ed9e0a62b665b3643

commit 9abadcd3cf91807a5f86a02ed9e0a62b665b3643
Author: Vikas Soni <vikassoni@chromium.org>
Date: Wed Nov 28 04:11:42 2018

Merge to M71: Disable AImageReader on Imagination and NVIDIA GPU.

Disable AImageReader on Imagination and NVIDIA gpu as they are buggy.
Remove android version checks for disabling AImageReader as its not
required.

TBR=vikassoni@chromium.org

(cherry picked from commit 554b17d548aa2f8b23d39a5e535a02ae41a81bc5)

Bug: 838725
Change-Id: Ie05ecffbec4f758175a38bed81da98aed2aebeb3
Reviewed-on: https://chromium-review.googlesource.com/c/1308602
Reviewed-by: Frank Liberato <liberato@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: vikas soni <vikassoni@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#604139}
Reviewed-on: https://chromium-review.googlesource.com/c/1352859
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#838}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/9abadcd3cf91807a5f86a02ed9e0a62b665b3643/gpu/config/gpu_driver_bug_list.json
Project Member

Comment 27 by cr-audit...@appspot.gserviceaccount.com, Nov 28

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/9abadcd3cf91807a5f86a02ed9e0a62b665b3643

Commit: 9abadcd3cf91807a5f86a02ed9e0a62b665b3643
Author: vikassoni@chromium.org
Commiter: ericrk@chromium.org
Date: 2018-11-28 04:11:42 +0000 UTC

Merge to M71: Disable AImageReader on Imagination and NVIDIA GPU.

Disable AImageReader on Imagination and NVIDIA gpu as they are buggy.
Remove android version checks for disabling AImageReader as its not
required.

TBR=vikassoni@chromium.org

(cherry picked from commit 554b17d548aa2f8b23d39a5e535a02ae41a81bc5)

Bug: 838725
Change-Id: Ie05ecffbec4f758175a38bed81da98aed2aebeb3
Reviewed-on: https://chromium-review.googlesource.com/c/1308602
Reviewed-by: Frank Liberato <liberato@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: vikas soni <vikassoni@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#604139}
Reviewed-on: https://chromium-review.googlesource.com/c/1352859
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#838}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

Comment 28 by kkinnu...@nvidia.com, Jan 2

Labels: GPU-NVidia
►

Sign in to add a comment