Support multiple type of power measurement board in ina_config file |
||
Issue descriptionIn INA Configuration Files, config_type can only be either ‘servod’ or ‘sweetberry’. This lead to the need of unnecessary hack to support both type with one config.[2] We should make |config_type| a list of supported type. [1] https://chromium.googlesource.com/chromiumos/third_party/hdctools/+/master/servo/data/README.INA.md#variables [2] https://crrev.com/c/1026644/3/servo/data/atlas_rev0.py
,
May 11 2018
I think this approach now at crrev.com/c/1051215 will solve the issue of having it spit out both .xml and .board .scenario files for use with sweetberry, but those .xml files are meaningless for use through normal servos, and only work by using sweetberry through servod. I think fundamentally you would want two configs (one for onboard usage and one for sweetberry usage) as it depends on which pins you route out the configuration for external measurements. There is no stable mapping between onboard slave-addr and sweetberry pin routing. Other solutions that rely either on ordering inside the the .py list are too unstable and easy to get wrong in my view.
,
May 11 2018
Marking as Won't Fix for now, unless we want to go down the route of using the convention inside powerlog.py that specifies a channel ordering and then have instructions on how things need to be reworked. |
||
►
Sign in to add a comment |
||
Comment 1 by puthik@chromium.org
, May 1 2018