The change was reverted in https://crrev.com/c/1038444, but a number of CQ jobs would've failed in the meantime. Because of the nature of the failure (an uncaught exception being raised from the test script), the retry-without-patch logic wouldn't have worked correctly, and so the CQ jobs would've been falsely rejected.

There are multiple issues that caused this.

First, the //build/fuchsia change didn't cause tests to be run, because the dependencies in the build files weren't correct (so analyze didn't trigger anything).

Second, //third_party/blink/tools/blinkpy/web_tests/port/fuchsia.py was adding the build/fuchsia path to PYTHONPATH incorrectly (putting it at the end of the path, not the beginning), leading to a potential for us to pick up the wrong module.

Third, the script isn't using vpython, and so we picked up the system PYTHONPATH and hence a wrong copy of common.py.

Fourth, when the exception *was* raised, we didn't clean up properly.

Fifth, the test step is still a ScriptTest, and not an IsolatedScriptTest :(.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c42a9c98fdde02c7f3d6265e1726141aeae548c2

commit c42a9c98fdde02c7f3d6265e1726141aeae548c2
Author: Dirk Pranke <dpranke@chromium.org>
Date: Wed May 02 00:14:56 2018

Clean up issues causing webkit_lint to fail on windows.

A fuchsia-specific change landed that caused webkit_lint to
fail on windows when it tried to instantiate a Fuchsia configuration.

This CL fixes a number of small issues that caused that failure,
so that things will work correctly in the same situation in the future.

R=jbudorick@chromium.org, kmarshall@chromium.org
BUG= 838703 

Change-Id: I796ff68b5138e4c31d56121e9a7fa751ade48543
Reviewed-on: https://chromium-review.googlesource.com/1038570
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555240}
[modify] https://crrev.com/c42a9c98fdde02c7f3d6265e1726141aeae548c2/testing/buildbot/trybot_analyze_config.json
[modify] https://crrev.com/c42a9c98fdde02c7f3d6265e1726141aeae548c2/third_party/blink/tools/blinkpy/web_tests/port/fuchsia.py