New issue
Advanced search Search tips

Issue 838701 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression

Blocking:
issue 829084



Sign in to add a comment

git cl presubmit can't run presubmit tests on tools/grit

Project Member Reported by hirosh...@chromium.org, May 1 2018

Issue description

What steps will reproduce the problem?
(1) Create a CL with modifications under tools/grit
(2) Run git cl presubmit

What is the expected result?

Presubmit tests run, i.e. the same thing should occur as:

$ cd tools/grit
$ python -m grit.test_suite_all

OR:

$ cd tools/grit/grit
$ python -m test_suite_all

What happens instead?

Presubmit tests fail, because failing in starting tests.

grit.test_suite_all (0.08s) failed
/path/to/python: No module named test_suite_all

This is because what is executed corresponds to the following:

$ cd tools/grit
$ python -m test_suite_all

This is an regression in depot_tools.
The first bad CL was:
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/973691

 
Blocking: 829084
Cc: aga...@chromium.org
Labels: -Type-Bug Type-Bug-Regression
Owner: ehmaldonado@chromium.org
ehmaldonado@, could you take a look?
This will block all CLs with modification under tools/grit.
Status: Fixed (was: Untriaged)
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1038665 has landed (thanks!). Closing as fixed.

Sign in to add a comment