New issue
Advanced search Search tips

Issue 838693 link

Starred by 5 users
Status: Available
Owner: ----
Cc:
danakj@chromium.org
pdr@chromium.org
piman@chromium.org
enne@chromium.org
chrishtr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove WebLayer* abstractions

Project Member Reported by danakj@chromium.org, May 1 2018 
They are pure overhead. Need to get rid of web types and use gfx/std types directly to interact with cc::Layers et al.
Project Member

Comment 1 by bugdroid1@chromium.org, May 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4894e1bc0aa984835571b6cbbb87570f98a2e457

commit 4894e1bc0aa984835571b6cbbb87570f98a2e457
Author: danakj <danakj@chromium.org>
Date: Wed May 02 16:35:56 2018

Replace SkMatrix44 with gfx::Transform in WebLayer APIs.

gfx::Transform is the ultimate type we want to use for cc, so avoid the
intermediate conversions thru WebLayer APIs.

R=jbroman@chromium.org, pdr@chromium.org

Bug: 838693, 738465
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I4774a4ccc8d5cab11712433a6f0933f1dd3719a9
Reviewed-on: https://chromium-review.googlesource.com/1038604
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555422}
[modify] https://crrev.com/4894e1bc0aa984835571b6cbbb87570f98a2e457/cc/blink/web_layer_impl.cc
[modify] https://crrev.com/4894e1bc0aa984835571b6cbbb87570f98a2e457/cc/blink/web_layer_impl.h
[modify] https://crrev.com/4894e1bc0aa984835571b6cbbb87570f98a2e457/cc/blink/web_layer_impl_fixed_bounds.cc
[modify] https://crrev.com/4894e1bc0aa984835571b6cbbb87570f98a2e457/cc/blink/web_layer_impl_fixed_bounds.h
[modify] https://crrev.com/4894e1bc0aa984835571b6cbbb87570f98a2e457/cc/blink/web_layer_impl_fixed_bounds_unittest.cc
[modify] https://crrev.com/4894e1bc0aa984835571b6cbbb87570f98a2e457/third_party/blink/public/platform/web_layer.h
[modify] https://crrev.com/4894e1bc0aa984835571b6cbbb87570f98a2e457/third_party/blink/renderer/core/paint/link_highlight_impl.cc
[modify] https://crrev.com/4894e1bc0aa984835571b6cbbb87570f98a2e457/third_party/blink/renderer/platform/graphics/graphics_layer.cc
[modify] https://crrev.com/4894e1bc0aa984835571b6cbbb87570f98a2e457/third_party/blink/renderer/platform/transforms/transformation_matrix.cc
[modify] https://crrev.com/4894e1bc0aa984835571b6cbbb87570f98a2e457/third_party/blink/renderer/platform/transforms/transformation_matrix.h
[modify] https://crrev.com/4894e1bc0aa984835571b6cbbb87570f98a2e457/third_party/blink/tools/audit_non_blink_usage.py
Project Member

Comment 2 by bugdroid1@chromium.org, May 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b68698e6c0c71af8f3b667ad547fc9d7ca2d1ef3

commit b68698e6c0c71af8f3b667ad547fc9d7ca2d1ef3
Author: danakj <danakj@chromium.org>
Date: Fri May 04 01:06:10 2018

Remove WebBlendMode from WebLayer API, use SkBlendMode directly.

Replaces the WebBlendMode enum with a BlendMode enum in graphics_types.h
under platform/graphics/ which is used throughout blink. This type is
kept because the bindings generator requires an enum with matching
names as the CSS property names (namely kNormal instead of kSrcOver).

Then we convert from BlendMode to SkBlendMode in GraphicsLayer in order
to pass it to the WebLayer.

TBR=fserb

Bug: 838693
Change-Id: If306343f4cd51911b46d6e1ca96529789477d29d
Reviewed-on: https://chromium-review.googlesource.com/1038403
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#555943}
[modify] https://crrev.com/b68698e6c0c71af8f3b667ad547fc9d7ca2d1ef3/build/check_gn_headers_whitelist.txt
[delete] https://crrev.com/f335db293a79678f3f1389e733313b6612b94678/cc/blink/web_blend_mode.h
[modify] https://crrev.com/b68698e6c0c71af8f3b667ad547fc9d7ca2d1ef3/cc/blink/web_layer_impl.cc
[modify] https://crrev.com/b68698e6c0c71af8f3b667ad547fc9d7ca2d1ef3/cc/blink/web_layer_impl.h
[modify] https://crrev.com/b68698e6c0c71af8f3b667ad547fc9d7ca2d1ef3/third_party/blink/public/BUILD.gn
[delete] https://crrev.com/f335db293a79678f3f1389e733313b6612b94678/third_party/blink/public/platform/web_blend_mode.h
[modify] https://crrev.com/b68698e6c0c71af8f3b667ad547fc9d7ca2d1ef3/third_party/blink/public/platform/web_display_item_list.h
[modify] https://crrev.com/b68698e6c0c71af8f3b667ad547fc9d7ca2d1ef3/third_party/blink/public/platform/web_layer.h
[modify] https://crrev.com/b68698e6c0c71af8f3b667ad547fc9d7ca2d1ef3/third_party/blink/renderer/build/scripts/core/css/properties/make_css_property_subclasses.py
[modify] https://crrev.com/b68698e6c0c71af8f3b667ad547fc9d7ca2d1ef3/third_party/blink/renderer/core/css/CSSProperties.json5
[modify] https://crrev.com/b68698e6c0c71af8f3b667ad547fc9d7ca2d1ef3/third_party/blink/renderer/core/css/css_primitive_value_mappings.h
[modify] https://crrev.com/b68698e6c0c71af8f3b667ad547fc9d7ca2d1ef3/third_party/blink/renderer/core/css/properties/longhands/background_blend_mode_custom.cc
[modify] https://crrev.com/b68698e6c0c71af8f3b667ad547fc9d7ca2d1ef3/third_party/blink/renderer/core/css/properties/longhands/mix_blend_mode_custom.cc
[modify] https://crrev.com/b68698e6c0c71af8f3b667ad547fc9d7ca2d1ef3/third_party/blink/renderer/core/css/resolver/css_to_style_map.cc
[modify] https://crrev.com/b68698e6c0c71af8f3b667ad547fc9d7ca2d1ef3/third_party/blink/renderer/core/layout/layout_box.cc
[modify] https://crrev.com/b68698e6c0c71af8f3b667ad547fc9d7ca2d1ef3/third_party/blink/renderer/core/layout/layout_tree_as_text.cc
[modify] https://crrev.com/b68698e6c0c71af8f3b667ad547fc9d7ca2d1ef3/third_party/blink/renderer/core/paint/box_painter_base.cc
[modify] https://crrev.com/b68698e6c0c71af8f3b667ad547fc9d7ca2d1ef3/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc
[modify] https://crrev.com/b68698e6c0c71af8f3b667ad547fc9d7ca2d1ef3/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.h
[modify] https://crrev.com/b68698e6c0c71af8f3b667ad547fc9d7ca2d1ef3/third_party/blink/renderer/core/paint/paint_layer_painter.cc
[modify] https://crrev.com/b68698e6c0c71af8f3b667ad547fc9d7ca2d1ef3/third_party/blink/renderer/core/paint/paint_property_tree_builder.cc
[modify] https://crrev.com/b68698e6c0c71af8f3b667ad547fc9d7ca2d1ef3/third_party/blink/renderer/core/paint/svg_paint_context.cc
[modify] https://crrev.com/b68698e6c0c71af8f3b667ad547fc9d7ca2d1ef3/third_party/blink/renderer/core/style/computed_style.h
[modify] https://crrev.com/b68698e6c0c71af8f3b667ad547fc9d7ca2d1ef3/third_party/blink/renderer/core/style/fill_layer.cc
[modify] https://crrev.com/b68698e6c0c71af8f3b667ad547fc9d7ca2d1ef3/third_party/blink/renderer/core/style/fill_layer.h
[modify] https://crrev.com/b68698e6c0c71af8f3b667ad547fc9d7ca2d1ef3/third_party/blink/renderer/core/svg/svg_fe_blend_element.cc
[modify] https://crrev.com/b68698e6c0c71af8f3b667ad547fc9d7ca2d1ef3/third_party/blink/renderer/modules/canvas/canvas2d/base_rendering_context_2d.cc
[modify] https://crrev.com/b68698e6c0c71af8f3b667ad547fc9d7ca2d1ef3/third_party/blink/renderer/platform/graphics/filters/fe_blend.cc
[modify] https://crrev.com/b68698e6c0c71af8f3b667ad547fc9d7ca2d1ef3/third_party/blink/renderer/platform/graphics/filters/fe_blend.h
[modify] https://crrev.com/b68698e6c0c71af8f3b667ad547fc9d7ca2d1ef3/third_party/blink/renderer/platform/graphics/filters/image_filter_builder_test.cc
[modify] https://crrev.com/b68698e6c0c71af8f3b667ad547fc9d7ca2d1ef3/third_party/blink/renderer/platform/graphics/graphics_layer.cc
[modify] https://crrev.com/b68698e6c0c71af8f3b667ad547fc9d7ca2d1ef3/third_party/blink/renderer/platform/graphics/graphics_layer.h
[modify] https://crrev.com/b68698e6c0c71af8f3b667ad547fc9d7ca2d1ef3/third_party/blink/renderer/platform/graphics/graphics_types.cc
[modify] https://crrev.com/b68698e6c0c71af8f3b667ad547fc9d7ca2d1ef3/third_party/blink/renderer/platform/graphics/graphics_types.h
[modify] https://crrev.com/b68698e6c0c71af8f3b667ad547fc9d7ca2d1ef3/third_party/blink/renderer/platform/graphics/paint/compositing_display_item.h
[modify] https://crrev.com/b68698e6c0c71af8f3b667ad547fc9d7ca2d1ef3/third_party/blink/renderer/platform/graphics/skia/skia_utils.cc
[modify] https://crrev.com/b68698e6c0c71af8f3b667ad547fc9d7ca2d1ef3/third_party/blink/renderer/platform/graphics/skia/skia_utils.h
Project Member

Comment 3 by bugdroid1@chromium.org, May 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5bdc6c17a22afeadfa840b77b7dd827c66a51608

commit 5bdc6c17a22afeadfa840b77b7dd827c66a51608
Author: danakj <danakj@chromium.org>
Date: Fri May 04 23:26:43 2018

Replace WebLayerScrollClient with a RepeatingCallback.

This eliminates the WebLayerScrollClient type, and makes the setter
method in WebLayerImpl a simple pass-through method, enabling removing
the WebLayer type.

R=bokan@chromium.org

Bug: 838693
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I94376a764783abad5ca86d25cefa80ee49cb5b25
Reviewed-on: https://chromium-review.googlesource.com/1044950
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556243}
[modify] https://crrev.com/5bdc6c17a22afeadfa840b77b7dd827c66a51608/cc/blink/web_layer_impl.cc
[modify] https://crrev.com/5bdc6c17a22afeadfa840b77b7dd827c66a51608/cc/blink/web_layer_impl.h
[modify] https://crrev.com/5bdc6c17a22afeadfa840b77b7dd827c66a51608/third_party/blink/public/platform/web_layer.h
[delete] https://crrev.com/3197693ba9fd40689c5a6b1efb3af0b8bf5390e6/third_party/blink/public/platform/web_layer_scroll_client.h
[modify] https://crrev.com/5bdc6c17a22afeadfa840b77b7dd827c66a51608/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/5bdc6c17a22afeadfa840b77b7dd827c66a51608/third_party/blink/renderer/core/page/scrolling/scrolling_coordinator.cc
[modify] https://crrev.com/5bdc6c17a22afeadfa840b77b7dd827c66a51608/third_party/blink/renderer/core/page/scrolling/scrolling_coordinator.h
[modify] https://crrev.com/5bdc6c17a22afeadfa840b77b7dd827c66a51608/third_party/blink/renderer/platform/graphics/compositing/paint_artifact_compositor.cc
[modify] https://crrev.com/5bdc6c17a22afeadfa840b77b7dd827c66a51608/third_party/blink/renderer/platform/graphics/compositing/paint_artifact_compositor.h
[modify] https://crrev.com/5bdc6c17a22afeadfa840b77b7dd827c66a51608/third_party/blink/renderer/platform/graphics/compositing/paint_artifact_compositor_test.cc
Project Member

Comment 4 by bugdroid1@chromium.org, May 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c46ccbb0f5ed29b1da5f6084cc8d98c93a9bf303

commit c46ccbb0f5ed29b1da5f6084cc8d98c93a9bf303
Author: danakj <danakj@chromium.org>
Date: Fri May 04 23:32:14 2018

Remove SetIsDrawable() from WebContentLayerImpl constructor.

Each caller of CreateContentLayer() calls SetDrawsContent() explicitly
already, which sets this same bool, so there is no need to call it in
the constructor or add any other calls.

R=pdr@chromium.org

Bug: 838693
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iec4c50d3334c733ac62f6756a3e40f392e1dd983
Reviewed-on: https://chromium-review.googlesource.com/1044897
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556249}
[modify] https://crrev.com/c46ccbb0f5ed29b1da5f6084cc8d98c93a9bf303/cc/blink/web_content_layer_impl.cc
Project Member

Comment 5 by bugdroid1@chromium.org, May 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1b6426ea838e2c0dc2d2b1893c5873cce1e53ac

commit e1b6426ea838e2c0dc2d2b1893c5873cce1e53ac
Author: danakj <danakj@chromium.org>
Date: Sat May 05 01:35:54 2018

Move SetContentsOpaqueIsFixed() from WebLayer to GraphicsLayer

Removes a piece of logic from WebLayer to help us no longer need the
class to exist. We plumb along with paths that set the WebLayer as
the contents layer on GraphicsLayer a bool that says if the creator
of the layer wants to manage the contents opaque-ness of the WebLayer
itself, or let the GraphicsLayer manage it.

R=enne@chromium.org

Bug: 838693
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ib0cf69441054dab8c031b4ac7f59d8306a0571c5
Reviewed-on: https://chromium-review.googlesource.com/1038565
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556288}
[modify] https://crrev.com/e1b6426ea838e2c0dc2d2b1893c5873cce1e53ac/cc/blink/web_layer_impl.cc
[modify] https://crrev.com/e1b6426ea838e2c0dc2d2b1893c5873cce1e53ac/cc/blink/web_layer_impl.h
[modify] https://crrev.com/e1b6426ea838e2c0dc2d2b1893c5873cce1e53ac/cc/layers/layer_unittest.cc
[modify] https://crrev.com/e1b6426ea838e2c0dc2d2b1893c5873cce1e53ac/content/renderer/browser_plugin/browser_plugin.cc
[modify] https://crrev.com/e1b6426ea838e2c0dc2d2b1893c5873cce1e53ac/content/renderer/browser_plugin/browser_plugin.h
[modify] https://crrev.com/e1b6426ea838e2c0dc2d2b1893c5873cce1e53ac/content/renderer/child_frame_compositing_helper.cc
[modify] https://crrev.com/e1b6426ea838e2c0dc2d2b1893c5873cce1e53ac/content/renderer/child_frame_compositing_helper_unittest.cc
[modify] https://crrev.com/e1b6426ea838e2c0dc2d2b1893c5873cce1e53ac/content/renderer/child_frame_compositor.h
[modify] https://crrev.com/e1b6426ea838e2c0dc2d2b1893c5873cce1e53ac/content/renderer/media/stream/webmediaplayer_ms.cc
[modify] https://crrev.com/e1b6426ea838e2c0dc2d2b1893c5873cce1e53ac/content/renderer/pepper/pepper_plugin_instance_impl.cc
[modify] https://crrev.com/e1b6426ea838e2c0dc2d2b1893c5873cce1e53ac/content/renderer/render_frame_proxy.cc
[modify] https://crrev.com/e1b6426ea838e2c0dc2d2b1893c5873cce1e53ac/content/renderer/render_frame_proxy.h
[modify] https://crrev.com/e1b6426ea838e2c0dc2d2b1893c5873cce1e53ac/content/shell/test_runner/test_plugin.cc
[modify] https://crrev.com/e1b6426ea838e2c0dc2d2b1893c5873cce1e53ac/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/e1b6426ea838e2c0dc2d2b1893c5873cce1e53ac/third_party/blink/public/platform/web_layer.h
[modify] https://crrev.com/e1b6426ea838e2c0dc2d2b1893c5873cce1e53ac/third_party/blink/public/web/web_plugin_container.h
[modify] https://crrev.com/e1b6426ea838e2c0dc2d2b1893c5873cce1e53ac/third_party/blink/public/web/web_remote_frame.h
[modify] https://crrev.com/e1b6426ea838e2c0dc2d2b1893c5873cce1e53ac/third_party/blink/renderer/core/exported/web_plugin_container_impl.cc
[modify] https://crrev.com/e1b6426ea838e2c0dc2d2b1893c5873cce1e53ac/third_party/blink/renderer/core/exported/web_plugin_container_impl.h
[modify] https://crrev.com/e1b6426ea838e2c0dc2d2b1893c5873cce1e53ac/third_party/blink/renderer/core/exported/web_plugin_container_test.cc
[modify] https://crrev.com/e1b6426ea838e2c0dc2d2b1893c5873cce1e53ac/third_party/blink/renderer/core/exported/web_remote_frame_impl.cc
[modify] https://crrev.com/e1b6426ea838e2c0dc2d2b1893c5873cce1e53ac/third_party/blink/renderer/core/exported/web_remote_frame_impl.h
[modify] https://crrev.com/e1b6426ea838e2c0dc2d2b1893c5873cce1e53ac/third_party/blink/renderer/core/frame/remote_frame.cc
[modify] https://crrev.com/e1b6426ea838e2c0dc2d2b1893c5873cce1e53ac/third_party/blink/renderer/core/frame/remote_frame.h
[modify] https://crrev.com/e1b6426ea838e2c0dc2d2b1893c5873cce1e53ac/third_party/blink/renderer/core/frame/visual_viewport.cc
[modify] https://crrev.com/e1b6426ea838e2c0dc2d2b1893c5873cce1e53ac/third_party/blink/renderer/core/page/scrolling/scrolling_coordinator.cc
[modify] https://crrev.com/e1b6426ea838e2c0dc2d2b1893c5873cce1e53ac/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc
[modify] https://crrev.com/e1b6426ea838e2c0dc2d2b1893c5873cce1e53ac/third_party/blink/renderer/platform/graphics/graphics_layer.cc
[modify] https://crrev.com/e1b6426ea838e2c0dc2d2b1893c5873cce1e53ac/third_party/blink/renderer/platform/graphics/graphics_layer.h
Project Member

Comment 6 by bugdroid1@chromium.org, May 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/985e7f8826cfddf36bfc52c70db638ba9322f4da

commit 985e7f8826cfddf36bfc52c70db638ba9322f4da
Author: danakj <danakj@chromium.org>
Date: Mon May 07 19:50:42 2018

Make WebLayerImpl nothing but a pass-through to cc::Layer.

Moves DCHECKs to cc, or removes duplicates, and clarifies things to be
obviously pass-through.

R=enne@chromium.org

Bug: 838693
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I10bc93b34967fca1dba66746d0e1ce1878904c70
Reviewed-on: https://chromium-review.googlesource.com/1047626
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556533}
[modify] https://crrev.com/985e7f8826cfddf36bfc52c70db638ba9322f4da/cc/blink/web_layer_impl.cc
[modify] https://crrev.com/985e7f8826cfddf36bfc52c70db638ba9322f4da/cc/layers/layer.cc
[modify] https://crrev.com/985e7f8826cfddf36bfc52c70db638ba9322f4da/cc/layers/layer_unittest.cc
[modify] https://crrev.com/985e7f8826cfddf36bfc52c70db638ba9322f4da/cc/trees/layer_tree_host_unittest_scroll.cc
Project Member

Comment 7 by bugdroid1@chromium.org, May 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ecdc5ebebb8e647fd637eb4fd31fe0161c843a14

commit ecdc5ebebb8e647fd637eb4fd31fe0161c843a14
Author: danakj <danakj@chromium.org>
Date: Mon May 07 22:46:10 2018

paint: Remove WebDisplayItemList

Move the code from WebDisplayItemListImpl up into each DisplayItem
subclass in blink. Make LinkHighlightImpl and GraphicsLayer into
cc::ContentLayerClients instead of WebContentLayerClients, and have
them construct/finalize/return a cc::DisplayItemList instead of a
WebDisplayItemList.

R=jbroman@chromium.org, pdr@chromium.org

Bug: 738465, 838693
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I56f20f93ac29125e23a15acccaa403f95f71061b
Reviewed-on: https://chromium-review.googlesource.com/1045229
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556590}
[modify] https://crrev.com/ecdc5ebebb8e647fd637eb4fd31fe0161c843a14/cc/blink/BUILD.gn
[modify] https://crrev.com/ecdc5ebebb8e647fd637eb4fd31fe0161c843a14/cc/blink/web_compositor_support_impl.cc
[modify] https://crrev.com/ecdc5ebebb8e647fd637eb4fd31fe0161c843a14/cc/blink/web_compositor_support_impl.h
[modify] https://crrev.com/ecdc5ebebb8e647fd637eb4fd31fe0161c843a14/cc/blink/web_content_layer_impl.cc
[modify] https://crrev.com/ecdc5ebebb8e647fd637eb4fd31fe0161c843a14/cc/blink/web_content_layer_impl.h
[delete] https://crrev.com/f2245f40303d0ffcfca81462e2305fbf341b4d56/cc/blink/web_display_item_list_impl.cc
[delete] https://crrev.com/f2245f40303d0ffcfca81462e2305fbf341b4d56/cc/blink/web_display_item_list_impl.h
[delete] https://crrev.com/f2245f40303d0ffcfca81462e2305fbf341b4d56/cc/blink/web_display_item_list_impl_unittest.cc
[modify] https://crrev.com/ecdc5ebebb8e647fd637eb4fd31fe0161c843a14/cc/layers/content_layer_client.h
[modify] https://crrev.com/ecdc5ebebb8e647fd637eb4fd31fe0161c843a14/third_party/blink/public/BUILD.gn
[modify] https://crrev.com/ecdc5ebebb8e647fd637eb4fd31fe0161c843a14/third_party/blink/public/platform/web_compositor_support.h
[delete] https://crrev.com/f2245f40303d0ffcfca81462e2305fbf341b4d56/third_party/blink/public/platform/web_content_layer_client.h
[delete] https://crrev.com/f2245f40303d0ffcfca81462e2305fbf341b4d56/third_party/blink/public/platform/web_display_item_list.h
[modify] https://crrev.com/ecdc5ebebb8e647fd637eb4fd31fe0161c843a14/third_party/blink/renderer/core/DEPS
[modify] https://crrev.com/ecdc5ebebb8e647fd637eb4fd31fe0161c843a14/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/ecdc5ebebb8e647fd637eb4fd31fe0161c843a14/third_party/blink/renderer/core/paint/link_highlight_impl.cc
[modify] https://crrev.com/ecdc5ebebb8e647fd637eb4fd31fe0161c843a14/third_party/blink/renderer/core/paint/link_highlight_impl.h
[modify] https://crrev.com/ecdc5ebebb8e647fd637eb4fd31fe0161c843a14/third_party/blink/renderer/core/scheduler/frame_throttling_test.cc
[modify] https://crrev.com/ecdc5ebebb8e647fd637eb4fd31fe0161c843a14/third_party/blink/renderer/platform/geometry/float_size.cc
[modify] https://crrev.com/ecdc5ebebb8e647fd637eb4fd31fe0161c843a14/third_party/blink/renderer/platform/geometry/float_size.h
[modify] https://crrev.com/ecdc5ebebb8e647fd637eb4fd31fe0161c843a14/third_party/blink/renderer/platform/graphics/graphics_layer.cc
[modify] https://crrev.com/ecdc5ebebb8e647fd637eb4fd31fe0161c843a14/third_party/blink/renderer/platform/graphics/graphics_layer.h
[modify] https://crrev.com/ecdc5ebebb8e647fd637eb4fd31fe0161c843a14/third_party/blink/renderer/platform/graphics/paint/clip_display_item.cc
[modify] https://crrev.com/ecdc5ebebb8e647fd637eb4fd31fe0161c843a14/third_party/blink/renderer/platform/graphics/paint/clip_display_item.h
[modify] https://crrev.com/ecdc5ebebb8e647fd637eb4fd31fe0161c843a14/third_party/blink/renderer/platform/graphics/paint/clip_path_display_item.cc
[modify] https://crrev.com/ecdc5ebebb8e647fd637eb4fd31fe0161c843a14/third_party/blink/renderer/platform/graphics/paint/clip_path_display_item.h
[modify] https://crrev.com/ecdc5ebebb8e647fd637eb4fd31fe0161c843a14/third_party/blink/renderer/platform/graphics/paint/compositing_display_item.cc
[modify] https://crrev.com/ecdc5ebebb8e647fd637eb4fd31fe0161c843a14/third_party/blink/renderer/platform/graphics/paint/compositing_display_item.h
[modify] https://crrev.com/ecdc5ebebb8e647fd637eb4fd31fe0161c843a14/third_party/blink/renderer/platform/graphics/paint/display_item.cc
[modify] https://crrev.com/ecdc5ebebb8e647fd637eb4fd31fe0161c843a14/third_party/blink/renderer/platform/graphics/paint/display_item.h
[modify] https://crrev.com/ecdc5ebebb8e647fd637eb4fd31fe0161c843a14/third_party/blink/renderer/platform/graphics/paint/drawing_display_item.cc
[modify] https://crrev.com/ecdc5ebebb8e647fd637eb4fd31fe0161c843a14/third_party/blink/renderer/platform/graphics/paint/drawing_display_item.h
[modify] https://crrev.com/ecdc5ebebb8e647fd637eb4fd31fe0161c843a14/third_party/blink/renderer/platform/graphics/paint/drawing_display_item_test.cc
[modify] https://crrev.com/ecdc5ebebb8e647fd637eb4fd31fe0161c843a14/third_party/blink/renderer/platform/graphics/paint/filter_display_item.cc
[modify] https://crrev.com/ecdc5ebebb8e647fd637eb4fd31fe0161c843a14/third_party/blink/renderer/platform/graphics/paint/filter_display_item.h
[modify] https://crrev.com/ecdc5ebebb8e647fd637eb4fd31fe0161c843a14/third_party/blink/renderer/platform/graphics/paint/float_clip_display_item.cc
[modify] https://crrev.com/ecdc5ebebb8e647fd637eb4fd31fe0161c843a14/third_party/blink/renderer/platform/graphics/paint/float_clip_display_item.h
[modify] https://crrev.com/ecdc5ebebb8e647fd637eb4fd31fe0161c843a14/third_party/blink/renderer/platform/graphics/paint/foreign_layer_display_item.cc
[modify] https://crrev.com/ecdc5ebebb8e647fd637eb4fd31fe0161c843a14/third_party/blink/renderer/platform/graphics/paint/foreign_layer_display_item.h
[modify] https://crrev.com/ecdc5ebebb8e647fd637eb4fd31fe0161c843a14/third_party/blink/renderer/platform/graphics/paint/paint_artifact.cc
[modify] https://crrev.com/ecdc5ebebb8e647fd637eb4fd31fe0161c843a14/third_party/blink/renderer/platform/graphics/paint/paint_artifact.h
[modify] https://crrev.com/ecdc5ebebb8e647fd637eb4fd31fe0161c843a14/third_party/blink/renderer/platform/graphics/paint/paint_chunker_test.cc
[modify] https://crrev.com/ecdc5ebebb8e647fd637eb4fd31fe0161c843a14/third_party/blink/renderer/platform/graphics/paint/paint_controller_test.h
[modify] https://crrev.com/ecdc5ebebb8e647fd637eb4fd31fe0161c843a14/third_party/blink/renderer/platform/graphics/paint/scroll_display_item.cc
[modify] https://crrev.com/ecdc5ebebb8e647fd637eb4fd31fe0161c843a14/third_party/blink/renderer/platform/graphics/paint/scroll_display_item.h
[modify] https://crrev.com/ecdc5ebebb8e647fd637eb4fd31fe0161c843a14/third_party/blink/renderer/platform/graphics/paint/scroll_hit_test_display_item.cc
[modify] https://crrev.com/ecdc5ebebb8e647fd637eb4fd31fe0161c843a14/third_party/blink/renderer/platform/graphics/paint/scroll_hit_test_display_item.h
[modify] https://crrev.com/ecdc5ebebb8e647fd637eb4fd31fe0161c843a14/third_party/blink/renderer/platform/graphics/paint/transform_3d_display_item.cc
[modify] https://crrev.com/ecdc5ebebb8e647fd637eb4fd31fe0161c843a14/third_party/blink/renderer/platform/graphics/paint/transform_3d_display_item.h
[modify] https://crrev.com/ecdc5ebebb8e647fd637eb4fd31fe0161c843a14/third_party/blink/renderer/platform/graphics/paint/transform_display_item.cc
[modify] https://crrev.com/ecdc5ebebb8e647fd637eb4fd31fe0161c843a14/third_party/blink/renderer/platform/graphics/paint/transform_display_item.h
[modify] https://crrev.com/ecdc5ebebb8e647fd637eb4fd31fe0161c843a14/third_party/blink/renderer/platform/testing/testing_platform_support.cc
[modify] https://crrev.com/ecdc5ebebb8e647fd637eb4fd31fe0161c843a14/third_party/blink/renderer/platform/testing/testing_platform_support.h
[modify] https://crrev.com/ecdc5ebebb8e647fd637eb4fd31fe0161c843a14/third_party/blink/tools/audit_non_blink_usage.py
Project Member

Comment 8 by bugdroid1@chromium.org, May 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd76d2ec7ac8bf8fe2186c1ab8da922c58c01ad8

commit bd76d2ec7ac8bf8fe2186c1ab8da922c58c01ad8
Author: danakj <danakj@chromium.org>
Date: Tue May 08 18:04:59 2018

cc_blink: Remove WebExternalTextureLayer.

Replace with a paired cc::TextureLayer directly in blink, and a WebLayer
to wrap it and be returned as the PlatformLayer.

R=pdr@chromium.org

Bug: 838693
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ie44ed6254c35b281e5c0f75733779a3c9ff81e7b
Reviewed-on: https://chromium-review.googlesource.com/1047968
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556871}
[modify] https://crrev.com/bd76d2ec7ac8bf8fe2186c1ab8da922c58c01ad8/cc/blink/BUILD.gn
[modify] https://crrev.com/bd76d2ec7ac8bf8fe2186c1ab8da922c58c01ad8/cc/blink/web_compositor_support_impl.cc
[modify] https://crrev.com/bd76d2ec7ac8bf8fe2186c1ab8da922c58c01ad8/cc/blink/web_compositor_support_impl.h
[delete] https://crrev.com/3482929a8eaee2ea2e14773955617900f0da07bc/cc/blink/web_external_texture_layer_impl.cc
[delete] https://crrev.com/3482929a8eaee2ea2e14773955617900f0da07bc/cc/blink/web_external_texture_layer_impl.h
[modify] https://crrev.com/bd76d2ec7ac8bf8fe2186c1ab8da922c58c01ad8/third_party/blink/public/platform/web_compositor_support.h
[modify] https://crrev.com/bd76d2ec7ac8bf8fe2186c1ab8da922c58c01ad8/third_party/blink/public/platform/web_external_texture_layer.h
[modify] https://crrev.com/bd76d2ec7ac8bf8fe2186c1ab8da922c58c01ad8/third_party/blink/renderer/modules/canvas/imagebitmap/image_bitmap_rendering_context_base.cc
[modify] https://crrev.com/bd76d2ec7ac8bf8fe2186c1ab8da922c58c01ad8/third_party/blink/renderer/modules/canvas/imagebitmap/image_bitmap_rendering_context_base.h
[modify] https://crrev.com/bd76d2ec7ac8bf8fe2186c1ab8da922c58c01ad8/third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge.cc
[modify] https://crrev.com/bd76d2ec7ac8bf8fe2186c1ab8da922c58c01ad8/third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge.h
[modify] https://crrev.com/bd76d2ec7ac8bf8fe2186c1ab8da922c58c01ad8/third_party/blink/renderer/platform/graphics/gpu/drawing_buffer.cc
[modify] https://crrev.com/bd76d2ec7ac8bf8fe2186c1ab8da922c58c01ad8/third_party/blink/renderer/platform/graphics/gpu/drawing_buffer.h
[modify] https://crrev.com/bd76d2ec7ac8bf8fe2186c1ab8da922c58c01ad8/third_party/blink/renderer/platform/graphics/gpu/image_layer_bridge.cc
[modify] https://crrev.com/bd76d2ec7ac8bf8fe2186c1ab8da922c58c01ad8/third_party/blink/renderer/platform/graphics/gpu/image_layer_bridge.h
[modify] https://crrev.com/bd76d2ec7ac8bf8fe2186c1ab8da922c58c01ad8/third_party/blink/renderer/platform/testing/testing_platform_support.cc
[modify] https://crrev.com/bd76d2ec7ac8bf8fe2186c1ab8da922c58c01ad8/third_party/blink/renderer/platform/testing/testing_platform_support.h
Project Member

Comment 9 by bugdroid1@chromium.org, May 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ae40881410d8257fe71ec4fc7506097d096fea5

commit 3ae40881410d8257fe71ec4fc7506097d096fea5
Author: danakj <danakj@chromium.org>
Date: Wed May 09 16:01:51 2018

blink: Remove the WebScrollbarLayer class.

This removes the class, replacing it with uses of the cc scrollbar layer
types: cc::PaintedScrollbarLayer, cc::PaintedOverlayScrollbarLayer, and
cc::SolidColorScrollbarLayer directly. The scrollbar layer map needs to
maintain ownership of these along with a wrapping WebLayer (for now),
and a raw pointer to a base cc::ScrollbarLayerInterface* for changing
the element id that the scrollbar controls the view of. So we add a
ScrollingCoordinator::ScrollbarLayerGroup that holds these three things
together.

The cc_blink::ScrollbarImpl, which is a subclass of cc::Scrollbar, moves
from cc/blink/ to platform/scroll/ beside the ScrollingCoordinator, and
is renamed to ScrollbarLayerDelegate. It still makes use of Web* types
like WebScrollbarThemePainter and these can be removed to use the
platform/scroll/ types directly instead.

R=bokan@chromium.org, jbroman@chromium.org

Bug: 838693, 738465
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I021fc69a2c8fd90a21bf406cd08d968e0335506a
Reviewed-on: https://chromium-review.googlesource.com/1048247
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557203}
[modify] https://crrev.com/3ae40881410d8257fe71ec4fc7506097d096fea5/cc/blink/BUILD.gn
[delete] https://crrev.com/191635e56f362891dd7ee750598679e3eb27cab6/cc/blink/scrollbar_impl.cc
[delete] https://crrev.com/191635e56f362891dd7ee750598679e3eb27cab6/cc/blink/scrollbar_impl.h
[modify] https://crrev.com/3ae40881410d8257fe71ec4fc7506097d096fea5/cc/blink/web_compositor_support_impl.cc
[modify] https://crrev.com/3ae40881410d8257fe71ec4fc7506097d096fea5/cc/blink/web_compositor_support_impl.h
[delete] https://crrev.com/191635e56f362891dd7ee750598679e3eb27cab6/cc/blink/web_scrollbar_layer_impl.cc
[delete] https://crrev.com/191635e56f362891dd7ee750598679e3eb27cab6/cc/blink/web_scrollbar_layer_impl.h
[modify] https://crrev.com/3ae40881410d8257fe71ec4fc7506097d096fea5/third_party/blink/public/BUILD.gn
[modify] https://crrev.com/3ae40881410d8257fe71ec4fc7506097d096fea5/third_party/blink/public/platform/web_compositor_support.h
[modify] https://crrev.com/3ae40881410d8257fe71ec4fc7506097d096fea5/third_party/blink/public/platform/web_point.h
[modify] https://crrev.com/3ae40881410d8257fe71ec4fc7506097d096fea5/third_party/blink/public/platform/web_rect.h
[delete] https://crrev.com/191635e56f362891dd7ee750598679e3eb27cab6/third_party/blink/public/platform/web_scrollbar_layer.h
[modify] https://crrev.com/3ae40881410d8257fe71ec4fc7506097d096fea5/third_party/blink/public/platform/web_size.h
[modify] https://crrev.com/3ae40881410d8257fe71ec4fc7506097d096fea5/third_party/blink/renderer/core/DEPS
[modify] https://crrev.com/3ae40881410d8257fe71ec4fc7506097d096fea5/third_party/blink/renderer/core/frame/visual_viewport.cc
[modify] https://crrev.com/3ae40881410d8257fe71ec4fc7506097d096fea5/third_party/blink/renderer/core/frame/visual_viewport.h
[add] https://crrev.com/3ae40881410d8257fe71ec4fc7506097d096fea5/third_party/blink/renderer/core/page/scrolling/DEPS
[modify] https://crrev.com/3ae40881410d8257fe71ec4fc7506097d096fea5/third_party/blink/renderer/core/page/scrolling/scrolling_coordinator.cc
[modify] https://crrev.com/3ae40881410d8257fe71ec4fc7506097d096fea5/third_party/blink/renderer/core/page/scrolling/scrolling_coordinator.h
[modify] https://crrev.com/3ae40881410d8257fe71ec4fc7506097d096fea5/third_party/blink/renderer/core/page/scrolling/scrolling_coordinator_test.cc
[modify] https://crrev.com/3ae40881410d8257fe71ec4fc7506097d096fea5/third_party/blink/renderer/platform/BUILD.gn
[add] https://crrev.com/3ae40881410d8257fe71ec4fc7506097d096fea5/third_party/blink/renderer/platform/scroll/scrollbar_layer_delegate.cc
[add] https://crrev.com/3ae40881410d8257fe71ec4fc7506097d096fea5/third_party/blink/renderer/platform/scroll/scrollbar_layer_delegate.h
[modify] https://crrev.com/3ae40881410d8257fe71ec4fc7506097d096fea5/third_party/blink/renderer/platform/testing/testing_platform_support.cc
[modify] https://crrev.com/3ae40881410d8257fe71ec4fc7506097d096fea5/third_party/blink/renderer/platform/testing/testing_platform_support.h
[modify] https://crrev.com/3ae40881410d8257fe71ec4fc7506097d096fea5/third_party/blink/tools/audit_non_blink_usage.py
Project Member

Comment 10 by bugdroid1@chromium.org, May 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03814999f111196963de1dee0d4820e16bb8227e

commit 03814999f111196963de1dee0d4820e16bb8227e
Author: danakj <danakj@chromium.org>
Date: Wed May 09 17:33:06 2018

blink: Remove WebContentLayer.

Own a cc::PictureLayer directly in GraphicsLayer and LinkHighlightImpl
and expose it instead of WebContentLayer*. Wrap it in a WebLayer for
interactions that require one of those for now.

R=chrishtr@chromium.org, jbroman@chromium.org

Bug: 838693
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I5486b58337987dbfa13e2048dcdf10ae059beea5
Reviewed-on: https://chromium-review.googlesource.com/1048545
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557231}
[modify] https://crrev.com/03814999f111196963de1dee0d4820e16bb8227e/cc/blink/BUILD.gn
[modify] https://crrev.com/03814999f111196963de1dee0d4820e16bb8227e/cc/blink/web_compositor_support_impl.cc
[modify] https://crrev.com/03814999f111196963de1dee0d4820e16bb8227e/cc/blink/web_compositor_support_impl.h
[delete] https://crrev.com/b94880fa4fecc6ecd141e9fc7b210da4a67de1b1/cc/blink/web_content_layer_impl.cc
[delete] https://crrev.com/b94880fa4fecc6ecd141e9fc7b210da4a67de1b1/cc/blink/web_content_layer_impl.h
[modify] https://crrev.com/03814999f111196963de1dee0d4820e16bb8227e/third_party/blink/public/BUILD.gn
[modify] https://crrev.com/03814999f111196963de1dee0d4820e16bb8227e/third_party/blink/public/platform/web_compositor_support.h
[delete] https://crrev.com/b94880fa4fecc6ecd141e9fc7b210da4a67de1b1/third_party/blink/public/platform/web_content_layer.h
[add] https://crrev.com/03814999f111196963de1dee0d4820e16bb8227e/third_party/blink/renderer/core/paint/DEPS
[modify] https://crrev.com/03814999f111196963de1dee0d4820e16bb8227e/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc
[modify] https://crrev.com/03814999f111196963de1dee0d4820e16bb8227e/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping_test.cc
[modify] https://crrev.com/03814999f111196963de1dee0d4820e16bb8227e/third_party/blink/renderer/core/paint/link_highlight_impl.cc
[modify] https://crrev.com/03814999f111196963de1dee0d4820e16bb8227e/third_party/blink/renderer/core/paint/link_highlight_impl.h
[modify] https://crrev.com/03814999f111196963de1dee0d4820e16bb8227e/third_party/blink/renderer/core/paint/link_highlight_impl_test.cc
[modify] https://crrev.com/03814999f111196963de1dee0d4820e16bb8227e/third_party/blink/renderer/platform/graphics/graphics_layer.cc
[modify] https://crrev.com/03814999f111196963de1dee0d4820e16bb8227e/third_party/blink/renderer/platform/graphics/graphics_layer.h
[modify] https://crrev.com/03814999f111196963de1dee0d4820e16bb8227e/third_party/blink/renderer/platform/testing/testing_platform_support.cc
[modify] https://crrev.com/03814999f111196963de1dee0d4820e16bb8227e/third_party/blink/renderer/platform/testing/testing_platform_support.h
[modify] https://crrev.com/03814999f111196963de1dee0d4820e16bb8227e/third_party/blink/tools/audit_non_blink_usage.py
Project Member

Comment 11 by bugdroid1@chromium.org, May 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/312145d8fb294946bb6ce6a727c689458e9d011c

commit 312145d8fb294946bb6ce6a727c689458e9d011c
Author: danakj <danakj@chromium.org>
Date: Wed May 09 17:41:16 2018

Remove WebCompositorSupport::CreateLayer.

Create a cc::Layer directly in LinkHighlightImpl instead, and wrap it
in a WebLayer.

R=pdr@chromium.org

Bug: 838693
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I74d40aab18600f9970e1a9e356d93fde2e793b6a
Reviewed-on: https://chromium-review.googlesource.com/1047950
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557236}
[modify] https://crrev.com/312145d8fb294946bb6ce6a727c689458e9d011c/cc/blink/web_compositor_support_impl.cc
[modify] https://crrev.com/312145d8fb294946bb6ce6a727c689458e9d011c/cc/blink/web_compositor_support_impl.h
[modify] https://crrev.com/312145d8fb294946bb6ce6a727c689458e9d011c/third_party/blink/public/platform/web_compositor_support.h
[modify] https://crrev.com/312145d8fb294946bb6ce6a727c689458e9d011c/third_party/blink/renderer/core/exported/web_plugin_container_test.cc
[modify] https://crrev.com/312145d8fb294946bb6ce6a727c689458e9d011c/third_party/blink/renderer/core/paint/link_highlight_impl.cc
[modify] https://crrev.com/312145d8fb294946bb6ce6a727c689458e9d011c/third_party/blink/renderer/core/paint/link_highlight_impl.h
[modify] https://crrev.com/312145d8fb294946bb6ce6a727c689458e9d011c/third_party/blink/renderer/core/paint/video_painter_test.cc
[modify] https://crrev.com/312145d8fb294946bb6ce6a727c689458e9d011c/third_party/blink/renderer/platform/testing/testing_platform_support.cc
[modify] https://crrev.com/312145d8fb294946bb6ce6a727c689458e9d011c/third_party/blink/renderer/platform/testing/testing_platform_support.h
Project Member

Comment 12 by bugdroid1@chromium.org, May 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c654ee39b1ec41d9199a49919c8206f9261bb027

commit c654ee39b1ec41d9199a49919c8206f9261bb027
Author: danakj <danakj@chromium.org>
Date: Fri May 11 18:23:05 2018

cc_blink: Remove WebImageLayer and WebLayerImplFixedBounds

Move the functionality of WebLayerImplFixedBounds directly to
GraphicsLayer. When SetContentsToImage() is called, it stores
the size of the image. Then when UpdateContentRect() occurs,
the image_layer_ (which is the contents layer) is resized
always to match the image, and transformed to fill the
content_rect.

The PaintArtifactCompositor was mutating the contents layer
bounds which would break this path, but it didn't intend
to do so for layers it doesn't control. So we move bounds
setting out of PaintArtifactCompositor for foreign layers,
and set the bounds and DrawsContent(true) at the sites where
the ForeignLayerDisplayItem is created when appropriate (ie
for each case except for GraphicsLayer::ContentsLayer()).

With the removal of WebLayerImplFixedBounds there are no
tests left in cc_blink_unittests, so we remove the test
suite.

R=trchen@chromium.org

Bug: 838693
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I2fee4f382eb450af4646a087a08806798a975dd7
Reviewed-on: https://chromium-review.googlesource.com/1053765
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557946}
[modify] https://crrev.com/c654ee39b1ec41d9199a49919c8206f9261bb027/BUILD.gn
[modify] https://crrev.com/c654ee39b1ec41d9199a49919c8206f9261bb027/cc/blink/BUILD.gn
[delete] https://crrev.com/70f5eed34d513d3c8d35cf5bb6d4a59b46511159/cc/blink/test/cc_blink_test_suite.cc
[delete] https://crrev.com/70f5eed34d513d3c8d35cf5bb6d4a59b46511159/cc/blink/test/cc_blink_test_suite.h
[delete] https://crrev.com/70f5eed34d513d3c8d35cf5bb6d4a59b46511159/cc/blink/test/run_all_unittests.cc
[modify] https://crrev.com/c654ee39b1ec41d9199a49919c8206f9261bb027/cc/blink/web_compositor_support_impl.cc
[modify] https://crrev.com/c654ee39b1ec41d9199a49919c8206f9261bb027/cc/blink/web_compositor_support_impl.h
[delete] https://crrev.com/70f5eed34d513d3c8d35cf5bb6d4a59b46511159/cc/blink/web_image_layer_impl.cc
[delete] https://crrev.com/70f5eed34d513d3c8d35cf5bb6d4a59b46511159/cc/blink/web_image_layer_impl.h
[delete] https://crrev.com/70f5eed34d513d3c8d35cf5bb6d4a59b46511159/cc/blink/web_layer_impl_fixed_bounds.cc
[delete] https://crrev.com/70f5eed34d513d3c8d35cf5bb6d4a59b46511159/cc/blink/web_layer_impl_fixed_bounds.h
[delete] https://crrev.com/70f5eed34d513d3c8d35cf5bb6d4a59b46511159/cc/blink/web_layer_impl_fixed_bounds_unittest.cc
[modify] https://crrev.com/c654ee39b1ec41d9199a49919c8206f9261bb027/content/renderer/browser_plugin/browser_plugin.cc
[modify] https://crrev.com/c654ee39b1ec41d9199a49919c8206f9261bb027/content/renderer/gpu/render_widget_compositor.cc
[modify] https://crrev.com/c654ee39b1ec41d9199a49919c8206f9261bb027/content/renderer/gpu/render_widget_compositor.h
[modify] https://crrev.com/c654ee39b1ec41d9199a49919c8206f9261bb027/content/renderer/render_frame_proxy.cc
[modify] https://crrev.com/c654ee39b1ec41d9199a49919c8206f9261bb027/third_party/blink/public/platform/web_compositor_support.h
[modify] https://crrev.com/c654ee39b1ec41d9199a49919c8206f9261bb027/third_party/blink/public/platform/web_layer_tree_view.h
[modify] https://crrev.com/c654ee39b1ec41d9199a49919c8206f9261bb027/third_party/blink/renderer/core/exported/web_plugin_container_impl.cc
[modify] https://crrev.com/c654ee39b1ec41d9199a49919c8206f9261bb027/third_party/blink/renderer/core/exported/web_selection.cc
[modify] https://crrev.com/c654ee39b1ec41d9199a49919c8206f9261bb027/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/c654ee39b1ec41d9199a49919c8206f9261bb027/third_party/blink/renderer/core/frame/pausable_script_executor.cc
[modify] https://crrev.com/c654ee39b1ec41d9199a49919c8206f9261bb027/third_party/blink/renderer/core/html/media/html_media_element.cc
[modify] https://crrev.com/c654ee39b1ec41d9199a49919c8206f9261bb027/third_party/blink/renderer/core/page/page.cc
[modify] https://crrev.com/c654ee39b1ec41d9199a49919c8206f9261bb027/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping_test.cc
[modify] https://crrev.com/c654ee39b1ec41d9199a49919c8206f9261bb027/third_party/blink/renderer/core/paint/compositing/paint_layer_compositor.cc
[modify] https://crrev.com/c654ee39b1ec41d9199a49919c8206f9261bb027/third_party/blink/renderer/core/paint/html_canvas_painter.cc
[modify] https://crrev.com/c654ee39b1ec41d9199a49919c8206f9261bb027/third_party/blink/renderer/core/paint/video_painter.cc
[modify] https://crrev.com/c654ee39b1ec41d9199a49919c8206f9261bb027/third_party/blink/renderer/core/paint/video_painter_test.cc
[modify] https://crrev.com/c654ee39b1ec41d9199a49919c8206f9261bb027/third_party/blink/renderer/modules/background_fetch/background_fetched_event.h
[modify] https://crrev.com/c654ee39b1ec41d9199a49919c8206f9261bb027/third_party/blink/renderer/platform/graphics/compositing/paint_artifact_compositor.cc
[modify] https://crrev.com/c654ee39b1ec41d9199a49919c8206f9261bb027/third_party/blink/renderer/platform/graphics/compositing/paint_artifact_compositor_test.cc
[modify] https://crrev.com/c654ee39b1ec41d9199a49919c8206f9261bb027/third_party/blink/renderer/platform/graphics/graphics_layer.cc
[modify] https://crrev.com/c654ee39b1ec41d9199a49919c8206f9261bb027/third_party/blink/renderer/platform/graphics/graphics_layer.h
[modify] https://crrev.com/c654ee39b1ec41d9199a49919c8206f9261bb027/third_party/blink/renderer/platform/graphics/image_layer_chromium_test.cc
[modify] https://crrev.com/c654ee39b1ec41d9199a49919c8206f9261bb027/third_party/blink/renderer/platform/scroll/scroll_animator.cc
[modify] https://crrev.com/c654ee39b1ec41d9199a49919c8206f9261bb027/third_party/blink/renderer/platform/scroll/scroll_animator_compositor_coordinator.cc
[modify] https://crrev.com/c654ee39b1ec41d9199a49919c8206f9261bb027/third_party/blink/renderer/platform/scroll/scrollable_area.cc
[modify] https://crrev.com/c654ee39b1ec41d9199a49919c8206f9261bb027/third_party/blink/renderer/platform/testing/testing_platform_support.cc
[modify] https://crrev.com/c654ee39b1ec41d9199a49919c8206f9261bb027/third_party/blink/renderer/platform/testing/testing_platform_support.h
[modify] https://crrev.com/c654ee39b1ec41d9199a49919c8206f9261bb027/tools/determinism/deterministic_build_whitelist.pyl
Project Member

Comment 13 by bugdroid1@chromium.org, May 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25f0301152f0fd71a7503ae2c4f0d48a8a2af9e1

commit 25f0301152f0fd71a7503ae2c4f0d48a8a2af9e1
Author: danakj <danakj@chromium.org>
Date: Fri May 11 18:26:54 2018

cc_blink: Remove ownership of cc::Layer from WebLayer.

This is a precursor to deleting WebLayer. It makes WebLayer hold a raw
cc::Layer* pointer, forcing each owner of a WebLayer to also own a
scoped_refptr<cc::Layer>. Then we can remove the unique_ptr<WebLayer>s
in the future.

R=pdr@chromium.org

Bug: 838693
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: If0f3f68a4fb741acea33b81a1b468a6a3d0a93ad
Reviewed-on: https://chromium-review.googlesource.com/1054589
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557948}
[modify] https://crrev.com/25f0301152f0fd71a7503ae2c4f0d48a8a2af9e1/cc/blink/web_layer_impl.cc
[modify] https://crrev.com/25f0301152f0fd71a7503ae2c4f0d48a8a2af9e1/cc/blink/web_layer_impl.h
[modify] https://crrev.com/25f0301152f0fd71a7503ae2c4f0d48a8a2af9e1/content/renderer/browser_plugin/browser_plugin.cc
[modify] https://crrev.com/25f0301152f0fd71a7503ae2c4f0d48a8a2af9e1/content/renderer/browser_plugin/browser_plugin.h
[modify] https://crrev.com/25f0301152f0fd71a7503ae2c4f0d48a8a2af9e1/content/renderer/child_frame_compositing_helper.cc
[modify] https://crrev.com/25f0301152f0fd71a7503ae2c4f0d48a8a2af9e1/content/renderer/child_frame_compositing_helper_unittest.cc
[modify] https://crrev.com/25f0301152f0fd71a7503ae2c4f0d48a8a2af9e1/content/renderer/child_frame_compositor.h
[modify] https://crrev.com/25f0301152f0fd71a7503ae2c4f0d48a8a2af9e1/content/renderer/media/stream/webmediaplayer_ms.cc
[modify] https://crrev.com/25f0301152f0fd71a7503ae2c4f0d48a8a2af9e1/content/renderer/media/stream/webmediaplayer_ms.h
[modify] https://crrev.com/25f0301152f0fd71a7503ae2c4f0d48a8a2af9e1/content/renderer/pepper/pepper_plugin_instance_impl.cc
[modify] https://crrev.com/25f0301152f0fd71a7503ae2c4f0d48a8a2af9e1/content/renderer/render_frame_proxy.cc
[modify] https://crrev.com/25f0301152f0fd71a7503ae2c4f0d48a8a2af9e1/content/renderer/render_frame_proxy.h
[modify] https://crrev.com/25f0301152f0fd71a7503ae2c4f0d48a8a2af9e1/content/shell/test_runner/test_plugin.cc
[modify] https://crrev.com/25f0301152f0fd71a7503ae2c4f0d48a8a2af9e1/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/25f0301152f0fd71a7503ae2c4f0d48a8a2af9e1/media/blink/webmediaplayer_impl.h
[modify] https://crrev.com/25f0301152f0fd71a7503ae2c4f0d48a8a2af9e1/media/blink/webmediaplayer_impl_unittest.cc
Project Member

Comment 14 by bugdroid1@chromium.org, May 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0310db73b412532cf4ccb495636a51c412e7aad

commit e0310db73b412532cf4ccb495636a51c412e7aad
Author: danakj <danakj@chromium.org>
Date: Fri May 11 23:07:02 2018

Remove cc/blink and WebCompositorSupport, make WebLayer concrete.

This removes the WebLayerImpl subclass, pushing all the implementation
into the base WebLayer class. Then blink can instantiate it directly
since it lives in blink/public/platform/ so we don't need to go through
WebCompositorSupport anymore. Thus we remove that as well, leaving
cc/blink empty and we can remove the directory and all reference to it
in DEPS and BUILD files.

This makes it easier to reshape WebLayer to be the same as cc::Layer
so that we may type-alias it along the path to removing WebLayer.

R=chrishtr@chromium.org
TBR=jam

Bug: 838693
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I77744e2672f239d3d2c14a274e2de4cb658b8f48
Reviewed-on: https://chromium-review.googlesource.com/1055804
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558052}
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/android_webview/browser/DEPS
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/cc/DEPS
[delete] https://crrev.com/7ca528c1d64bb421c29b57ed1a0a019bcc84b698/cc/blink/BUILD.gn
[delete] https://crrev.com/7ca528c1d64bb421c29b57ed1a0a019bcc84b698/cc/blink/DEPS
[delete] https://crrev.com/7ca528c1d64bb421c29b57ed1a0a019bcc84b698/cc/blink/OWNERS
[delete] https://crrev.com/7ca528c1d64bb421c29b57ed1a0a019bcc84b698/cc/blink/cc_blink_export.h
[delete] https://crrev.com/7ca528c1d64bb421c29b57ed1a0a019bcc84b698/cc/blink/web_compositor_support_impl.cc
[delete] https://crrev.com/7ca528c1d64bb421c29b57ed1a0a019bcc84b698/cc/blink/web_compositor_support_impl.h
[delete] https://crrev.com/7ca528c1d64bb421c29b57ed1a0a019bcc84b698/cc/blink/web_layer_impl.cc
[delete] https://crrev.com/7ca528c1d64bb421c29b57ed1a0a019bcc84b698/cc/blink/web_layer_impl.h
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/components/viz/client/DEPS
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/content/DEPS
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/content/renderer/BUILD.gn
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/content/renderer/DEPS
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/content/renderer/browser_plugin/browser_plugin.cc
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/content/renderer/child_frame_compositing_helper.cc
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/content/renderer/child_frame_compositing_helper_unittest.cc
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/content/renderer/gpu/render_widget_compositor.cc
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/content/renderer/gpu/render_widget_compositor.h
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/content/renderer/media/stream/webmediaplayer_ms.cc
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/content/renderer/media/stream/webmediaplayer_ms.h
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/content/renderer/pepper/pepper_compositor_host.cc
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/content/renderer/pepper/pepper_plugin_instance_impl.cc
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/content/renderer/render_frame_proxy.cc
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/content/renderer/render_widget_fullscreen_pepper.cc
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/content/renderer/renderer_blink_platform_impl.h
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/content/shell/test_runner/BUILD.gn
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/content/shell/test_runner/test_plugin.cc
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/content/test/BUILD.gn
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/content/test/DEPS
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/content/test/test_blink_web_unit_test_support.cc
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/content/test/test_blink_web_unit_test_support.h
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/media/blink/BUILD.gn
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/media/blink/DEPS
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/media/blink/webmediaplayer_impl.h
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/media/blink/webmediaplayer_impl_unittest.cc
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/third_party/blink/public/BUILD.gn
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/third_party/blink/public/platform/DEPS
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/third_party/blink/public/platform/platform.h
[delete] https://crrev.com/7ca528c1d64bb421c29b57ed1a0a019bcc84b698/third_party/blink/public/platform/web_compositor_support.h
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/third_party/blink/public/platform/web_layer.h
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/third_party/blink/public/platform/web_layer_tree_view.h
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/third_party/blink/renderer/core/animation/animation.cc
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/third_party/blink/renderer/core/animation/document_timeline.cc
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/third_party/blink/renderer/core/exported/web_page_popup_impl.cc
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/third_party/blink/renderer/core/exported/web_page_popup_impl.h
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/third_party/blink/renderer/core/exported/web_plugin_container_impl.cc
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/third_party/blink/renderer/core/exported/web_plugin_container_test.cc
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/third_party/blink/renderer/core/exported/web_view_impl.cc
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/third_party/blink/renderer/core/exported/web_view_impl.h
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/third_party/blink/renderer/core/frame/visual_viewport.cc
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/third_party/blink/renderer/core/frame/web_frame_widget_impl.cc
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/third_party/blink/renderer/core/frame/web_frame_widget_impl.h
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/third_party/blink/renderer/core/page/scrolling/scrolling_coordinator.cc
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/third_party/blink/renderer/core/paint/link_highlight_impl.cc
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/third_party/blink/renderer/core/paint/stub_chrome_client_for_spv2.h
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/third_party/blink/renderer/core/paint/video_painter_test.cc
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/third_party/blink/renderer/modules/animationworklet/animation_worklet_thread_test.cc
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/third_party/blink/renderer/modules/animationworklet/worklet_animation.cc
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/third_party/blink/renderer/platform/BUILD.gn
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/third_party/blink/renderer/platform/DEPS
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/third_party/blink/renderer/platform/animation/DEPS
[add] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/third_party/blink/renderer/platform/exported/web_layer.cc
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/third_party/blink/renderer/platform/graphics/DEPS
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge.cc
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/third_party/blink/renderer/platform/graphics/compositing/paint_artifact_compositor.cc
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/third_party/blink/renderer/platform/graphics/compositing/paint_artifact_compositor_test.cc
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/third_party/blink/renderer/platform/graphics/gpu/drawing_buffer.cc
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/third_party/blink/renderer/platform/graphics/gpu/image_layer_bridge.cc
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/third_party/blink/renderer/platform/graphics/graphics_layer.cc
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/third_party/blink/renderer/platform/graphics/graphics_layer_test.cc
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/third_party/blink/renderer/platform/graphics/surface_layer_bridge.cc
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/third_party/blink/renderer/platform/scroll/DEPS
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/third_party/blink/renderer/platform/scroll/programmatic_scroll_animator.cc
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/third_party/blink/renderer/platform/scroll/scroll_animator.cc
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/third_party/blink/renderer/platform/scroll/scroll_animator_compositor_coordinator.cc
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/third_party/blink/renderer/platform/testing/testing_platform_support.cc
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/third_party/blink/renderer/platform/testing/testing_platform_support.h
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/third_party/blink/renderer/platform/testing/testing_platform_support_with_mock_scheduler.cc
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/third_party/blink/renderer/platform/testing/testing_platform_support_with_mock_scheduler.h
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/third_party/blink/renderer/platform/testing/web_layer_tree_view_impl_for_testing.cc
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/third_party/blink/renderer/platform/testing/web_layer_tree_view_impl_for_testing.h
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/ui/compositor/DEPS
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/ui/snapshot/DEPS
[modify] https://crrev.com/e0310db73b412532cf4ccb495636a51c412e7aad/ui/views/mus/DEPS
Project Member

Comment 15 by bugdroid1@chromium.org, May 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383

commit 8bc61c7a96bbee3f91ed746e7fc5f742b3a68383
Author: danakj <danakj@chromium.org>
Date: Wed May 16 13:55:06 2018

Make it (almost) possible to alias WebLayer to cc::Layer.

This makes every method in WebLayer match the method name in cc::Layer,
with exception of the constructor and the CcLayer() unwrapping methods.

It also includes web_layer.h instead of forward delcaring it everywhere
so when we change it to an alias, these files will know that, instead
of having to change them all to also alias. We'll later change them
back to cc::Layer forward declarations.

R=pdr@chromium.org
TBR=piman, dalecurtis

Bug: 838693
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I0b353da350326d57aeac03191dc88a775442d47f
Reviewed-on: https://chromium-review.googlesource.com/1056067
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559075}
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/cc/layers/layer.h
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/content/public/browser/android/content_view_layer_renderer.h
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/content/renderer/child_frame_compositing_helper.cc
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/content/renderer/child_frame_compositor.h
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/content/renderer/gpu/render_widget_compositor.cc
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/content/renderer/media/stream/webmediaplayer_ms.cc
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/content/renderer/media/stream/webmediaplayer_ms.h
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/content/renderer/media/stream/webmediaplayer_ms_unittest.cc
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/content/renderer/pepper/fullscreen_container.h
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/content/renderer/pepper/pepper_plugin_instance_impl.cc
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/content/renderer/pepper/pepper_plugin_instance_impl.h
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/content/renderer/render_widget_fullscreen_pepper.cc
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/content/renderer/render_widget_fullscreen_pepper.h
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/content/shell/android/shell_manager.h
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/content/shell/test_runner/test_plugin.h
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/media/blink/webmediaplayer_impl.h
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/public/platform/web_layer.h
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/public/platform/web_layer_tree_view.h
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/public/platform/web_media_player_client.h
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/public/web/web_plugin_container.h
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/public/web/web_remote_frame.h
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/renderer/core/exported/web_frame_test.cc
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/renderer/core/exported/web_page_popup_impl.h
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/renderer/core/exported/web_plugin_container_impl.cc
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/renderer/core/exported/web_selection.cc
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/renderer/core/frame/remote_frame.h
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/renderer/core/frame/visual_viewport.cc
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/renderer/core/frame/visual_viewport_test.cc
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/renderer/core/frame/web_frame_widget_base.h
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/renderer/core/frame/web_frame_widget_impl.h
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/renderer/core/html/canvas/canvas_rendering_context.h
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/renderer/core/html/media/html_media_element.cc
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/renderer/core/html/media/html_media_element.h
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/renderer/core/html/media/picture_in_picture_interstitial.cc
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/renderer/core/inspector/inspector_layer_tree_agent.cc
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/renderer/core/inspector/inspector_trace_events.cc
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/renderer/core/page/chrome_client.h
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/renderer/core/page/page.cc
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/renderer/core/page/scrolling/scrolling_coordinator.cc
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/renderer/core/page/scrolling/scrolling_coordinator.h
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/renderer/core/page/scrolling/scrolling_coordinator_test.cc
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping_test.cc
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/renderer/core/paint/html_canvas_painter.cc
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/renderer/core/paint/html_canvas_painter_test.cc
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/renderer/core/paint/link_highlight_impl.cc
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/renderer/core/paint/link_highlight_impl.h
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/renderer/core/paint/video_painter.cc
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/renderer/core/paint/video_painter_test.cc
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/renderer/core/scheduler/frame_throttling_test.cc
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/renderer/core/testing/internals.cc
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d.h
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.h
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/renderer/platform/exported/web_layer.cc
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge.h
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/renderer/platform/graphics/compositing/paint_artifact_compositor.h
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/renderer/platform/graphics/gpu/drawing_buffer.h
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/renderer/platform/graphics/gpu/image_layer_bridge.h
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/renderer/platform/graphics/graphics_layer.cc
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/renderer/platform/graphics/graphics_layer.h
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/renderer/platform/graphics/graphics_layer_test.cc
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/renderer/platform/graphics/image_layer_chromium_test.cc
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/renderer/platform/graphics/link_highlight.h
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/renderer/platform/graphics/paint/foreign_layer_display_item.h
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/renderer/platform/graphics/surface_layer_bridge.h
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/renderer/platform/scroll/scroll_animator_compositor_coordinator.cc
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/renderer/platform/scroll/scrollable_area.cc
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/renderer/platform/testing/web_layer_tree_view_impl_for_testing.cc
[modify] https://crrev.com/8bc61c7a96bbee3f91ed746e7fc5f742b3a68383/third_party/blink/renderer/platform/testing/web_layer_tree_view_impl_for_testing.h
Project Member

Comment 16 by bugdroid1@chromium.org, May 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e669e78cce177575aac3bd9587634b3eb405adc

commit 6e669e78cce177575aac3bd9587634b3eb405adc
Author: danakj <danakj@chromium.org>
Date: Wed May 16 16:57:17 2018

Make WebLayer an alias for cc::Layer.

This removes all std::unique_ptr<WebLayer> and pass around cc::Layer*
directly instead of WebLayer*.

R=pdr@chromium.org

Bug: 838693
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ic36930e83f8d5f64780c7f6b46632c9bd90888f6
Reviewed-on: https://chromium-review.googlesource.com/1060351
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559144}
[modify] https://crrev.com/6e669e78cce177575aac3bd9587634b3eb405adc/content/renderer/browser_plugin/browser_plugin.cc
[modify] https://crrev.com/6e669e78cce177575aac3bd9587634b3eb405adc/content/renderer/browser_plugin/browser_plugin.h
[modify] https://crrev.com/6e669e78cce177575aac3bd9587634b3eb405adc/content/renderer/child_frame_compositing_helper_unittest.cc
[modify] https://crrev.com/6e669e78cce177575aac3bd9587634b3eb405adc/content/renderer/gpu/render_widget_compositor.cc
[modify] https://crrev.com/6e669e78cce177575aac3bd9587634b3eb405adc/content/renderer/media/stream/webmediaplayer_ms.cc
[modify] https://crrev.com/6e669e78cce177575aac3bd9587634b3eb405adc/content/renderer/media/stream/webmediaplayer_ms.h
[modify] https://crrev.com/6e669e78cce177575aac3bd9587634b3eb405adc/content/renderer/pepper/pepper_plugin_instance_impl.cc
[modify] https://crrev.com/6e669e78cce177575aac3bd9587634b3eb405adc/content/renderer/pepper/pepper_plugin_instance_impl.h
[modify] https://crrev.com/6e669e78cce177575aac3bd9587634b3eb405adc/content/renderer/render_frame_proxy.cc
[modify] https://crrev.com/6e669e78cce177575aac3bd9587634b3eb405adc/content/renderer/render_frame_proxy.h
[modify] https://crrev.com/6e669e78cce177575aac3bd9587634b3eb405adc/content/shell/test_runner/test_plugin.cc
[modify] https://crrev.com/6e669e78cce177575aac3bd9587634b3eb405adc/content/shell/test_runner/test_plugin.h
[modify] https://crrev.com/6e669e78cce177575aac3bd9587634b3eb405adc/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/6e669e78cce177575aac3bd9587634b3eb405adc/media/blink/webmediaplayer_impl.h
[modify] https://crrev.com/6e669e78cce177575aac3bd9587634b3eb405adc/media/blink/webmediaplayer_impl_unittest.cc
[modify] https://crrev.com/6e669e78cce177575aac3bd9587634b3eb405adc/third_party/blink/public/platform/web_layer.h
[modify] https://crrev.com/6e669e78cce177575aac3bd9587634b3eb405adc/third_party/blink/renderer/core/exported/web_frame_test.cc
[modify] https://crrev.com/6e669e78cce177575aac3bd9587634b3eb405adc/third_party/blink/renderer/core/exported/web_plugin_container_test.cc
[modify] https://crrev.com/6e669e78cce177575aac3bd9587634b3eb405adc/third_party/blink/renderer/core/frame/visual_viewport.cc
[modify] https://crrev.com/6e669e78cce177575aac3bd9587634b3eb405adc/third_party/blink/renderer/core/page/scrolling/scrolling_coordinator.cc
[modify] https://crrev.com/6e669e78cce177575aac3bd9587634b3eb405adc/third_party/blink/renderer/core/page/scrolling/scrolling_coordinator.h
[modify] https://crrev.com/6e669e78cce177575aac3bd9587634b3eb405adc/third_party/blink/renderer/core/paint/link_highlight_impl.cc
[modify] https://crrev.com/6e669e78cce177575aac3bd9587634b3eb405adc/third_party/blink/renderer/core/paint/link_highlight_impl.h
[modify] https://crrev.com/6e669e78cce177575aac3bd9587634b3eb405adc/third_party/blink/renderer/core/paint/video_painter_test.cc
[modify] https://crrev.com/6e669e78cce177575aac3bd9587634b3eb405adc/third_party/blink/renderer/platform/BUILD.gn
[delete] https://crrev.com/f8ccad1ea0039d982ca121ab24ee13a89ebee68d/third_party/blink/renderer/platform/exported/web_layer.cc
[modify] https://crrev.com/6e669e78cce177575aac3bd9587634b3eb405adc/third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge.cc
[modify] https://crrev.com/6e669e78cce177575aac3bd9587634b3eb405adc/third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge.h
[modify] https://crrev.com/6e669e78cce177575aac3bd9587634b3eb405adc/third_party/blink/renderer/platform/graphics/compositing/paint_artifact_compositor.cc
[modify] https://crrev.com/6e669e78cce177575aac3bd9587634b3eb405adc/third_party/blink/renderer/platform/graphics/compositing/paint_artifact_compositor.h
[modify] https://crrev.com/6e669e78cce177575aac3bd9587634b3eb405adc/third_party/blink/renderer/platform/graphics/gpu/drawing_buffer.cc
[modify] https://crrev.com/6e669e78cce177575aac3bd9587634b3eb405adc/third_party/blink/renderer/platform/graphics/gpu/drawing_buffer.h
[modify] https://crrev.com/6e669e78cce177575aac3bd9587634b3eb405adc/third_party/blink/renderer/platform/graphics/gpu/image_layer_bridge.cc
[modify] https://crrev.com/6e669e78cce177575aac3bd9587634b3eb405adc/third_party/blink/renderer/platform/graphics/gpu/image_layer_bridge.h
[modify] https://crrev.com/6e669e78cce177575aac3bd9587634b3eb405adc/third_party/blink/renderer/platform/graphics/graphics_layer.cc
[modify] https://crrev.com/6e669e78cce177575aac3bd9587634b3eb405adc/third_party/blink/renderer/platform/graphics/graphics_layer.h
[modify] https://crrev.com/6e669e78cce177575aac3bd9587634b3eb405adc/third_party/blink/renderer/platform/graphics/paint/foreign_layer_display_item.cc
[modify] https://crrev.com/6e669e78cce177575aac3bd9587634b3eb405adc/third_party/blink/renderer/platform/graphics/surface_layer_bridge.cc
[modify] https://crrev.com/6e669e78cce177575aac3bd9587634b3eb405adc/third_party/blink/renderer/platform/graphics/surface_layer_bridge.h
[modify] https://crrev.com/6e669e78cce177575aac3bd9587634b3eb405adc/third_party/blink/renderer/platform/testing/web_layer_tree_view_impl_for_testing.cc
Project Member

Comment 17 by bugdroid1@chromium.org, May 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a062b1175761bb869cb031b675fbeccce486b5a

commit 6a062b1175761bb869cb031b675fbeccce486b5a
Author: danakj <danakj@chromium.org>
Date: Thu May 17 16:25:45 2018

Remove WebLayer alias, use cc::Layer type directly.

Replace includes of web_layer.h in header files to forward declarations
of cc::Layer. Rename variables from web_*layer to cc_*layer or just
layer.

This does not rename the SetWebLayer() GetWebLayer() or PlatformLayer()
methods yet.

R=avi@chromium.org, dalecurtis@chromium.org, pdr@chromium.org

Bug: 838693
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I606d7af50633e1fb57cd86a648b4f7433cb13da7
Reviewed-on: https://chromium-review.googlesource.com/1062016
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559561}
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/cc/layers/layer.h
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/content/public/browser/android/content_view_layer_renderer.h
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/content/renderer/browser_plugin/browser_plugin.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/content/renderer/browser_plugin/browser_plugin.h
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/content/renderer/child_frame_compositing_helper.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/content/renderer/child_frame_compositing_helper_unittest.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/content/renderer/child_frame_compositor.h
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/content/renderer/gpu/render_widget_compositor.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/content/renderer/gpu/render_widget_compositor.h
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/content/renderer/media/stream/webmediaplayer_ms.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/content/renderer/media/stream/webmediaplayer_ms.h
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/content/renderer/media/stream/webmediaplayer_ms_unittest.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/content/renderer/pepper/fullscreen_container.h
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/content/renderer/pepper/pepper_plugin_instance_impl.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/content/renderer/pepper/pepper_plugin_instance_impl.h
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/content/renderer/render_frame_proxy.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/content/renderer/render_frame_proxy.h
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/content/renderer/render_widget_fullscreen_pepper.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/content/renderer/render_widget_fullscreen_pepper.h
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/content/shell/android/shell_manager.h
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/content/shell/test_runner/test_plugin.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/content/shell/test_runner/test_plugin.h
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/media/blink/DEPS
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/media/blink/webmediaplayer_impl.h
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/media/blink/webmediaplayer_impl_unittest.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/public/BUILD.gn
[delete] https://crrev.com/63d75345745e5a7d991ce4cd1ecd7c6f8dbd3515/third_party/blink/public/platform/web_external_texture_layer.h
[delete] https://crrev.com/63d75345745e5a7d991ce4cd1ecd7c6f8dbd3515/third_party/blink/public/platform/web_image_layer.h
[delete] https://crrev.com/63d75345745e5a7d991ce4cd1ecd7c6f8dbd3515/third_party/blink/public/platform/web_layer.h
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/public/platform/web_layer_tree_view.h
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/public/platform/web_media_player_client.h
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/public/platform/web_surface_layer_bridge.h
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/public/web/web_plugin_container.h
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/public/web/web_remote_frame.h
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/core/exported/web_frame_test.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/core/exported/web_page_popup_impl.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/core/exported/web_page_popup_impl.h
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/core/exported/web_plugin_container_impl.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/core/exported/web_plugin_container_impl.h
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/core/exported/web_plugin_container_test.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/core/exported/web_remote_frame_impl.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/core/exported/web_remote_frame_impl.h
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/core/exported/web_selection.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/core/exported/web_view_impl.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/core/exported/web_view_impl.h
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/core/frame/remote_frame.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/core/frame/remote_frame.h
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/core/frame/visual_viewport.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/core/frame/visual_viewport_test.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/core/frame/web_frame_widget_base.h
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/core/frame/web_frame_widget_impl.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/core/frame/web_frame_widget_impl.h
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/core/frame/web_local_frame_impl.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/core/frame/web_view_frame_widget.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/core/frame/web_view_frame_widget.h
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/core/html/canvas/canvas_rendering_context.h
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/core/html/canvas/html_canvas_element.h
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/core/html/html_plugin_element.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/core/html/media/html_media_element.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/core/html/media/html_media_element.h
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/core/html/media/picture_in_picture_interstitial.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/core/inspector/inspector_layer_tree_agent.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/core/layout/layout_object.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/core/layout/layout_video.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/core/loader/empty_clients.h
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/core/page/chrome_client.h
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/core/page/chrome_client_impl.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/core/page/chrome_client_impl.h
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/core/page/page.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/core/page/page_overlay.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/core/page/scrolling/scrolling_coordinator.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/core/page/scrolling/scrolling_coordinator.h
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/core/page/scrolling/scrolling_coordinator_test.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping_test.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/core/paint/compositing/paint_layer_compositor.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/core/paint/html_canvas_painter.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/core/paint/html_canvas_painter_test.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/core/paint/link_highlight_impl.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/core/paint/link_highlight_impl.h
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/core/paint/stub_chrome_client_for_spv2.h
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/core/paint/video_painter.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/core/paint/video_painter_test.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/core/scheduler/frame_throttling_test.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/core/testing/internals.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d.h
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/modules/canvas/imagebitmap/image_bitmap_rendering_context_base.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/modules/canvas/imagebitmap/image_bitmap_rendering_context_base.h
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.h
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/platform/DEPS
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge.h
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/platform/graphics/compositing/paint_artifact_compositor.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/platform/graphics/compositing/paint_artifact_compositor.h
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/platform/graphics/gpu/drawing_buffer.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/platform/graphics/gpu/drawing_buffer.h
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/platform/graphics/gpu/image_layer_bridge.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/platform/graphics/gpu/image_layer_bridge.h
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/platform/graphics/graphics_layer.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/platform/graphics/graphics_layer.h
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/platform/graphics/graphics_layer_test.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/platform/graphics/image_layer_chromium_test.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/platform/graphics/link_highlight.h
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/platform/graphics/paint/foreign_layer_display_item.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/platform/graphics/paint/foreign_layer_display_item.h
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/platform/graphics/surface_layer_bridge.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/platform/graphics/surface_layer_bridge.h
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/platform/scroll/scroll_animator.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/platform/scroll/scroll_animator_compositor_coordinator.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/platform/scroll/scrollable_area.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/platform/scroll/scrollable_area.h
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/platform/testing/testing_platform_support.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/platform/testing/web_layer_tree_view_impl_for_testing.cc
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/third_party/blink/renderer/platform/testing/web_layer_tree_view_impl_for_testing.h
[modify] https://crrev.com/6a062b1175761bb869cb031b675fbeccce486b5a/ui/compositor/layer.cc
Project Member

Comment 18 by bugdroid1@chromium.org, May 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d204a47e52eba9b79de87c8df23c3c3c0d70327

commit 8d204a47e52eba9b79de87c8df23c3c3c0d70327
Author: danakj <danakj@chromium.org>
Date: Fri May 18 18:05:35 2018

Rename GetWebLayer(), SetWebLayer(), PlatformLayer() to .*CcLayer()

GetWebLayer -> GetCcLayer
SetWebLayer -> SetCcLayer
PlatformLayer -> CcLayer

R=chrishtr@chromium.org
TBR=jam

Bug: 838693
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ibefb912f126d83b877366475011820409fb2ac16
Reviewed-on: https://chromium-review.googlesource.com/1062023
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559956}
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/content/renderer/browser_plugin/browser_plugin.cc
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/content/renderer/media/stream/webmediaplayer_ms.cc
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/content/renderer/media/stream/webmediaplayer_ms_unittest.cc
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/content/renderer/pepper/pepper_plugin_instance_impl.cc
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/content/renderer/render_frame_proxy.cc
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/content/shell/test_runner/test_plugin.cc
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/media/blink/webmediaplayer_impl_unittest.cc
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/public/platform/web_media_player_client.h
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/public/platform/web_surface_layer_bridge.h
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/public/web/web_plugin_container.h
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/public/web/web_remote_frame.h
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/core/animation/compositor_animations.cc
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/core/exported/web_frame_test.cc
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/core/exported/web_page_popup_impl.cc
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/core/exported/web_plugin_container_impl.cc
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/core/exported/web_plugin_container_impl.h
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/core/exported/web_plugin_container_test.cc
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/core/exported/web_remote_frame_impl.cc
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/core/exported/web_remote_frame_impl.h
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/core/exported/web_selection.cc
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/core/exported/web_view_impl.cc
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/core/frame/remote_frame.cc
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/core/frame/remote_frame.h
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/core/frame/visual_viewport.cc
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/core/frame/visual_viewport_test.cc
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/core/frame/web_frame_widget_impl.cc
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/core/html/canvas/canvas_rendering_context.h
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/core/html/html_plugin_element.cc
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/core/html/media/html_media_element.cc
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/core/html/media/html_media_element.h
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/core/html/media/picture_in_picture_interstitial.cc
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/core/inspector/inspector_layer_tree_agent.cc
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/core/inspector/inspector_trace_events.cc
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/core/layout/layout_embedded_content.cc
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/core/layout/layout_video.cc
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/core/page/page.cc
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/core/page/page_overlay.cc
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/core/page/scrolling/scrolling_coordinator.cc
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/core/page/scrolling/scrolling_coordinator_test.cc
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping_test.cc
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/core/paint/compositing/paint_layer_compositor.cc
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/core/paint/html_canvas_painter.cc
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/core/paint/html_canvas_painter_test.cc
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/core/paint/paint_layer.cc
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/core/paint/video_painter.cc
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/core/paint/video_painter_test.cc
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/core/scheduler/frame_throttling_test.cc
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/core/testing/internals.cc
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d.cc
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d.h
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/modules/canvas/imagebitmap/image_bitmap_rendering_context_base.cc
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/modules/canvas/imagebitmap/image_bitmap_rendering_context_base.h
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.h
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/platform/graphics/compositing/paint_artifact_compositor.h
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/platform/graphics/compositing/paint_artifact_compositor_test.cc
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/platform/graphics/gpu/drawing_buffer.cc
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/platform/graphics/gpu/drawing_buffer.h
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/platform/graphics/gpu/image_layer_bridge.cc
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/platform/graphics/gpu/image_layer_bridge.h
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/platform/graphics/graphics_layer.cc
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/platform/graphics/graphics_layer.h
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/platform/graphics/graphics_layer_test.cc
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/platform/graphics/surface_layer_bridge.h
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/platform/scroll/scroll_animator.cc
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/platform/scroll/scroll_animator_compositor_coordinator.cc
[modify] https://crrev.com/8d204a47e52eba9b79de87c8df23c3c3c0d70327/third_party/blink/renderer/platform/scroll/scrollable_area.cc

Comment 19 by danakj@chromium.org, May 18 2018

Cc: danakj@chromium.org pdr@chromium.org chrishtr@chromium.org
ok WebLayer itself is gone. I kinda wanna leave this bug open for WebLayerTreeView and friends though.
Project Member

Comment 20 by bugdroid1@chromium.org, May 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43090f2c8c2cde1683fc1d97354b63616ea1c671

commit 43090f2c8c2cde1683fc1d97354b63616ea1c671
Author: danakj <danakj@chromium.org>
Date: Tue May 22 22:55:51 2018

Stop preventing image layers from being marked as opaque.

Before https://chromium-review.googlesource.com/c/chromium/src/+/1038565
these layers would change their contents-opaque state when the
GraphicsLayer did, even though the image layer has its contents-opaque
set when setting the image.

Disallowing that to change created a memory regression, as it must be
that some images are not opaque, but the GraphicsLayer becomes opaque
later and the image layer should be marked as such too.

R=pdr@chromium.org

Bug: 838693, 841252
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I97c007b46d0bafcb9ecf19fad77327053e978aa2
Reviewed-on: https://chromium-review.googlesource.com/1069194
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560824}
[modify] https://crrev.com/43090f2c8c2cde1683fc1d97354b63616ea1c671/third_party/blink/renderer/platform/graphics/graphics_layer.cc
Project Member

Comment 21 by bugdroid1@chromium.org, May 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/381752d85c690caca4de32ba2723726165c81ebf

commit 381752d85c690caca4de32ba2723726165c81ebf
Author: danakj <danakj@chromium.org>
Date: Wed May 23 17:20:18 2018

Revert "Stop preventing image layers from being marked as opaque."

This reverts commit 43090f2c8c2cde1683fc1d97354b63616ea1c671.

Reason for revert: This makes the system more correct, the regression in memory is additional shaders to draw the opaque images, and we gain gpu (over)drawing performance from it.

Original change's description:
> Stop preventing image layers from being marked as opaque.
> 
> Before https://chromium-review.googlesource.com/c/chromium/src/+/1038565
> these layers would change their contents-opaque state when the
> GraphicsLayer did, even though the image layer has its contents-opaque
> set when setting the image.
> 
> Disallowing that to change created a memory regression, as it must be
> that some images are not opaque, but the GraphicsLayer becomes opaque
> later and the image layer should be marked as such too.
> 
> R=​pdr@chromium.org
> 
> Bug: 838693, 841252
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Change-Id: I97c007b46d0bafcb9ecf19fad77327053e978aa2
> Reviewed-on: https://chromium-review.googlesource.com/1069194
> Reviewed-by: Philip Rogers <pdr@chromium.org>
> Commit-Queue: danakj <danakj@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#560824}

TBR=danakj@chromium.org,pdr@chromium.org

Change-Id: I59f9468a0fdb50234b26b3b6d63b22dfc5e2d7a6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 838693, 841252
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/1070003
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561137}
[modify] https://crrev.com/381752d85c690caca4de32ba2723726165c81ebf/third_party/blink/renderer/platform/graphics/graphics_layer.cc
Project Member

Comment 22 by bugdroid1@chromium.org, Jun 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6cf717297e166e91e5a7421b1414435b4ce3d08f

commit 6cf717297e166e91e5a7421b1414435b4ce3d08f
Author: danakj <danakj@chromium.org>
Date: Tue Jun 26 17:16:58 2018

content: Simplify RenderWidgetCompositor construction

Currently it uses the LayerTreeHostClient to pass a bool around from
RenderWidget to RenderWidgetCompositor, and constructs the cc
structures in RenderWidget, when RenderWidgetCompositor is meant to
be wrapping them, so it could just create them.

But expose the cc::LayerTreeSettings to RenderWidget so that tests
have a chance to override those, instead. They don't need to be able
to replace the LayerTreeHost/AnimationHost types.

NOTRY=true
TBR=pdr

Bug: 838693
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: If7742e248b3d8799d1590dee43ce2eeb7e516146
Reviewed-on: https://chromium-review.googlesource.com/1112595
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570438}
[modify] https://crrev.com/6cf717297e166e91e5a7421b1414435b4ce3d08f/cc/test/layer_tree_test.cc
[modify] https://crrev.com/6cf717297e166e91e5a7421b1414435b4ce3d08f/cc/test/stub_layer_tree_host_client.cc
[modify] https://crrev.com/6cf717297e166e91e5a7421b1414435b4ce3d08f/cc/test/stub_layer_tree_host_client.h
[modify] https://crrev.com/6cf717297e166e91e5a7421b1414435b4ce3d08f/cc/trees/layer_tree_host_client.h
[modify] https://crrev.com/6cf717297e166e91e5a7421b1414435b4ce3d08f/content/browser/renderer_host/compositor_impl_android.cc
[modify] https://crrev.com/6cf717297e166e91e5a7421b1414435b4ce3d08f/content/browser/renderer_host/compositor_impl_android.h
[modify] https://crrev.com/6cf717297e166e91e5a7421b1414435b4ce3d08f/content/renderer/gpu/render_widget_compositor.cc
[modify] https://crrev.com/6cf717297e166e91e5a7421b1414435b4ce3d08f/content/renderer/gpu/render_widget_compositor.h
[modify] https://crrev.com/6cf717297e166e91e5a7421b1414435b4ce3d08f/content/renderer/gpu/render_widget_compositor_unittest.cc
[modify] https://crrev.com/6cf717297e166e91e5a7421b1414435b4ce3d08f/content/renderer/render_widget.cc
[modify] https://crrev.com/6cf717297e166e91e5a7421b1414435b4ce3d08f/third_party/blink/renderer/platform/testing/web_layer_tree_view_impl_for_testing.cc
[modify] https://crrev.com/6cf717297e166e91e5a7421b1414435b4ce3d08f/third_party/blink/renderer/platform/testing/web_layer_tree_view_impl_for_testing.h
[modify] https://crrev.com/6cf717297e166e91e5a7421b1414435b4ce3d08f/ui/compositor/compositor.cc
[modify] https://crrev.com/6cf717297e166e91e5a7421b1414435b4ce3d08f/ui/compositor/compositor.h
Project Member

Comment 23 by bugdroid1@chromium.org, Jun 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff6a026519f18379d30dab0cb289c71257eea1bc

commit ff6a026519f18379d30dab0cb289c71257eea1bc
Author: danakj <danakj@chromium.org>
Date: Tue Jun 26 19:50:31 2018

Remove WebCanvas alias, use cc::PaintCanvas directly in blink.

This removes the blink::WebCanvas and blink::PaintCanvas aliases for
cc::PaintCanvas, using the type directly everywhere instead.

Also some bonus un-indirection of cc::PaintFlags through
blink::PaintFlags though the alias remains for now.

TBR=haraken

Bug: 838693
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ib07545bf6d6d1173e62792143e9d44ed1ab74619
Reviewed-on: https://chromium-review.googlesource.com/1112671
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570498}
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/components/plugins/renderer/webview_plugin.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/components/plugins/renderer/webview_plugin.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/components/printing/renderer/DEPS
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/components/printing/renderer/print_render_frame_helper.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/components/printing/renderer/print_render_frame_helper.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/components/printing/renderer/print_render_frame_helper_mac.mm
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/content/child/browser_font_resource_trusted.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/content/child/webthemeengine_impl_android.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/content/child/webthemeengine_impl_android.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/content/child/webthemeengine_impl_default.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/content/child/webthemeengine_impl_default.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/content/renderer/browser_plugin/browser_plugin.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/content/renderer/gpu/gpu_benchmarking_extension.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/content/renderer/media/stream/webmediaplayer_ms.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/content/renderer/media/stream/webmediaplayer_ms.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/content/renderer/media_capture_from_element/html_video_element_capturer_source_unittest.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/content/renderer/pepper/pepper_graphics_2d_host.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/content/renderer/pepper/pepper_graphics_2d_host.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/content/renderer/pepper/pepper_plugin_instance_impl.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/content/renderer/pepper/pepper_plugin_instance_impl.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/content/renderer/pepper/pepper_webplugin_impl.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/content/renderer/pepper/pepper_webplugin_impl.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/content/renderer/render_frame_proxy.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/content/renderer/render_frame_proxy.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/content/renderer/render_widget_fullscreen_pepper.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/content/renderer/sad_plugin.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/content/renderer/sad_plugin.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/content/shell/test_runner/mock_web_theme_engine.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/content/shell/test_runner/mock_web_theme_engine.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/content/shell/test_runner/test_plugin.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/content/shell/test_runner/test_runner.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/content/shell/test_runner/test_runner_for_specific_view.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/media/blink/webmediaplayer_impl.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/public/BUILD.gn
[delete] https://crrev.com/9c478b22a6ddfdeb21373cd52ecd72bf0063a458/third_party/blink/public/platform/web_canvas.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/public/platform/web_font.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/public/platform/web_media_player.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/public/platform/web_theme_engine.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/public/web/DEPS
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/public/web/web_frame.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/public/web/web_local_frame.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/public/web/web_plugin.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/public/web/web_remote_frame_client.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/public/web/web_widget.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/core/DEPS
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/core/clipboard/data_transfer.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/core/css/threaded/font_object_threaded_test.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/core/exported/fake_web_plugin.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/core/exported/web_page_popup_impl.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/core/exported/web_page_popup_impl.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/core/exported/web_plugin_container_impl.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/core/exported/web_plugin_container_test.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/core/exported/web_view_impl.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/core/exported/web_view_impl.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/core/frame/remote_frame_client.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/core/frame/remote_frame_client_impl.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/core/frame/remote_frame_client_impl.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/core/frame/remote_frame_view.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/core/frame/remote_frame_view.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/core/frame/web_frame_widget_impl.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/core/frame/web_frame_widget_impl.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/core/frame/web_local_frame_impl.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/core/frame/web_local_frame_impl.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/core/frame/web_view_frame_widget.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/core/frame/web_view_frame_widget.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/core/html/canvas/canvas_rendering_context.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/core/html/forms/external_popup_menu.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/core/html/media/html_video_element.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/core/html/media/html_video_element.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/core/layout/shapes/shape.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/core/layout/svg/layout_svg_resource_pattern.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/core/loader/empty_clients.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/core/page/page_overlay_test.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/core/page/page_widget_delegate.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/core/page/page_widget_delegate.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/core/paint/link_highlight_impl.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/core/paint/svg_shape_painter.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/core/paint/theme_painter_default.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/core/svg/graphics/filters/svg_fe_image.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/core/svg/graphics/svg_image.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/core/svg/graphics/svg_image.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/core/svg/graphics/svg_image_for_container.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/core/svg/graphics/svg_image_for_container.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/modules/canvas/canvas2d/base_rendering_context_2d.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/modules/canvas/canvas2d/base_rendering_context_2d.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d_state.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d_test.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/modules/canvas/canvas2d/clip_list.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/modules/canvas/canvas2d/clip_list.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/modules/canvas/offscreencanvas2d/offscreen_canvas_rendering_context_2d.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/modules/canvas/offscreencanvas2d/offscreen_canvas_rendering_context_2d.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/modules/csspaint/paint_rendering_context_2d.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/modules/csspaint/paint_rendering_context_2d.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/drag_image_test.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/exported/web_font.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/fonts/font.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/fonts/font.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/graphics/accelerated_static_bitmap_image.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/graphics/accelerated_static_bitmap_image.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/graphics/bitmap_image.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/graphics/bitmap_image.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge_test.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/graphics/canvas_resource_host.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/graphics/canvas_resource_provider.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/graphics/compositing/content_layer_client_impl.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/graphics/compositing/paint_artifact_compositor.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/graphics/compositing/paint_chunks_to_cc_layer.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/graphics/compositing/paint_chunks_to_cc_layer_test.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/graphics/crossfade_generated_image.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/graphics/crossfade_generated_image.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/graphics/deferred_image_decoder_test.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/graphics/gradient_generated_image.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/graphics/gradient_generated_image.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/graphics/graphics_context.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/graphics/graphics_context.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/graphics/graphics_context_test.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/graphics/image.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/graphics/image.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/graphics/image_layer_chromium_test.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/graphics/image_pattern.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/graphics/paint/drawing_display_item_test.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/graphics/paint/paint_artifact.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/graphics/paint/paint_artifact.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/graphics/paint/paint_canvas.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/graphics/paint/paint_record_builder.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/graphics/paint/paint_record_builder.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/graphics/paint_generated_image.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/graphics/paint_generated_image.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/graphics/pattern.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/graphics/placeholder_image.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/graphics/placeholder_image.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/graphics/skia/skia_utils.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/graphics/skia/skia_utils.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/graphics/static_bitmap_image.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/graphics/static_bitmap_image.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/graphics/test/fake_canvas_resource_host.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/graphics/test/mock_paint_canvas.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/graphics/test/stub_image.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/graphics/unaccelerated_static_bitmap_image.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/graphics/unaccelerated_static_bitmap_image.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/mac/DEPS
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/mac/graphics_context_canvas.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/mac/graphics_context_canvas.mm
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/mac/graphics_context_canvas_test.mm
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/mac/local_current_graphics_context.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/mac/local_current_graphics_context.mm
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/scroll/scrollbar_layer_delegate.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/scroll/scrollbar_layer_delegate.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/scroll/scrollbar_theme_aura.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/scroll/scrollbar_theme_overlay.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/testing/empty_web_media_player.h
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/renderer/platform/testing/test_paint_artifact.cc
[modify] https://crrev.com/ff6a026519f18379d30dab0cb289c71257eea1bc/third_party/blink/tools/audit_non_blink_usage.py
Project Member

Comment 24 by bugdroid1@chromium.org, Jun 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c010018037bd0fa6297041ca4392c2451c92169e

commit c010018037bd0fa6297041ca4392c2451c92169e
Author: danakj <danakj@chromium.org>
Date: Wed Jun 27 20:14:11 2018

Some cleanup in FrameTestHelpers

While trying to remove WebLayerTreeView this file confused me greatly
so try to simplify and clarify things a bit.

TestWebViewWidgetClient was-a TestWebWidgetClient, but you can
get a WebWidgetClient from a WebView directly by calling
WidgetClient(), so no need for this adapter.

AllowsBrokenNullLayerTreeView() is for when InitializeLayerTreeView()
returns null, which these classes don't do, so remove it.

R=dcheng@chromium.org

Bug: 838693
Change-Id: I65c258d0eaedb55de70edecffa134f5bf050cb76
Reviewed-on: https://chromium-review.googlesource.com/1115901
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570883}
[modify] https://crrev.com/c010018037bd0fa6297041ca4392c2451c92169e/third_party/blink/renderer/core/frame/frame_test_helpers.cc
[modify] https://crrev.com/c010018037bd0fa6297041ca4392c2451c92169e/third_party/blink/renderer/core/frame/frame_test_helpers.h
Project Member

Comment 25 by bugdroid1@chromium.org, Jun 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87caa8c324966fb44ebc5de1dcfadc51f898b66e

commit 87caa8c324966fb44ebc5de1dcfadc51f898b66e
Author: danakj <danakj@chromium.org>
Date: Wed Jun 27 23:50:12 2018

Remove use of WebLayerTreeViewImplForTesting in FrameTestHelpers

Use a RenderWidgetCompositor, which is the thing that holds the
LayerTreeHost instead of using a replicated test-only thing. This
will help to remove the WebLayerTreeView interface.

Later RenderWidgetCompositor will move to blink/renderer/platform/graphics,
as it is the compositor interface for blink core. Later later maybe we
could collapse it into cc::LayerTreeHost maybe.

R=dcheng@chromium.org

Bug: 838693
Change-Id: I848e13c751cfd11106393efe12e75ac01e4377e0
Reviewed-on: https://chromium-review.googlesource.com/1117463
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570937}
[modify] https://crrev.com/87caa8c324966fb44ebc5de1dcfadc51f898b66e/content/renderer/gpu/render_widget_compositor_unittest.cc
[modify] https://crrev.com/87caa8c324966fb44ebc5de1dcfadc51f898b66e/content/test/BUILD.gn
[add] https://crrev.com/87caa8c324966fb44ebc5de1dcfadc51f898b66e/content/test/stub_render_widget_compositor_delegate.cc
[add] https://crrev.com/87caa8c324966fb44ebc5de1dcfadc51f898b66e/content/test/stub_render_widget_compositor_delegate.h
[modify] https://crrev.com/87caa8c324966fb44ebc5de1dcfadc51f898b66e/third_party/blink/renderer/core/DEPS
[modify] https://crrev.com/87caa8c324966fb44ebc5de1dcfadc51f898b66e/third_party/blink/renderer/core/frame/frame_test_helpers.cc
[modify] https://crrev.com/87caa8c324966fb44ebc5de1dcfadc51f898b66e/third_party/blink/renderer/core/frame/frame_test_helpers.h
[modify] https://crrev.com/87caa8c324966fb44ebc5de1dcfadc51f898b66e/third_party/blink/renderer/core/page/page_overlay_test.cc
[modify] https://crrev.com/87caa8c324966fb44ebc5de1dcfadc51f898b66e/third_party/blink/tools/audit_non_blink_usage.py
Project Member

Comment 26 by bugdroid1@chromium.org, Jun 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d087fbbf431bc2e16cdf99b33e5f9296cf5dd4d

commit 5d087fbbf431bc2e16cdf99b33e5f9296cf5dd4d
Author: danakj <danakj@chromium.org>
Date: Thu Jun 28 16:15:54 2018

Remove WebLayerTreeViewImplForTesting in PaintAndRaster tests

Use cc::LayerTreeHost instead, as these tests just need to use cc
APIs for testing painting. They do not use the WebViewImpl etc layer.

NOTRY=true

Bug: 838693
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ide21fc6acdbd4c1171987f964ea6b157e79789e0
Reviewed-on: https://chromium-review.googlesource.com/1117622
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571149}
[modify] https://crrev.com/5d087fbbf431bc2e16cdf99b33e5f9296cf5dd4d/third_party/blink/renderer/core/DEPS
[modify] https://crrev.com/5d087fbbf431bc2e16cdf99b33e5f9296cf5dd4d/third_party/blink/renderer/core/paint/paint_and_raster_invalidation_test.h
Project Member

Comment 27 by bugdroid1@chromium.org, Jun 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41c15724dc288f2cc91d6cc8085be54b503ff2bf

commit 41c15724dc288f2cc91d6cc8085be54b503ff2bf
Author: danakj <danakj@chromium.org>
Date: Thu Jun 28 16:19:56 2018

Use cc::LayerTreeHost for StubChromeClientForSPv2

Currently its using WebLayerTreeViewImplForTesting but it only uses
the cc::LayerTreeHost, not the WebViewImpl things, so it just needs
a LayerTreeHost itself. This helps us toward removing the
WebLayerTreeView interface.

R=chrishtr@chromium.org

Bug: 838693
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ia60ea4128ed029f09ee4abe012ee62f315633c88
Reviewed-on: https://chromium-review.googlesource.com/1117656
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571152}
[modify] https://crrev.com/41c15724dc288f2cc91d6cc8085be54b503ff2bf/third_party/blink/renderer/core/BUILD.gn
[add] https://crrev.com/41c15724dc288f2cc91d6cc8085be54b503ff2bf/third_party/blink/renderer/core/paint/layer_tree_host_for_paint_artifact_test.cc
[add] https://crrev.com/41c15724dc288f2cc91d6cc8085be54b503ff2bf/third_party/blink/renderer/core/paint/layer_tree_host_for_paint_artifact_test.h
[modify] https://crrev.com/41c15724dc288f2cc91d6cc8085be54b503ff2bf/third_party/blink/renderer/core/paint/paint_and_raster_invalidation_test.h
[modify] https://crrev.com/41c15724dc288f2cc91d6cc8085be54b503ff2bf/third_party/blink/renderer/core/paint/stub_chrome_client_for_spv2.h
Project Member

Comment 28 by bugdroid1@chromium.org, Jun 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b99858190e95d9a3149a71f6db6d0685f073d0fb

commit b99858190e95d9a3149a71f6db6d0685f073d0fb
Author: danakj <danakj@chromium.org>
Date: Thu Jun 28 21:57:33 2018

Remove use of WebLayerTreeViewImplForTesting in platform tests.

Migrate the LayerTreeHostForPaintArtifactTest to platform/testing/
as LayerTreeHostEmbedder, and use it in platform/graphics/ tests
that want to construct a cc::LayerTreeHost but currently do so through
WebLayerTreeViewImplForTesting.

Also construct and use a cc::AnimationHost directly in the
platform/animation/ tests instead of a WebLayerTreeViewImplForTesting.

As the last user of it, we also remove the WebLayerTreeViewImplForTesting
class, bringing us closer to being able to remove the WebLayerTreeView
interface.

R=chrishtr@chromium.org

Bug: 838693
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ia92b0d6227575d1c8733a336c80e4a3aebb75001
Reviewed-on: https://chromium-review.googlesource.com/1117610
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571284}
[modify] https://crrev.com/b99858190e95d9a3149a71f6db6d0685f073d0fb/third_party/blink/renderer/core/BUILD.gn
[delete] https://crrev.com/4c2ee1dc602ae4e8e55af5cf0de11bec04188f76/third_party/blink/renderer/core/paint/layer_tree_host_for_paint_artifact_test.cc
[delete] https://crrev.com/4c2ee1dc602ae4e8e55af5cf0de11bec04188f76/third_party/blink/renderer/core/paint/layer_tree_host_for_paint_artifact_test.h
[modify] https://crrev.com/b99858190e95d9a3149a71f6db6d0685f073d0fb/third_party/blink/renderer/core/paint/paint_and_raster_invalidation_test.h
[modify] https://crrev.com/b99858190e95d9a3149a71f6db6d0685f073d0fb/third_party/blink/renderer/core/paint/stub_chrome_client_for_spv2.h
[modify] https://crrev.com/b99858190e95d9a3149a71f6db6d0685f073d0fb/third_party/blink/renderer/platform/BUILD.gn
[modify] https://crrev.com/b99858190e95d9a3149a71f6db6d0685f073d0fb/third_party/blink/renderer/platform/animation/compositor_animation_host_test.cc
[modify] https://crrev.com/b99858190e95d9a3149a71f6db6d0685f073d0fb/third_party/blink/renderer/platform/animation/compositor_animation_timeline_test.cc
[modify] https://crrev.com/b99858190e95d9a3149a71f6db6d0685f073d0fb/third_party/blink/renderer/platform/graphics/compositing/paint_artifact_compositor_test.cc
[modify] https://crrev.com/b99858190e95d9a3149a71f6db6d0685f073d0fb/third_party/blink/renderer/platform/graphics/graphics_layer_test.cc
[modify] https://crrev.com/b99858190e95d9a3149a71f6db6d0685f073d0fb/third_party/blink/renderer/platform/testing/compositor_test.h
[add] https://crrev.com/b99858190e95d9a3149a71f6db6d0685f073d0fb/third_party/blink/renderer/platform/testing/layer_tree_host_embedder.cc
[add] https://crrev.com/b99858190e95d9a3149a71f6db6d0685f073d0fb/third_party/blink/renderer/platform/testing/layer_tree_host_embedder.h
[delete] https://crrev.com/4c2ee1dc602ae4e8e55af5cf0de11bec04188f76/third_party/blink/renderer/platform/testing/web_layer_tree_view_impl_for_testing.cc
[delete] https://crrev.com/4c2ee1dc602ae4e8e55af5cf0de11bec04188f76/third_party/blink/renderer/platform/testing/web_layer_tree_view_impl_for_testing.h
Project Member

Comment 29 by bugdroid1@chromium.org, Jun 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f2b1f71f44c64550e3fbe00e1bca14cffe4b60b

commit 5f2b1f71f44c64550e3fbe00e1bca14cffe4b60b
Author: danakj <danakj@chromium.org>
Date: Fri Jun 29 18:20:40 2018

Remove WebLayerTreeView overrides in web_frame_test.cc

Use the standard RenderWidgetCompositor instead of test overrides of
the WebLayerTreeView interface. This gets us closer to removing the
interface, and removes a bunch of test-only lines of code, using the
standard FrameTestHelpers::TestWebViewClient instead, which provides
a RenderWidgetCompositor.

R=haraken@chromium.org

Bug: 838693
Change-Id: Ifc5f219f6918a793a46ec229667f43fa72ec4b03
Reviewed-on: https://chromium-review.googlesource.com/1119247
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571552}
[modify] https://crrev.com/5f2b1f71f44c64550e3fbe00e1bca14cffe4b60b/third_party/blink/renderer/core/exported/web_frame_test.cc
[modify] https://crrev.com/5f2b1f71f44c64550e3fbe00e1bca14cffe4b60b/third_party/blink/renderer/core/frame/frame_test_helpers.cc
[modify] https://crrev.com/5f2b1f71f44c64550e3fbe00e1bca14cffe4b60b/third_party/blink/renderer/core/frame/frame_test_helpers.h
Project Member

Comment 30 by bugdroid1@chromium.org, Jul 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6da4f138ccefccc641cdc28eb60622df779a1fc

commit e6da4f138ccefccc641cdc28eb60622df779a1fc
Author: danakj <danakj@chromium.org>
Date: Wed Jul 04 17:41:30 2018

blink: Use a real cc instance in SimTests.

The SimCompositor was mocking out all compositing with its own
implementation of WebLayerTreeView that only overrode a few
setter/getters and provided methods for tests to query state of the
"compositor" as well as a way to do a synchronous BeginMainFrame.

This makes SimCompositor own a RenderWidgetCompositor instead of
implementing WebLayerTreeView, making SimTests run a real composite
step instead of faking it out, and querying state from a real
compositor.

This uncovered that scrollbars are painting on throttled child frames
even though layout has not been done, which is pointless work and/or
problematic.

Platform::IsThreadedAnimationEnabled() was returning true in unit
tests with a synchronous compositor, and thus where threaded animations
do not in fact run. The RenderWidgetCompositor and SimCompositor used
to work around this by returning a null AnimationHost in this scenario.
Instead of production code having to deal with a null AnimationHost,
which is not clear about intent at all, we should make
IsThreadedAnimationEnabled() accurate.

A few changes were needed to make this happen:
1. An accessor on the compositor to tell if a main frame has been
requested.
2. An accessor on the compositor to tell if commits are deferred.
3. Scrollbars stop painting when their frame is throttled.
4. SimCompositor becomes a RenderWidgetCompositorDelegate, to make
a LayerTreeFrameSink and respond to BeginMainFrame.
5. SimCompositor::MainFrame() now asks the actual compositor to do
a synchronous Composite. It does so to the LayerTreeHost directly
in order to specify the "now" TickTicks.
6. Platform::IsThreadedCompositingEnabled() is dead, so goodbye.
7. Platform::IsThreadedAnimationEnabled() returns true, but is
overriden when appropriate in tests to be false (when synchronous
compositing is being used).
8. RenderWidgetCompositorFactory allows a test to specify a
delegate so that SimCompositor can be the delegate.

R=bokan@chromium.org, dcheng@chromium.org
TBR=piman

Bug: 838693
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I3486abd740874cb2403b5b54e596ddffd8a00bd0
Reviewed-on: https://chromium-review.googlesource.com/1125149
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572613}
[modify] https://crrev.com/e6da4f138ccefccc641cdc28eb60622df779a1fc/cc/animation/keyframe_effect.cc
[modify] https://crrev.com/e6da4f138ccefccc641cdc28eb60622df779a1fc/cc/test/fake_proxy.cc
[modify] https://crrev.com/e6da4f138ccefccc641cdc28eb60622df779a1fc/cc/test/fake_proxy.h
[modify] https://crrev.com/e6da4f138ccefccc641cdc28eb60622df779a1fc/cc/trees/layer_tree_host.cc
[modify] https://crrev.com/e6da4f138ccefccc641cdc28eb60622df779a1fc/cc/trees/layer_tree_host.h
[modify] https://crrev.com/e6da4f138ccefccc641cdc28eb60622df779a1fc/cc/trees/layer_tree_host_unittest.cc
[modify] https://crrev.com/e6da4f138ccefccc641cdc28eb60622df779a1fc/cc/trees/proxy.h
[modify] https://crrev.com/e6da4f138ccefccc641cdc28eb60622df779a1fc/cc/trees/proxy_main.cc
[modify] https://crrev.com/e6da4f138ccefccc641cdc28eb60622df779a1fc/cc/trees/proxy_main.h
[modify] https://crrev.com/e6da4f138ccefccc641cdc28eb60622df779a1fc/cc/trees/single_thread_proxy.cc
[modify] https://crrev.com/e6da4f138ccefccc641cdc28eb60622df779a1fc/cc/trees/single_thread_proxy.h
[modify] https://crrev.com/e6da4f138ccefccc641cdc28eb60622df779a1fc/content/renderer/gpu/compositor_dependencies.h
[modify] https://crrev.com/e6da4f138ccefccc641cdc28eb60622df779a1fc/content/renderer/render_thread_impl.h
[modify] https://crrev.com/e6da4f138ccefccc641cdc28eb60622df779a1fc/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/e6da4f138ccefccc641cdc28eb60622df779a1fc/content/renderer/renderer_blink_platform_impl.h
[modify] https://crrev.com/e6da4f138ccefccc641cdc28eb60622df779a1fc/content/test/fake_compositor_dependencies.cc
[modify] https://crrev.com/e6da4f138ccefccc641cdc28eb60622df779a1fc/content/test/fake_compositor_dependencies.h
[modify] https://crrev.com/e6da4f138ccefccc641cdc28eb60622df779a1fc/content/test/test_blink_web_unit_test_support.cc
[modify] https://crrev.com/e6da4f138ccefccc641cdc28eb60622df779a1fc/content/test/test_blink_web_unit_test_support.h
[modify] https://crrev.com/e6da4f138ccefccc641cdc28eb60622df779a1fc/third_party/blink/public/platform/platform.h
[modify] https://crrev.com/e6da4f138ccefccc641cdc28eb60622df779a1fc/third_party/blink/renderer/core/exported/web_view_impl.cc
[modify] https://crrev.com/e6da4f138ccefccc641cdc28eb60622df779a1fc/third_party/blink/renderer/core/frame/frame_test_helpers.cc
[modify] https://crrev.com/e6da4f138ccefccc641cdc28eb60622df779a1fc/third_party/blink/renderer/core/frame/frame_test_helpers.h
[modify] https://crrev.com/e6da4f138ccefccc641cdc28eb60622df779a1fc/third_party/blink/renderer/core/frame/root_frame_viewport.h
[modify] https://crrev.com/e6da4f138ccefccc641cdc28eb60622df779a1fc/third_party/blink/renderer/core/frame/root_frame_viewport_test.cc
[modify] https://crrev.com/e6da4f138ccefccc641cdc28eb60622df779a1fc/third_party/blink/renderer/core/frame/visual_viewport.h
[modify] https://crrev.com/e6da4f138ccefccc641cdc28eb60622df779a1fc/third_party/blink/renderer/core/frame/web_frame_widget_impl.cc
[modify] https://crrev.com/e6da4f138ccefccc641cdc28eb60622df779a1fc/third_party/blink/renderer/core/page/scrolling/scrolling_coordinator.cc
[modify] https://crrev.com/e6da4f138ccefccc641cdc28eb60622df779a1fc/third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
[modify] https://crrev.com/e6da4f138ccefccc641cdc28eb60622df779a1fc/third_party/blink/renderer/core/paint/paint_layer_scrollable_area.h
[modify] https://crrev.com/e6da4f138ccefccc641cdc28eb60622df779a1fc/third_party/blink/renderer/core/scheduler/frame_throttling_test.cc
[modify] https://crrev.com/e6da4f138ccefccc641cdc28eb60622df779a1fc/third_party/blink/renderer/core/testing/DEPS
[modify] https://crrev.com/e6da4f138ccefccc641cdc28eb60622df779a1fc/third_party/blink/renderer/core/testing/sim/sim_compositor.cc
[modify] https://crrev.com/e6da4f138ccefccc641cdc28eb60622df779a1fc/third_party/blink/renderer/core/testing/sim/sim_compositor.h
[modify] https://crrev.com/e6da4f138ccefccc641cdc28eb60622df779a1fc/third_party/blink/renderer/core/testing/sim/sim_test.cc
[modify] https://crrev.com/e6da4f138ccefccc641cdc28eb60622df779a1fc/third_party/blink/renderer/core/testing/sim/sim_web_view_client.cc
[modify] https://crrev.com/e6da4f138ccefccc641cdc28eb60622df779a1fc/third_party/blink/renderer/core/testing/sim/sim_web_view_client.h
[modify] https://crrev.com/e6da4f138ccefccc641cdc28eb60622df779a1fc/third_party/blink/renderer/platform/graphics/test/fake_scrollable_area.h
[modify] https://crrev.com/e6da4f138ccefccc641cdc28eb60622df779a1fc/third_party/blink/renderer/platform/scroll/scroll_animator_test.cc
[modify] https://crrev.com/e6da4f138ccefccc641cdc28eb60622df779a1fc/third_party/blink/renderer/platform/scroll/scrollable_area.h
[modify] https://crrev.com/e6da4f138ccefccc641cdc28eb60622df779a1fc/third_party/blink/renderer/platform/scroll/scrollbar_layer_delegate.cc
[modify] https://crrev.com/e6da4f138ccefccc641cdc28eb60622df779a1fc/third_party/blink/renderer/platform/scroll/scrollbar_test_suite.h
[modify] https://crrev.com/e6da4f138ccefccc641cdc28eb60622df779a1fc/third_party/blink/tools/audit_non_blink_usage.py
Project Member

Comment 31 by bugdroid1@chromium.org, Jul 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b34721074a88e8904a963c090702c257e3b5922

commit 4b34721074a88e8904a963c090702c257e3b5922
Author: danakj <danakj@chromium.org>
Date: Wed Jul 04 17:55:17 2018

Remove content dependencies from RenderWidgetCompositor.

This will allow us to move it to blink platform.

IsUseZoomForDSFEnabled() is moved to CompositorDependencies,
and all callsites in content/renderer/ are changed to use
the CompositorDependencies. RenderViewImpl tests are set up
to override CompositorDependencies instead of injecting
command lines into their process.

R=piman@chromium.org

Bug: 838693
Change-Id: Ibccc88af3460d33a092228b95c230ef0236ff408
Reviewed-on: https://chromium-review.googlesource.com/1125172
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572617}
[modify] https://crrev.com/4b34721074a88e8904a963c090702c257e3b5922/content/public/common/use_zoom_for_dsf_policy.h
[modify] https://crrev.com/4b34721074a88e8904a963c090702c257e3b5922/content/public/test/render_view_test.cc
[modify] https://crrev.com/4b34721074a88e8904a963c090702c257e3b5922/content/public/test/render_view_test.h
[modify] https://crrev.com/4b34721074a88e8904a963c090702c257e3b5922/content/renderer/gpu/compositor_dependencies.h
[modify] https://crrev.com/4b34721074a88e8904a963c090702c257e3b5922/content/renderer/gpu/queue_message_swap_promise_unittest.cc
[modify] https://crrev.com/4b34721074a88e8904a963c090702c257e3b5922/content/renderer/gpu/render_widget_compositor.cc
[modify] https://crrev.com/4b34721074a88e8904a963c090702c257e3b5922/content/renderer/gpu/render_widget_compositor.h
[modify] https://crrev.com/4b34721074a88e8904a963c090702c257e3b5922/content/renderer/gpu/render_widget_compositor_unittest.cc
[modify] https://crrev.com/4b34721074a88e8904a963c090702c257e3b5922/content/renderer/input/render_widget_input_handler.cc
[modify] https://crrev.com/4b34721074a88e8904a963c090702c257e3b5922/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/4b34721074a88e8904a963c090702c257e3b5922/content/renderer/render_thread_impl.h
[modify] https://crrev.com/4b34721074a88e8904a963c090702c257e3b5922/content/renderer/render_view_browsertest.cc
[modify] https://crrev.com/4b34721074a88e8904a963c090702c257e3b5922/content/renderer/render_view_impl.h
[modify] https://crrev.com/4b34721074a88e8904a963c090702c257e3b5922/content/renderer/render_widget.cc
[modify] https://crrev.com/4b34721074a88e8904a963c090702c257e3b5922/content/renderer/render_widget.h
[modify] https://crrev.com/4b34721074a88e8904a963c090702c257e3b5922/content/renderer/render_widget_fullscreen_pepper.cc
[modify] https://crrev.com/4b34721074a88e8904a963c090702c257e3b5922/content/renderer/render_widget_unittest.cc
[modify] https://crrev.com/4b34721074a88e8904a963c090702c257e3b5922/content/test/fake_compositor_dependencies.cc
[modify] https://crrev.com/4b34721074a88e8904a963c090702c257e3b5922/content/test/fake_compositor_dependencies.h
Project Member

Comment 32 by bugdroid1@chromium.org, Jul 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c98765663bd19ae20673899169a433f4c3d0f79

commit 4c98765663bd19ae20673899169a433f4c3d0f79
Author: danakj <danakj@chromium.org>
Date: Thu Jul 05 15:49:41 2018

Remove CompositorDeps from RenderWidgetCompositor.

The CompositorDeps are mostly used to set up the settings for the
compositor, without requiring a RenderThreadImpl in tests. Since
RenderWidget now does that setup, it is the primary consumer of
CompositorDeps, and most of them are not used in RenderWigetCompositor.
Rather than move the whole structure to blink, when mostly it is used
by RenderWidget in content, we pull out the few pieces that are used by
RenderWigetCompositor and pass those directly to its constructor.

Unit tests then create a cc::TestTaskGraphRunner and a
blink::scheduler::FakeRendererScheduler directly instead of a
getting them from a content::FakeCompositorDependencies.

R=haraken@chromium.org

Bug: 838693
Change-Id: I334dbb5d3f48ffe72ba21758427e9efe6589f965
Reviewed-on: https://chromium-review.googlesource.com/1126447
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572806}
[modify] https://crrev.com/4c98765663bd19ae20673899169a433f4c3d0f79/content/renderer/gpu/render_widget_compositor.cc
[modify] https://crrev.com/4c98765663bd19ae20673899169a433f4c3d0f79/content/renderer/gpu/render_widget_compositor.h
[modify] https://crrev.com/4c98765663bd19ae20673899169a433f4c3d0f79/content/renderer/gpu/render_widget_compositor_unittest.cc
[modify] https://crrev.com/4c98765663bd19ae20673899169a433f4c3d0f79/content/renderer/render_view_impl.cc
[modify] https://crrev.com/4c98765663bd19ae20673899169a433f4c3d0f79/content/renderer/render_widget.cc
[modify] https://crrev.com/4c98765663bd19ae20673899169a433f4c3d0f79/third_party/blink/renderer/core/frame/frame_test_helpers.cc
[modify] https://crrev.com/4c98765663bd19ae20673899169a433f4c3d0f79/third_party/blink/renderer/core/frame/frame_test_helpers.h
[modify] https://crrev.com/4c98765663bd19ae20673899169a433f4c3d0f79/third_party/blink/renderer/core/testing/sim/sim_compositor.h
Project Member

Comment 33 by bugdroid1@chromium.org, Jul 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6c10012f6b9d09f25830996b6f49b6b83156c98

commit a6c10012f6b9d09f25830996b6f49b6b83156c98
Author: danakj <danakj@chromium.org>
Date: Fri Jul 06 14:25:36 2018

content: Rename RenderWidgetCompositor to LayerTreeView

In preparation for moving this class into the blink public platform
so blink can use it without going through WebLayerTreeView, rename
the class to mimic the interface it will replace in blink.

https://chromium-review.googlesource.com/c/chromium/src/+/1126490 did
this move and the rename together, but this CL splits out the rename.

R=haraken@chromium.org
TBR=piman

Bug: 838693
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I7e436862e5f5cbbf6d77c8eea1954fd31ecd3276
Reviewed-on: https://chromium-review.googlesource.com/1127447
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572966}
[modify] https://crrev.com/a6c10012f6b9d09f25830996b6f49b6b83156c98/content/renderer/BUILD.gn
[modify] https://crrev.com/a6c10012f6b9d09f25830996b6f49b6b83156c98/content/renderer/gpu/gpu_benchmarking_extension.cc
[rename] https://crrev.com/a6c10012f6b9d09f25830996b6f49b6b83156c98/content/renderer/gpu/layer_tree_view.cc
[rename] https://crrev.com/a6c10012f6b9d09f25830996b6f49b6b83156c98/content/renderer/gpu/layer_tree_view.h
[rename] https://crrev.com/a6c10012f6b9d09f25830996b6f49b6b83156c98/content/renderer/gpu/layer_tree_view_delegate.h
[rename] https://crrev.com/a6c10012f6b9d09f25830996b6f49b6b83156c98/content/renderer/gpu/layer_tree_view_unittest.cc
[modify] https://crrev.com/a6c10012f6b9d09f25830996b6f49b6b83156c98/content/renderer/gpu/queue_message_swap_promise_unittest.cc
[modify] https://crrev.com/a6c10012f6b9d09f25830996b6f49b6b83156c98/content/renderer/input/frame_input_handler_impl.cc
[modify] https://crrev.com/a6c10012f6b9d09f25830996b6f49b6b83156c98/content/renderer/input/render_widget_input_handler.cc
[modify] https://crrev.com/a6c10012f6b9d09f25830996b6f49b6b83156c98/content/renderer/input/widget_input_handler_impl.cc
[modify] https://crrev.com/a6c10012f6b9d09f25830996b6f49b6b83156c98/content/renderer/input/widget_input_handler_manager.cc
[modify] https://crrev.com/a6c10012f6b9d09f25830996b6f49b6b83156c98/content/renderer/mus/renderer_window_tree_client.cc
[modify] https://crrev.com/a6c10012f6b9d09f25830996b6f49b6b83156c98/content/renderer/mus/renderer_window_tree_client.h
[modify] https://crrev.com/a6c10012f6b9d09f25830996b6f49b6b83156c98/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/a6c10012f6b9d09f25830996b6f49b6b83156c98/content/renderer/render_frame_impl.h
[modify] https://crrev.com/a6c10012f6b9d09f25830996b6f49b6b83156c98/content/renderer/render_frame_proxy.h
[modify] https://crrev.com/a6c10012f6b9d09f25830996b6f49b6b83156c98/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/a6c10012f6b9d09f25830996b6f49b6b83156c98/content/renderer/render_thread_impl.h
[modify] https://crrev.com/a6c10012f6b9d09f25830996b6f49b6b83156c98/content/renderer/render_view_browsertest.cc
[modify] https://crrev.com/a6c10012f6b9d09f25830996b6f49b6b83156c98/content/renderer/render_view_impl.cc
[modify] https://crrev.com/a6c10012f6b9d09f25830996b6f49b6b83156c98/content/renderer/render_view_impl_android.cc
[modify] https://crrev.com/a6c10012f6b9d09f25830996b6f49b6b83156c98/content/renderer/render_widget.cc
[modify] https://crrev.com/a6c10012f6b9d09f25830996b6f49b6b83156c98/content/renderer/render_widget.h
[modify] https://crrev.com/a6c10012f6b9d09f25830996b6f49b6b83156c98/content/renderer/render_widget_fullscreen_pepper.cc
[modify] https://crrev.com/a6c10012f6b9d09f25830996b6f49b6b83156c98/content/renderer/render_widget_unittest.cc
[modify] https://crrev.com/a6c10012f6b9d09f25830996b6f49b6b83156c98/content/test/BUILD.gn
[modify] https://crrev.com/a6c10012f6b9d09f25830996b6f49b6b83156c98/content/test/layouttest_support.cc
[add] https://crrev.com/a6c10012f6b9d09f25830996b6f49b6b83156c98/content/test/stub_layer_tree_view_delegate.cc
[rename] https://crrev.com/a6c10012f6b9d09f25830996b6f49b6b83156c98/content/test/stub_layer_tree_view_delegate.h
[delete] https://crrev.com/c097aa55ffe95c24bb91fdd13ccdb72ec1286250/content/test/stub_render_widget_compositor_delegate.cc
[modify] https://crrev.com/a6c10012f6b9d09f25830996b6f49b6b83156c98/third_party/blink/renderer/core/DEPS
[modify] https://crrev.com/a6c10012f6b9d09f25830996b6f49b6b83156c98/third_party/blink/renderer/core/exported/web_frame_test.cc
[modify] https://crrev.com/a6c10012f6b9d09f25830996b6f49b6b83156c98/third_party/blink/renderer/core/frame/frame_test_helpers.cc
[modify] https://crrev.com/a6c10012f6b9d09f25830996b6f49b6b83156c98/third_party/blink/renderer/core/frame/frame_test_helpers.h
[modify] https://crrev.com/a6c10012f6b9d09f25830996b6f49b6b83156c98/third_party/blink/renderer/core/testing/DEPS
[modify] https://crrev.com/a6c10012f6b9d09f25830996b6f49b6b83156c98/third_party/blink/renderer/core/testing/sim/sim_compositor.cc
[modify] https://crrev.com/a6c10012f6b9d09f25830996b6f49b6b83156c98/third_party/blink/renderer/core/testing/sim/sim_compositor.h
[modify] https://crrev.com/a6c10012f6b9d09f25830996b6f49b6b83156c98/third_party/blink/renderer/core/testing/sim/sim_test.cc
[modify] https://crrev.com/a6c10012f6b9d09f25830996b6f49b6b83156c98/third_party/blink/renderer/core/testing/sim/sim_web_view_client.cc
[modify] https://crrev.com/a6c10012f6b9d09f25830996b6f49b6b83156c98/third_party/blink/renderer/core/testing/sim/sim_web_view_client.h
[modify] https://crrev.com/a6c10012f6b9d09f25830996b6f49b6b83156c98/third_party/blink/renderer/platform/graphics/DEPS
Project Member

Comment 34 by bugdroid1@chromium.org, Jul 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/729a2f7ccc6b98773b381cbffafd10df865fd980

commit 729a2f7ccc6b98773b381cbffafd10df865fd980
Author: danakj <danakj@chromium.org>
Date: Tue Jul 10 17:40:35 2018

Use cc/gfx types instead of Web types in WebLayerTreeView

Replace and remove Web types from the WebLayerTreeView interface. Use
the cc and gfx types, that they were converted to in LayerTreeView,
directly.

R=haraken@chromium.org
TBR=piman

Bug: 838693
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I6a9cf8bf14721f7b9d8fd0448907c801c7131746
Reviewed-on: https://chromium-review.googlesource.com/1128188
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573796}
[modify] https://crrev.com/729a2f7ccc6b98773b381cbffafd10df865fd980/cc/input/browser_controls_offset_manager.cc
[modify] https://crrev.com/729a2f7ccc6b98773b381cbffafd10df865fd980/cc/input/browser_controls_offset_manager_unittest.cc
[modify] https://crrev.com/729a2f7ccc6b98773b381cbffafd10df865fd980/cc/input/browser_controls_state.h
[modify] https://crrev.com/729a2f7ccc6b98773b381cbffafd10df865fd980/cc/input/event_listener_properties.h
[modify] https://crrev.com/729a2f7ccc6b98773b381cbffafd10df865fd980/cc/trees/layer_tree_host.h
[modify] https://crrev.com/729a2f7ccc6b98773b381cbffafd10df865fd980/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/729a2f7ccc6b98773b381cbffafd10df865fd980/cc/trees/layer_tree_impl.h
[modify] https://crrev.com/729a2f7ccc6b98773b381cbffafd10df865fd980/content/renderer/gpu/gpu_benchmarking_extension.cc
[modify] https://crrev.com/729a2f7ccc6b98773b381cbffafd10df865fd980/content/renderer/gpu/layer_tree_view.cc
[modify] https://crrev.com/729a2f7ccc6b98773b381cbffafd10df865fd980/content/renderer/gpu/layer_tree_view.h
[modify] https://crrev.com/729a2f7ccc6b98773b381cbffafd10df865fd980/content/renderer/render_view_impl_android.cc
[modify] https://crrev.com/729a2f7ccc6b98773b381cbffafd10df865fd980/content/shell/renderer/layout_test/blink_test_runner.cc
[modify] https://crrev.com/729a2f7ccc6b98773b381cbffafd10df865fd980/third_party/blink/public/BUILD.gn
[delete] https://crrev.com/221b5244d97477a1e12b8e63d7766af91e83db4b/third_party/blink/public/platform/web_browser_controls_state.h
[delete] https://crrev.com/221b5244d97477a1e12b8e63d7766af91e83db4b/third_party/blink/public/platform/web_event_listener_properties.h
[modify] https://crrev.com/729a2f7ccc6b98773b381cbffafd10df865fd980/third_party/blink/public/platform/web_layer_tree_view.h
[delete] https://crrev.com/221b5244d97477a1e12b8e63d7766af91e83db4b/third_party/blink/public/platform/web_selection_bound.h
[modify] https://crrev.com/729a2f7ccc6b98773b381cbffafd10df865fd980/third_party/blink/public/web/DEPS
[delete] https://crrev.com/221b5244d97477a1e12b8e63d7766af91e83db4b/third_party/blink/public/web/web_selection.h
[modify] https://crrev.com/729a2f7ccc6b98773b381cbffafd10df865fd980/third_party/blink/public/web/web_widget.h
[modify] https://crrev.com/729a2f7ccc6b98773b381cbffafd10df865fd980/third_party/blink/renderer/core/DEPS
[modify] https://crrev.com/729a2f7ccc6b98773b381cbffafd10df865fd980/third_party/blink/renderer/core/editing/selection_controller.cc
[modify] https://crrev.com/729a2f7ccc6b98773b381cbffafd10df865fd980/third_party/blink/renderer/core/exported/BUILD.gn
[modify] https://crrev.com/729a2f7ccc6b98773b381cbffafd10df865fd980/third_party/blink/renderer/core/exported/web_frame_test.cc
[modify] https://crrev.com/729a2f7ccc6b98773b381cbffafd10df865fd980/third_party/blink/renderer/core/exported/web_page_popup_impl.cc
[delete] https://crrev.com/221b5244d97477a1e12b8e63d7766af91e83db4b/third_party/blink/renderer/core/exported/web_selection.cc
[modify] https://crrev.com/729a2f7ccc6b98773b381cbffafd10df865fd980/third_party/blink/renderer/core/exported/web_view_impl.cc
[modify] https://crrev.com/729a2f7ccc6b98773b381cbffafd10df865fd980/third_party/blink/renderer/core/exported/web_view_impl.h
[modify] https://crrev.com/729a2f7ccc6b98773b381cbffafd10df865fd980/third_party/blink/renderer/core/frame/browser_controls.cc
[modify] https://crrev.com/729a2f7ccc6b98773b381cbffafd10df865fd980/third_party/blink/renderer/core/frame/browser_controls.h
[modify] https://crrev.com/729a2f7ccc6b98773b381cbffafd10df865fd980/third_party/blink/renderer/core/frame/browser_controls_test.cc
[modify] https://crrev.com/729a2f7ccc6b98773b381cbffafd10df865fd980/third_party/blink/renderer/core/frame/event_handler_registry.cc
[modify] https://crrev.com/729a2f7ccc6b98773b381cbffafd10df865fd980/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/729a2f7ccc6b98773b381cbffafd10df865fd980/third_party/blink/renderer/core/frame/web_view_frame_widget.cc
[modify] https://crrev.com/729a2f7ccc6b98773b381cbffafd10df865fd980/third_party/blink/renderer/core/frame/web_view_frame_widget.h
[modify] https://crrev.com/729a2f7ccc6b98773b381cbffafd10df865fd980/third_party/blink/renderer/core/inspector/dev_tools_emulator.cc
[modify] https://crrev.com/729a2f7ccc6b98773b381cbffafd10df865fd980/third_party/blink/renderer/core/inspector/inspector_layer_tree_agent.cc
[modify] https://crrev.com/729a2f7ccc6b98773b381cbffafd10df865fd980/third_party/blink/renderer/core/loader/empty_clients.h
[modify] https://crrev.com/729a2f7ccc6b98773b381cbffafd10df865fd980/third_party/blink/renderer/core/loader/frame_loader.cc
[modify] https://crrev.com/729a2f7ccc6b98773b381cbffafd10df865fd980/third_party/blink/renderer/core/page/chrome_client.h
[modify] https://crrev.com/729a2f7ccc6b98773b381cbffafd10df865fd980/third_party/blink/renderer/core/page/chrome_client_impl.cc
[modify] https://crrev.com/729a2f7ccc6b98773b381cbffafd10df865fd980/third_party/blink/renderer/core/page/chrome_client_impl.h
[modify] https://crrev.com/729a2f7ccc6b98773b381cbffafd10df865fd980/third_party/blink/renderer/core/page/scrolling/scrolling_coordinator_test.cc
[modify] https://crrev.com/729a2f7ccc6b98773b381cbffafd10df865fd980/third_party/blink/renderer/core/paint/compositing/composited_selection.h
[modify] https://crrev.com/729a2f7ccc6b98773b381cbffafd10df865fd980/third_party/blink/renderer/platform/geometry/int_point.cc
[modify] https://crrev.com/729a2f7ccc6b98773b381cbffafd10df865fd980/third_party/blink/renderer/platform/geometry/int_point.h
[modify] https://crrev.com/729a2f7ccc6b98773b381cbffafd10df865fd980/third_party/blink/tools/audit_non_blink_usage.py

Comment 35 by dtapu...@chromium.org, Aug 30

Components: Internals>Compositing

Comment 36 by loyso@google.com, Sep 24 

Erase https://cs.chromium.org/chromium/src/third_party/blink/renderer/platform/animation/ abstractions as well? Their similar in essence to WebLayer and cc_blink.

Congrats, by the way. :)
►

Sign in to add a comment