[VR Browsing] Scroll to refresh isn't showing up |
|||||||||||
Issue descriptionChrome Version: 68.0.3415.0 OS: Android N Device: Pixel VRCore: 1.14.190701955 What steps will reproduce the problem? (1) Enter VR browsing (2) Go to any page, e.g. http://chrome-vr-test.appspot.com/ (3) Scroll to top of page and continue scrolling. What is the expected result? Scroll to refresh UI should appear and the page should refresh. What happens instead? The scroll to refresh UI doesn't appear and the page doesn't reload.
,
May 16 2018
,
May 30 2018
Bizarrely, pull to refresh works on navigation, like from the NTP to wikipedia, but stops working /sometimes/ when you scroll down on the page. Before I get any further into investigating I want to register a prediction that top controls are at fault ;)
,
Jun 4 2018
Issue 824829 has been merged into this issue.
,
Jun 7 2018
I WAS WRONG IT'S NOT TOP CONTROLS FOR ONCE
,
Jun 7 2018
,
Jun 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6f29d60a5f3c8d095274b9a92c45e45b9cdf839b commit 6f29d60a5f3c8d095274b9a92c45e45b9cdf839b Author: Michael Thiessen <mthiesse@chromium.org> Date: Thu Jun 07 22:59:19 2018 Re-enable overscroll glow for VR. Disabling overscroll glow in the way we did (in https://codereview.chromium.org/2632493005) caused pull-to-refresh to break. VR UX folks want overscroll glow anyways now, so let's just turn it back on and un-break pull-to-refresh. (Pull-to-refresh was broken because the overscroll controller wasn't receiving Animate calls, so when the glow got 'shown' it never animated away so the code thought it was always visible, and therefore prevented pull-to-refresh) Bug: 838679 Change-Id: I06fdbaadedfec702d43bf1915f3b05703da3d039 Reviewed-on: https://chromium-review.googlesource.com/1091658 Reviewed-by: Bo <boliu@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#565450} [modify] https://crrev.com/6f29d60a5f3c8d095274b9a92c45e45b9cdf839b/content/browser/renderer_host/render_widget_host_view_android.cc
,
Jun 11 2018
Looks good on Canary.
,
Jun 11 2018
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 13 2018
,
Jun 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5a05e29f929b26409a188d165683e7f7cca1f74b commit 5a05e29f929b26409a188d165683e7f7cca1f74b Author: Michael Thiessen <mthiesse@chromium.org> Date: Wed Jun 13 20:05:31 2018 Re-enable overscroll glow for VR. Disabling overscroll glow in the way we did (in https://codereview.chromium.org/2632493005) caused pull-to-refresh to break. VR UX folks want overscroll glow anyways now, so let's just turn it back on and un-break pull-to-refresh. (Pull-to-refresh was broken because the overscroll controller wasn't receiving Animate calls, so when the glow got 'shown' it never animated away so the code thought it was always visible, and therefore prevented pull-to-refresh) TBR=mthiesse@chromium.org (cherry picked from commit 6f29d60a5f3c8d095274b9a92c45e45b9cdf839b) Bug: 838679 Change-Id: I06fdbaadedfec702d43bf1915f3b05703da3d039 Reviewed-on: https://chromium-review.googlesource.com/1091658 Reviewed-by: Bo <boliu@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#565450} Reviewed-on: https://chromium-review.googlesource.com/1099724 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#345} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/5a05e29f929b26409a188d165683e7f7cca1f74b/content/browser/renderer_host/render_widget_host_view_android.cc
,
Jun 13 2018
,
Jun 27 2018
Verified in Chrome Beta 68.0.3440.40
,
Jun 27 2018
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by cjgrant@chromium.org
, May 16 2018Status: Available (was: Untriaged)