New issue
Advanced search Search tips

Issue 838671 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 2
Type: Bug



Sign in to add a comment

Migrate runner scripts from serial logging to loglistener

Project Member Reported by kmarshall@chromium.org, May 1 2018

Issue description

The runner scripts use a serial debugger feature of Zircon to access the kernel logs. They should be migrated to use loglistener instead.
 
Components: Internals>PlatformIntegration
Labels: -Pri-3 OS-Fuchsia Pri-2

Comment 2 by w...@chromium.org, May 1 2018

Labels: M-68
All P-1 and P-2 bugs should have an associated milestone, plz. :)

Comment 3 by w...@chromium.org, May 1 2018

Can we summarize what the benefit is of loglistener versus the serial debugger?
Sure.

* Debugging on devices requires something a hard debug UART connection to send and receive the bits. This is pretty cumbersome vs. using loglistener or the "dlog" command, which just communicate over network connection that the device already uses.
* Serial logging is a "legacy" feature on Zircon and might be subject to change.

Owner: kmarshall@chromium.org
Status: Assigned (was: Untriaged)
I picked this up and fixed it because fdegans@ is being seriously inconvenienced by the lack of automatically symbolized kernel logs right now.

https://chromium-review.googlesource.com/c/chromium/src/+/1038423

Comment 6 by w...@chromium.org, May 2 2018

Thanks for the clarification - FYI the "description" of bugs is now editable (see the little "Edit description" text in the title line, so you can put the context there after-the-fact, if you like, in future. :)
Project Member

Comment 7 by bugdroid1@chromium.org, May 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/299b84f8bdf74377b601a650b031e6dd0aa92bf1

commit 299b84f8bdf74377b601a650b031e6dd0aa92bf1
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Fri May 04 20:16:48 2018

Fuchsia: Get kernel logs over SSH and and symbolize their stack traces.

Serial kernel logging is a deprecated feature of Zircon and should not
be used anymore. This uses a long-running SSH invocation of "dlog"
to pull the logs over the wire. It works equally well on QEMU and on
devices.

Created a stream multiplexer using "poll" to merge the kernel log and
application log into a single stream, which is passed to the symbolizing
filter.

Modified the symbolizer regex rules to allow kernel log timestamps.
Kernel log timestamps can be omitted from the output, but they seem
to be helpful at visually distinguishing kernel output from app output.


Bug:  838671 
Change-Id: Icd45f902a49983b4e4ee262de474d69fbef56860
Reviewed-on: https://chromium-review.googlesource.com/1038423
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556170}
[modify] https://crrev.com/299b84f8bdf74377b601a650b031e6dd0aa92bf1/build/fuchsia/common_args.py
[modify] https://crrev.com/299b84f8bdf74377b601a650b031e6dd0aa92bf1/build/fuchsia/exe_runner.py
[modify] https://crrev.com/299b84f8bdf74377b601a650b031e6dd0aa92bf1/build/fuchsia/qemu_target.py
[modify] https://crrev.com/299b84f8bdf74377b601a650b031e6dd0aa92bf1/build/fuchsia/run_package.py
[modify] https://crrev.com/299b84f8bdf74377b601a650b031e6dd0aa92bf1/build/fuchsia/symbolizer.py
[modify] https://crrev.com/299b84f8bdf74377b601a650b031e6dd0aa92bf1/build/fuchsia/test_runner.py

Status: Fixed (was: Assigned)

Sign in to add a comment