New issue
Advanced search Search tips

Issue 838664 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 773928



Sign in to add a comment

Print Preview Componentization: Avoid unnecessary preview regeneration

Project Member Reported by rbpotter@chromium.org, May 1 2018

Issue description

Do not regenerate the preview when the margins type changes to custom since the margins value never actually changes in this case.
 
Blocking: 773928
Did the old Print Preview UI have this problem too?
Status: Fixed (was: Available)
No. This should now be fixed in the new UI also (just verified in Canary), forgot to mark it fixed.

They both do regenerate the preview when going from Custom margins back to a different type even if the value is the same. This is because Print Preview doesn't track the default or minimum margin values, so doesn't have any way to verify they match.

Sign in to add a comment