Remove dead dictionary checking code |
||
Issue descriptionIn, for example, https://cs.chromium.org/chromium/src/third_party/blink/renderer/modules/webaudio/iir_filter_node.cc?rcl=a3ffbd46d8a7667f14738fdf42796f344e3ced64&l=177 we check that the options dictionary has the required members. But the binding layer takes care of this for us so this code is essentially dead. Remove this dead code here and wherever else we're checking dictionary items that is already checked by the binding layer.
,
May 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/273cdb49969d456395639b98a05dfae3061a247b commit 273cdb49969d456395639b98a05dfae3061a247b Author: Raymond Toy <rtoy@chromium.org> Date: Fri May 04 21:25:11 2018 Remove checks for required members of dictionaries These checks aren't needed because the dictionary members are required so the binding layer makes sure they exist before reaching the code. Hence the checks are dead. Bug: 838636 Change-Id: I467639134a813346c8857726de78a463d0468057 Reviewed-on: https://chromium-review.googlesource.com/1038150 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#556201} [modify] https://crrev.com/273cdb49969d456395639b98a05dfae3061a247b/third_party/blink/renderer/modules/webaudio/iir_filter_node.cc [modify] https://crrev.com/273cdb49969d456395639b98a05dfae3061a247b/third_party/blink/renderer/modules/webaudio/media_element_audio_source_node.cc
,
May 8 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by rtoy@chromium.org
, May 2 2018Status: Started (was: Available)