New issue
Advanced search Search tips

Issue 838634 link

Starred by 3 users
Status: Untriaged
Owner: ----
Cc:
creis@chromium.org
dcheng@chromium.org
alex...@chromium.org
wfh@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Turn down Site Isolation Linux and Site Isolation Win bots

Project Member Reported by lukasza@chromium.org, May 1 2018 
site-per-process has been the default for more than a week now (see  issue 824966  and r552589).  Therefore Site Isolation Linux seems redundant now.  Site Isolation Win bots might also be redundant, but we might want to consider the following before turning it down:

- browser_tests, unit_tests and interactive_ui_tests, etc. have site-per-process coverage on the main waterfall.  not_site_per_process versions of these test suites are run on linux_chromium_rel_ng.  QUESTION: do we care about not_site_per_process_xxx on Windows?

- content_browsertests, content_unittests, layout tests, etc. have site-per-process coverage on linux_chromium_rel_ng.  QUESTION: do we care about site-per-process coverage of these test suites on Windows?

Comment 1 by creis@chromium.org, May 1 2018

Cc: dcheng@chromium.org
(To clarify the difference, site-per-process is only the default at the chrome/ layer, so content/ and Blink tests don't have it enabled by default.)

I'd say we would definitely like content/ test coverage on Windows, since sometimes tests get disabled on a single platform.  Not sure how platform-dependent layout tests are and if there's sufficient benefit to running layout tests with site-per-process on Windows as well.  dcheng@, your thoughts?

As for chrome/ test coverage without site-per-process, that's going to become less important over time.  I'm not sure I'd eliminate it entirely until Site Isolation has launched and stuck on Windows-- maybe it makes sense to have the Site Isolation Win FYI actually run the non-site-per-process tests for a bit longer and then turn it down when we're confident?  We don't want that path to rot in the meantime.
►

Sign in to add a comment