Issue metadata
Sign in to add a comment
|
[Cocoa] Bookmark icon mis-aligned with label |
||||||||||||||||||||||
Issue descriptionChrome Version: 68.0.3416.0 OS: 10.14 What steps will reproduce the problem? (1) Check bookmark icon and its label, they are not aligned (2) Hover over the bookmark button or folder, the highlight seems smaller and towards up The attached file showed what was wrong. What is the expected result? They should be aligned and the highlight surrounds it properly
,
May 2 2018
I think this is a regression and probably related to issue 838798 ?
,
May 2 2018
,
May 2 2018
I did a bisect. It is the same regression range like in issue 838798 . https://chromium.googlesource.com/chromium/src/+log/52134e2eadd49041f2087cc53f9cfb807ecdc7e9..9aed4f3692399b4ad59ae472367105db72e83896
,
May 2 2018
,
May 2 2018
Issue 838798 has been merged into this issue.
,
May 2 2018
,
May 2 2018
This is probably the same as issue 838856 . I assume this is Cocoa?
,
May 2 2018
Same root cause I mean. I increased the bookmarks bar height from 28dp to 32dp which was intended to increase the views version of the bookmarks bar but this constant is shared between both.
,
May 2 2018
Same root cause I mean. I increased the bookmarks bar height from 28dp to 32dp which was intended to increase the views version of the bookmarks bar but this constant is shared between both so it hit Cocoa as well, where it had different effects.
,
May 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c29efd57272886b45e3becd47976e31d9228d0a2 commit c29efd57272886b45e3becd47976e31d9228d0a2 Author: Wei Li <weili@chromium.org> Date: Thu May 03 16:32:09 2018 Create and use Cocoa specific layout constants As Views based UI is undergoing new changes, that applies to MacViews browser as well, but diverges from Cocoa based browser. This CL solves that problem by creating a function for Cocoa browser only. This function can get Cocoa specific constants which won't be affected by Views side of changes. BUG= 838630 , 838856 TEST=Pls make sure bookmark bar, icons and menus look ok for both Cocoa version and MacViews version on Mac. They should be same as before for other platforms. Change-Id: I73152c05cfac77eb6b24a4d6204acb78767c833d Reviewed-on: https://chromium-review.googlesource.com/1041141 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#555762} [modify] https://crrev.com/c29efd57272886b45e3becd47976e31d9228d0a2/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm [modify] https://crrev.com/c29efd57272886b45e3becd47976e31d9228d0a2/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm [modify] https://crrev.com/c29efd57272886b45e3becd47976e31d9228d0a2/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm [modify] https://crrev.com/c29efd57272886b45e3becd47976e31d9228d0a2/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm [modify] https://crrev.com/c29efd57272886b45e3becd47976e31d9228d0a2/chrome/browser/ui/cocoa/browser_window_cocoa.mm [modify] https://crrev.com/c29efd57272886b45e3becd47976e31d9228d0a2/chrome/browser/ui/layout_constants.cc [modify] https://crrev.com/c29efd57272886b45e3becd47976e31d9228d0a2/chrome/browser/ui/layout_constants.h
,
May 3 2018
,
May 4 2018
Thank you weili@ for the quick fix. Works fine for me again in latest Canary and in Cocoa-Mode :) |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by weili@chromium.org
, May 1 2018Status: Assigned (was: Untriaged)