New issue
Advanced search Search tips

Issue 838604 link

Starred by 2 users

Issue metadata

Status: Duplicate
Owner:
Closed: Aug 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

feature request: For swarmbucket builds, add a link to the swarming bot's page

Project Member Reported by bpastene@chromium.org, May 1 2018

Issue description

Swarmbucket builds in milo have a link from the build page to swarming task page. It'd be nice if it also had a link to the swarming bot's page. For failed/infra-failed builds, I find myself often questioning the health of the bot and will use the task link to navigate to the bot's page to examine it. It'd be totes dope if I could go straight from build page to bot page.
 

Comment 1 by no...@chromium.org, May 1 2018

this is very related to bug 629908 which is a feature request to add a first-class bot view, similar to Buildbot's bot view. The problem with this feature request is that it would take the user to the swarming-level (a lower level) bot view from which it is hard to get back to the Milo-level build view. Note that the "Milo output" tab in swarming page is a different implementation and may different from what milo's "build view" displays.
Owner: hinoka@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, May 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/129835d1fddb2631f4bd27430096243becef24b1

commit 129835d1fddb2631f4bd27430096243becef24b1
Author: Ryan Tseng <hinoka@google.com>
Date: Tue May 01 18:36:49 2018

[milo] Add swarming bot to builds

Bug:  838604 
Change-Id: If8cc6396c87b1b5c6daeb6391812bb49a95e91b5
Reviewed-on: https://chromium-review.googlesource.com/1037623
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>

[modify] https://crrev.com/129835d1fddb2631f4bd27430096243becef24b1/milo/buildsource/buildbucket/build.go

Status: Fixed (was: Started)
tiiiiight, thnx ryan
Status: Assigned (was: Fixed)
The bot link seems to have disappeared from builds:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20N5%20Swarm/10415

That WAI? I miss it :(
Cc: no...@chromium.org
It looks like it broke since buildbucket stopped serving task_results:

https://chromium-review.googlesource.com/c/infra/infra/+/1117830

There are a couple more places to get bot_id from though, including:
* swarming.bot_dimensions.id[1]
* properties.bot_id

nodir wdyt is better?  I'm leaning towards bot_dimensions.
Mergedinto: 862991
Status: Duplicate (was: Assigned)
Oh theres a bug already.

I'll try to fix this in the meantime, since the other bug seems to be blocked on buildbucket v2

Sign in to add a comment