[MacViews-Browser] Bookmark Bar Folder has no mouse-over highlight when you drag an item over it and the menu is open |
||||
Issue descriptionChrome Version: Version 68.0.3416.0 OS: macOS 10.12.6 What steps will reproduce the problem? (1) Enable MacViews-Browser (2) Drag a BMB-Item over a BMB-Folder, so that its menu opens (3) Take a look at the BMB-Folder item with the open menu What is the expected result? The BMB-Folder item should have an highlight-button, when the menu is open. What happens instead? It hasn't an highlight-button. Maybe this will be fixed with issue 795224 ? A screencast is attached. Thanks Mehmet
,
May 2 2018
[mac bug triage] Assigning to weili@ for investigation. Feel free to unassign and toss this back to the untriage queue
,
May 14 2018
started a couple days ago, forgot to update :)
,
May 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9dfac85deda1b8a9fe03d38f72a78a6e2b8b1dd5 commit 9dfac85deda1b8a9fe03d38f72a78a6e2b8b1dd5 Author: Wei Li <weili@chromium.org> Date: Tue May 22 17:48:13 2018 Highlight a menu when it is a drop target When a menu is open due to being dropped over, we should show it as highlighted to make the drop target clearer. This CL enables showing the highlight for such case, and when the menu is closed the menu should return to normal state. Highlighting the menu was implemented in Cocoa browser on Mac before, but not done for Views or other platforms. This CL will enable this feature for all Views based browser across platforms. BUG= 838598 Change-Id: I11ac21d03110598b122e1345e36cc2e16f47519b Reviewed-on: https://chromium-review.googlesource.com/1057964 Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#560692} [modify] https://crrev.com/9dfac85deda1b8a9fe03d38f72a78a6e2b8b1dd5/chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc [modify] https://crrev.com/9dfac85deda1b8a9fe03d38f72a78a6e2b8b1dd5/ui/views/controls/button/menu_button.cc [modify] https://crrev.com/9dfac85deda1b8a9fe03d38f72a78a6e2b8b1dd5/ui/views/controls/menu/menu_controller.cc
,
May 22 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by meh...@chromium.org
, May 1 2018