New issue
Advanced search Search tips

Issue 838597 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 837684



Sign in to add a comment

Remove mus test suites from the bots

Project Member Reported by jamescook@chromium.org, May 1 2018

Issue description

We're either going to:
* Run the window service code as a library, or
* Use Wayland for window service functionality

Either way, we're not going to be running window service code in a background thread anymore. Turn off the bots that test this config.

 
Test suites to remove:

testing/buildbot/test_suites.pyl:    'mus_ash_unittests'
testing/buildbot/test_suites.pyl:    'mus_browser_tests'
testing/buildbot/test_suites.pyl:    'mus_content_unittests'
testing/buildbot/test_suites.pyl:    'mus_content_browsertests'
testing/buildbot/test_suites.pyl:    'mus_unit_tests'
testing/buildbot/test_suites.pyl:    'views_mus_unittests'
testing/buildbot/test_suites.pyl:    'views_mus_interactive_ui_tests'

We should also remove the C++ test suite runner code, unless it is also being used for mash.

Project Member

Comment 2 by bugdroid1@chromium.org, May 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e821229d6746050ffa1e10fe492366de0f28118

commit 3e821229d6746050ffa1e10fe492366de0f28118
Author: James Cook <jamescook@chromium.org>
Date: Tue May 01 23:14:51 2018

cros: Remove mus test suites from CQ and waterfalls

The mustash team is deprecating the current implementation of mus mode
(mojo window service on a background thread in the browser process).
We don't need to test this configuration any more.

Later CLs will clean up the test suite C++ code.

Bug:  838597 
Change-Id: I1198adcb6e105f3c326f47356b5551221663ad0f
Reviewed-on: https://chromium-review.googlesource.com/1037663
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555220}
[modify] https://crrev.com/3e821229d6746050ffa1e10fe492366de0f28118/ash/README.md
[modify] https://crrev.com/3e821229d6746050ffa1e10fe492366de0f28118/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/3e821229d6746050ffa1e10fe492366de0f28118/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/3e821229d6746050ffa1e10fe492366de0f28118/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/3e821229d6746050ffa1e10fe492366de0f28118/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/3e821229d6746050ffa1e10fe492366de0f28118/testing/buildbot/test_suites.pyl

Blocking: 837684
Motivation for this work is  issue 837684 : Create standalone library providing server implementation of WindowService on top of aura
Project Member

Comment 4 by bugdroid1@chromium.org, May 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/857c8ad01793fe91143441c7aff1f98b03e5ac4c

commit 857c8ad01793fe91143441c7aff1f98b03e5ac4c
Author: James Cook <jamescook@chromium.org>
Date: Mon May 07 06:51:22 2018

chromiumos-overlay: Remove desktopui_MusLogin test

We don't use the --enable-features=Mus flag on chrome anymore
because we're switching to using the window service (mus) as a
library.

BUG= chromium:838597 
TEST=autotest

Change-Id: Id746c4d43ab1c66b07abfd13ac0a823387c07759
Reviewed-on: https://chromium-review.googlesource.com/1045468
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: James Cook <jamescook@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>

[modify] https://crrev.com/857c8ad01793fe91143441c7aff1f98b03e5ac4c/chromeos-base/autotest-chrome/autotest-chrome-9999.ebuild

Project Member

Comment 5 by bugdroid1@chromium.org, May 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/d5fc13b1de12c7aa5dfe2cfe24feee4025a9336d

commit d5fc13b1de12c7aa5dfe2cfe24feee4025a9336d
Author: James Cook <jamescook@chromium.org>
Date: Mon May 07 16:38:01 2018

autotest: Remove desktopui_MusLogin test

We don't use the --enable-features=Mus flag on chrome anymore
because we're switching to using the window service (mus) as a
library.

BUG= chromium:838597 
TEST=autotest
Change-Id: I8933ac6b6fca4894f242b7d3fe725ac8d3391eba
Reviewed-on: https://chromium-review.googlesource.com/1045447
Tested-by: James Cook <jamescook@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Trybot-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Commit-Queue: James Cook <jamescook@chromium.org>

[delete] https://crrev.com/9d3b7548b013268516203f86027f535ece4f4056/client/site_tests/desktopui_MusLogin/desktopui_MusLogin.py
[delete] https://crrev.com/9d3b7548b013268516203f86027f535ece4f4056/client/site_tests/desktopui_MusLogin/control

Project Member

Comment 6 by bugdroid1@chromium.org, May 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/486d9648340dba93063798cc535ccad5955cfe4e

commit 486d9648340dba93063798cc535ccad5955cfe4e
Author: James Cook <jamescook@chromium.org>
Date: Tue May 08 17:44:21 2018

Remove feature flag kMus / Mus

For mustash we are building the window service code into ash as a
library. Remove the switch that ran the window service code as a
separate mojo service.

Bug:  838597 
Test: bots
Change-Id: Ibf76fc2616a221a04776a955ef134b43a1b90bfe
Reviewed-on: https://chromium-review.googlesource.com/1048945
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556860}
[modify] https://crrev.com/486d9648340dba93063798cc535ccad5955cfe4e/ash/public/cpp/ash_switches.cc
[modify] https://crrev.com/486d9648340dba93063798cc535ccad5955cfe4e/ash/public/cpp/ash_switches.h
[modify] https://crrev.com/486d9648340dba93063798cc535ccad5955cfe4e/ash/public/cpp/config.h
[modify] https://crrev.com/486d9648340dba93063798cc535ccad5955cfe4e/ash/shell.cc
[modify] https://crrev.com/486d9648340dba93063798cc535ccad5955cfe4e/ash/test/ash_test_suite.cc
[modify] https://crrev.com/486d9648340dba93063798cc535ccad5955cfe4e/chrome/browser/about_flags.cc
[modify] https://crrev.com/486d9648340dba93063798cc535ccad5955cfe4e/chrome/browser/chromeos/ash_config.cc
[modify] https://crrev.com/486d9648340dba93063798cc535ccad5955cfe4e/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/486d9648340dba93063798cc535ccad5955cfe4e/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/486d9648340dba93063798cc535ccad5955cfe4e/components/printing/service/pdf_compositor_service.cc
[modify] https://crrev.com/486d9648340dba93063798cc535ccad5955cfe4e/content/browser/browser_main_loop.cc
[modify] https://crrev.com/486d9648340dba93063798cc535ccad5955cfe4e/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/486d9648340dba93063798cc535ccad5955cfe4e/content/browser/oop_browsertest.cc
[modify] https://crrev.com/486d9648340dba93063798cc535ccad5955cfe4e/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/486d9648340dba93063798cc535ccad5955cfe4e/content/browser/renderer_host/render_widget_host_view_child_frame.cc
[modify] https://crrev.com/486d9648340dba93063798cc535ccad5955cfe4e/content/browser/service_manager/common_browser_interfaces.cc
[modify] https://crrev.com/486d9648340dba93063798cc535ccad5955cfe4e/content/browser/service_manager/service_manager_context.cc
[modify] https://crrev.com/486d9648340dba93063798cc535ccad5955cfe4e/content/ppapi_plugin/ppapi_thread.cc
[modify] https://crrev.com/486d9648340dba93063798cc535ccad5955cfe4e/content/renderer/browser_plugin/browser_plugin.cc
[modify] https://crrev.com/486d9648340dba93063798cc535ccad5955cfe4e/content/renderer/mus/renderer_window_tree_client.cc
[modify] https://crrev.com/486d9648340dba93063798cc535ccad5955cfe4e/content/renderer/render_frame_proxy.cc
[modify] https://crrev.com/486d9648340dba93063798cc535ccad5955cfe4e/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/486d9648340dba93063798cc535ccad5955cfe4e/content/renderer/render_widget.cc
[modify] https://crrev.com/486d9648340dba93063798cc535ccad5955cfe4e/services/ui/service.h
[modify] https://crrev.com/486d9648340dba93063798cc535ccad5955cfe4e/ui/aura/test/aura_test_suite_setup.cc
[modify] https://crrev.com/486d9648340dba93063798cc535ccad5955cfe4e/ui/base/ui_base_features.cc
[modify] https://crrev.com/486d9648340dba93063798cc535ccad5955cfe4e/ui/base/ui_base_features.h
[modify] https://crrev.com/486d9648340dba93063798cc535ccad5955cfe4e/ui/base/ui_features.gni
[modify] https://crrev.com/486d9648340dba93063798cc535ccad5955cfe4e/ui/ozone/platform/drm/host/drm_device_connector.cc
[modify] https://crrev.com/486d9648340dba93063798cc535ccad5955cfe4e/ui/ozone/platform/drm/host/drm_gpu_platform_support_host.cc

Status: Fixed (was: Started)

Sign in to add a comment