New issue
Advanced search Search tips

Issue 838595 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----



Sign in to add a comment

mash_ash_unittests failing on chromium.memory/Linux Chromium OS ASan LSan Tests (1)

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, May 1 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of nednguyen@google.com

mash_ash_unittests failing on chromium.memory/Linux Chromium OS ASan LSan Tests (1)

Builders failed on: 
- Linux Chromium OS ASan LSan Tests (1): 
  https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29

Failing test is SplitViewWindowSelectorTest.DragToClose



 
Labels: -Pri-2 Pri-1
Owner: sammiequon@chromium.org
Status: Assigned (was: Available)
The revert https://chromium-review.googlesource.com/c/chromium/src/+/1036937 seems to have merge conflict. Assign to CL owner to fix this.
Cc: -nedngu...@google.com
Project Member

Comment 3 by bugdroid1@chromium.org, May 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d52a786549ed36ca97892e14d3897970cd3e92bb

commit d52a786549ed36ca97892e14d3897970cd3e92bb
Author: Sammie Quon <sammiequon@google.com>
Date: Tue May 01 17:33:44 2018

Add correct tests in mash filter.

TBR=xdai@chromium.org

Bug:  838595 
Change-Id: Id52791d046d79780b89a011f8e9cad466b572bfb
Reviewed-on: https://chromium-review.googlesource.com/1037586
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555092}
[modify] https://crrev.com/d52a786549ed36ca97892e14d3897970cd3e92bb/testing/buildbot/filters/mash.ash_unittests.filter

Now WorkspaceLayoutManagerBackdropTest.OpenAppListInOverviewMode is failing. Can you disable that test to Sammie?
i assigned  bug 838822  to minch, looks like she found a fix without disabling that test
Project Member

Comment 6 by bugdroid1@chromium.org, May 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c177375eaedbf86e248c409c53f7cb2d82cc2958

commit c177375eaedbf86e248c409c53f7cb2d82cc2958
Author: Min Chen <minch@google.com>
Date: Wed May 02 21:15:20 2018

Fix WorkspaceLayoutManagerBackdropTest.OpenAppListInOverviewMode test
crash in mash.

Add RunAllPendingInMessageLoop to make it happy in mash.

Bug:  838595 ,  837092 
Change-Id: Ib5fbd2857c41fc4de3254b6f31a4bb6809864d76
Reviewed-on: https://chromium-review.googlesource.com/1040533
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555538}
[modify] https://crrev.com/c177375eaedbf86e248c409c53f7cb2d82cc2958/ash/wm/workspace/workspace_layout_manager_unittest.cc

Comment 7 by treib@chromium.org, May 3 2018

Labels: -Sheriff-Chromium
Components: Internals>Services>Ash
Status: Fixed (was: Assigned)

Sign in to add a comment