Omnibox Dropdown Results are no longer truncated |
|||||
Issue descriptionChrome Version: Version 68.0.3416.0 OS: macOS 10.12.6 What steps will reproduce the problem? (1) Enable MacViews-Browser (2) Type something into the Omnibox, so that the Dropdown appears (3) What is the expected result? The results in the Dropdown should be truncated. What happens instead? They are not truncated. Screenshots are attached.
,
May 1 2018
Not MacViews specific. I can reproduce on Linux as well. Dave, I'm speculatively sending it over to you to see if the Views refactors could have caused this? Just a question. If not, feel free to send it back. Thanks!
,
May 1 2018
CL at https://chromium-review.googlesource.com/c/chromium/src/+/1038618
,
May 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b116a6d0e5b256577c2cc298c6d8a1c254ac14a8 commit b116a6d0e5b256577c2cc298c6d8a1c254ac14a8 Author: Dave Schuyler <dschuyler@chromium.org> Date: Wed May 02 18:35:28 2018 [Omnibox] Fix ellipses and remove description when it doesn't fit This CL passes the correct available width to ComputeMatchMaxWidths so that the text get an ellipsis if needed. Also, the description view will not be shown if there is no space for it. Bug: 836740 , 838592 Change-Id: I096fddd1191dfb61f1cd008e4b81a79bd718d1f2 Reviewed-on: https://chromium-review.googlesource.com/1038618 Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#555482} [modify] https://crrev.com/b116a6d0e5b256577c2cc298c6d8a1c254ac14a8/chrome/browser/ui/views/omnibox/omnibox_match_cell_view.cc
,
May 2 2018
,
May 3 2018
Tested the issue on chrome build# 68.0.3417.0(build without fix) and chrome build# 68.0.3418.0(build with fix) using Mac 10.12.6 and Ubuntu 14.04 and observations are as follows: For Mac: -> Enabled MacViews-Browser on chrome build# 68.0.3418.0 and types in Omnibox, the results in Omnibox didn't get truncated, it shows the last word continuing with three dots(...), where as in chrome build# 68.0.3417.0, the results in drop-down get truncated For Linux: -> Without enabling the MacViews-Browser flag, on chrome build 68.0.3418.0, the results in Omnibox didn't get truncated, it shows the last word continuing with three dots(...) and in chrome build# 68.0.3417.0, the results in drop-down get truncated @Dave Schuyler: Please find the above observations and help us in verifying the fix from TE end. Thanks! |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by ellyjo...@chromium.org
, May 1 2018Labels: M-68 MacViews-Browser Target-68
Owner: tommycli@chromium.org
Status: Assigned (was: Untriaged)