New issue
Advanced search Search tips

Issue 838588 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Crash in blink::TextOffsetMapping::TextOffsetMapping

Project Member Reported by ClusterFuzz, May 1 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4503947008802816

Fuzzer: bj_broddelwerk
Job Type: linux_msan_content_shell_drt
Platform Id: linux

Crash Type: UNKNOWN READ
Crash Address: 0x00040000010d
Crash State:
  blink::TextOffsetMapping::TextOffsetMapping
  blink::TextOffsetMapping::TextOffsetMapping
  blink::NextWordPosition
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=linux_msan_content_shell_drt&range=550102:550107

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4503947008802816

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Components: Blink
Labels: M-67 Pri-1
Owner: yosin@chromium.org
Status: Assigned (was: Untriaged)
Guessing https://chromium.googlesource.com/chromium/src/+/1324be868df000cb2e070199ce2d10cd0c5a2706 based on regression range

Comment 2 by rtoy@chromium.org, May 1 2018

Components: -Blink Blink>Editing
Project Member

Comment 3 by sheriffbot@chromium.org, May 2 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: xiaoche...@chromium.org
Hi xiaochengh@ - mind taking a look while Tokyo base folk are out?
Owner: yosin@chromium.org
awhalley@: This crash is due to a re-architecting (using the newly introduced class TextOffsetMapping to find word boundaries).

There are on-going patches fixing these cases. See https://chromium-review.googlesource.com/q/owner:yosin+status:open

We will either get them fixed or hide them again by M68 branch.
*** Bulk Edit ***
M67 Stable promotion is coming soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. 

If fix is already merged to M67 and nothing else is pending, pls mark the bug as fixed. Thank you.
xiaochengh@ thanks for the details. Though the regression here was found in 67, which has of course already branched and is going stable soon, so we need action before M68 branch.
*** Bulk Edit ***
M67 Stable promotion is coming VERY soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. 

If fix is already merged to M67 and nothing else is pending, pls mark the bug as fixed. Thank you.

Comment 9 by yosin@chromium.org, May 9 2018

Components: Blink>Editing>Selection
Status: Started (was: Assigned)
Components: -Blink>Editing
Labels: -M-67 M-68
Revert on M67 branch, crrev.com/c/1013445
I'm working for M68 now.

Comment 11 by yosin@chromium.org, May 10 2018

Status: Fixed (was: Started)
http://crrev.com/c/1018923 should fix this issue.
Project Member

Comment 12 by ClusterFuzz, May 10 2018

ClusterFuzz has detected this issue as fixed in range 557408:557410.

Detailed report: https://clusterfuzz.com/testcase?key=4503947008802816

Fuzzer: bj_broddelwerk
Job Type: linux_msan_content_shell_drt
Platform Id: linux

Crash Type: UNKNOWN READ
Crash Address: 0x00040000010d
Crash State:
  blink::TextOffsetMapping::TextOffsetMapping
  blink::TextOffsetMapping::TextOffsetMapping
  blink::NextWordPosition
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=linux_msan_content_shell_drt&range=550102:550107
Fixed: https://clusterfuzz.com/revisions?job=linux_msan_content_shell_drt&range=557408:557410

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4503947008802816

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 13 by ClusterFuzz, May 10 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 4503947008802816 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 14 by sheriffbot@chromium.org, May 10 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -ReleaseBlock-Stable
Project Member

Comment 16 by sheriffbot@chromium.org, Aug 16

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment