Launching installed PWA cause OS crash if chrome://flags#top-chrome-md is set to "Refresh" |
|||||||
Issue description
Chrome Version : 67.0.3396.26 (Official Build) dev (64-bit)
URLs (if applicable) :
Other browsers tested:
Add OK or FAIL, along with the version, after other browsers where you
have tested this issue:
Safari: N/A
Firefox: N/A
Edge: N/A
What steps will reproduce the problem?
(1) Install a PWA on a chromebook (tested on pixelbook)
(2) Change flag chrome://flags#top-chrome-md to "Refresh" (to get smaller UI of browser)
(3) Try to launch an installed PWA
What is the expected result?
PWA launches
What happens instead?
ChromeOS "reboots" - sessions are still logged in, but screen turns black and all applications are closed.
Please provide any additional information below. Attach a screenshot if
possible.
- I've tried this with a) The installed PWA of Santa tracker, and b) A "PWA this page" version of Gmail. Both showed the same behaviour.
- Changing the flag to "Hybrid" resolved the problem and kept the smaller UI that I was looking for.
,
May 2 2018
Sounds like something we might have fixed recently. Alan can you confirm. Also it would be great to know the crash report ID. You can look it up at chrome://crashes
,
May 2 2018
This is a new one. Ty for the report.
,
May 2 2018
Able to repro on Linux chromeOS build with --top-chrome-md=material-refresh flag. Received signal 11 SEGV_MAPERR 000000000100 #0 0x7f76ded986fc base::debug::StackTrace::StackTrace() #1 0x7f76ded981f1 base::debug::(anonymous namespace)::StackDumpSignalHandler() #2 0x7f76dee530c0 <unknown> #3 0x55b3a707600d BrowserActionsContainer::Layout() #4 0x7f76d90b0bd2 views::BoxLayout::Layout() #5 0x7f76d90bf430 views::View::Layout() #6 0x7f76d90bd815 views::View::BoundsChanged() #7 0x7f76d90bce05 views::View::SetBoundsRect() #8 0x7f76d90b0bd2 views::BoxLayout::Layout() #9 0x7f76d90bf430 views::View::Layout() #10 0x7f76d8966996 ash::FrameCaptionButtonContainerView::Layout() #11 0x7f76d90bd815 views::View::BoundsChanged() #12 0x7f76d90bce05 views::View::SetBoundsRect() #13 0x7f76d90bccee views::View::SetBounds() #14 0x7f76d896bb2d ash::DefaultFrameHeader::LayoutHeader() #15 0x55b3a7238642 BrowserNonClientFrameViewAsh::Layout() #16 0x7f76d90bccee views::View::SetBounds() #17 0x7f76d90d77db views::NonClientView::Layout() #18 0x7f76d90cb77a views::Widget::Init() #19 0x55b3a71c75df BrowserFrame::InitBrowserFrame() #20 0x55b3a7041a95 BrowserWindow::CreateBrowserWindow() #21 0x55b3a6ed2d0d Browser::Browser() #22 0x55b3a70c5205 OpenApplicationWindow() #23 0x55b3a70c4a6a (anonymous namespace)::OpenEnabledApplication() #24 0x55b3a6f7a6d7 LauncherControllerHelper::LaunchApp() #25 0x55b3a7140955 AppShortcutLauncherItemController::ItemSelected()
,
May 2 2018
,
May 2 2018
Here are a few crash ID's that were triggered by this problem, in case you need them: * 372771d8b2e6e623 * 631251581efda7ae * 0b9328ee74f7ebaa
,
May 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9cf9c0c56edce812ea5cf934aff4bbc7d571c9b6 commit 9cf9c0c56edce812ea5cf934aff4bbc7d571c9b6 Author: Alan Cutter <alancutter@chromium.org> Date: Thu May 03 00:19:45 2018 Fix crash when opening hosted app windows on Chrome OS with material refresh enabled This CL adds a null check to BrowserActionsContainer::Layout() and updates browser_non_client_frame_view_ash_browsertest.cc to cover --top-chrome-md=material-refresh. The existing HostedAppNonClientFrameViewAshTest.BrowserActions test catches this crash with the material-refresh flag enabled. Bug: 838581 Change-Id: I263b3cd3551a3171f5acc010c1c99f0daef47998 Reviewed-on: https://chromium-review.googlesource.com/1039209 Reviewed-by: Allen Bauer <kylixrd@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#555625} [modify] https://crrev.com/9cf9c0c56edce812ea5cf934aff4bbc7d571c9b6/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc [modify] https://crrev.com/9cf9c0c56edce812ea5cf934aff4bbc7d571c9b6/chrome/browser/ui/views/toolbar/browser_actions_container.cc
,
May 3 2018
,
May 29 2018
Issue 846516 has been merged into this issue. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by susan.boorgula@chromium.org
, May 1 2018