New issue
Advanced search Search tips

Issue 838578 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Clean up Form-Not-Secure feature

Project Member Reported by est...@chromium.org, May 1 2018

Issue description

We decided not to launch the Form-Not-Secure feature, so we should clean up the code.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e537ff96abf69922783053954f5f5d6b0dd4598

commit 0e537ff96abf69922783053954f5f5d6b0dd4598
Author: Emily Stark <estark@google.com>
Date: Fri May 04 23:34:19 2018

Clean up Form-Not-Secure feature

We decided not to launch in-form warnings for nonsecure forms, so this cleans up
the implementation.

Bug:  838578 
Change-Id: I43a8d6e4efb8dbc63826a4880f2b086dc70286bf
Reviewed-on: https://chromium-review.googlesource.com/1036288
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556251}
[modify] https://crrev.com/0e537ff96abf69922783053954f5f5d6b0dd4598/chrome/browser/about_flags.cc
[modify] https://crrev.com/0e537ff96abf69922783053954f5f5d6b0dd4598/chrome/browser/autofill/autofill_interactive_uitest.cc
[modify] https://crrev.com/0e537ff96abf69922783053954f5f5d6b0dd4598/chrome/browser/site_per_process_interactive_browsertest.cc
[modify] https://crrev.com/0e537ff96abf69922783053954f5f5d6b0dd4598/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc
[modify] https://crrev.com/0e537ff96abf69922783053954f5f5d6b0dd4598/chrome/browser/ui/autofill/autofill_popup_layout_model.cc
[modify] https://crrev.com/0e537ff96abf69922783053954f5f5d6b0dd4598/chrome/browser/ui/autofill/autofill_popup_layout_model.h
[modify] https://crrev.com/0e537ff96abf69922783053954f5f5d6b0dd4598/chrome/browser/ui/autofill/autofill_popup_layout_model_unittest.cc
[modify] https://crrev.com/0e537ff96abf69922783053954f5f5d6b0dd4598/chrome/browser/ui/autofill/chrome_autofill_client.cc
[modify] https://crrev.com/0e537ff96abf69922783053954f5f5d6b0dd4598/chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm
[modify] https://crrev.com/0e537ff96abf69922783053954f5f5d6b0dd4598/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc
[modify] https://crrev.com/0e537ff96abf69922783053954f5f5d6b0dd4598/chrome/browser/ui/views/autofill/autofill_popup_view_native_views_unittest.cc
[modify] https://crrev.com/0e537ff96abf69922783053954f5f5d6b0dd4598/chrome/browser/ui/views/autofill/autofill_popup_view_views.cc
[modify] https://crrev.com/0e537ff96abf69922783053954f5f5d6b0dd4598/chrome/renderer/autofill/fake_content_password_manager_driver.cc
[modify] https://crrev.com/0e537ff96abf69922783053954f5f5d6b0dd4598/chrome/renderer/autofill/fake_content_password_manager_driver.h
[modify] https://crrev.com/0e537ff96abf69922783053954f5f5d6b0dd4598/components/autofill/content/common/autofill_driver.mojom
[modify] https://crrev.com/0e537ff96abf69922783053954f5f5d6b0dd4598/components/autofill/content/renderer/autofill_agent.cc
[modify] https://crrev.com/0e537ff96abf69922783053954f5f5d6b0dd4598/components/autofill/content/renderer/autofill_agent.h
[modify] https://crrev.com/0e537ff96abf69922783053954f5f5d6b0dd4598/components/autofill/content/renderer/password_autofill_agent.cc
[modify] https://crrev.com/0e537ff96abf69922783053954f5f5d6b0dd4598/components/autofill/content/renderer/password_autofill_agent.h
[modify] https://crrev.com/0e537ff96abf69922783053954f5f5d6b0dd4598/components/autofill/content/renderer/renderer_save_password_progress_logger_unittest.cc
[modify] https://crrev.com/0e537ff96abf69922783053954f5f5d6b0dd4598/components/autofill/core/browser/autofill_external_delegate.cc
[modify] https://crrev.com/0e537ff96abf69922783053954f5f5d6b0dd4598/components/autofill/core/browser/autofill_external_delegate_unittest.cc
[modify] https://crrev.com/0e537ff96abf69922783053954f5f5d6b0dd4598/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/0e537ff96abf69922783053954f5f5d6b0dd4598/components/autofill/core/browser/autofill_manager_unittest.cc
[modify] https://crrev.com/0e537ff96abf69922783053954f5f5d6b0dd4598/components/autofill/core/browser/autofill_metrics_unittest.cc
[modify] https://crrev.com/0e537ff96abf69922783053954f5f5d6b0dd4598/components/autofill/core/browser/popup_item_ids.h
[modify] https://crrev.com/0e537ff96abf69922783053954f5f5d6b0dd4598/components/autofill_strings.grdp
[modify] https://crrev.com/0e537ff96abf69922783053954f5f5d6b0dd4598/components/password_manager/content/browser/content_password_manager_driver.cc
[modify] https://crrev.com/0e537ff96abf69922783053954f5f5d6b0dd4598/components/password_manager/content/browser/content_password_manager_driver.h
[modify] https://crrev.com/0e537ff96abf69922783053954f5f5d6b0dd4598/components/password_manager/core/browser/password_autofill_manager.cc
[modify] https://crrev.com/0e537ff96abf69922783053954f5f5d6b0dd4598/components/password_manager/core/browser/password_autofill_manager.h
[modify] https://crrev.com/0e537ff96abf69922783053954f5f5d6b0dd4598/components/password_manager/core/browser/password_autofill_manager_unittest.cc
[modify] https://crrev.com/0e537ff96abf69922783053954f5f5d6b0dd4598/components/password_manager/core/browser/password_manager_metrics_util.cc
[modify] https://crrev.com/0e537ff96abf69922783053954f5f5d6b0dd4598/components/password_manager/core/browser/password_manager_metrics_util.h
[modify] https://crrev.com/0e537ff96abf69922783053954f5f5d6b0dd4598/components/security_state/core/security_state.cc
[modify] https://crrev.com/0e537ff96abf69922783053954f5f5d6b0dd4598/components/security_state/core/security_state.h
[modify] https://crrev.com/0e537ff96abf69922783053954f5f5d6b0dd4598/tools/metrics/actions/actions.xml
[modify] https://crrev.com/0e537ff96abf69922783053954f5f5d6b0dd4598/tools/metrics/histograms/histograms.xml

Labels: M-68
Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d54c3199e689a7dfbbccd5943e75eb7f9947dc1d

commit d54c3199e689a7dfbbccd5943e75eb7f9947dc1d
Author: Eric Lawrence <elawrence@chromium.org>
Date: Tue Dec 18 17:17:10 2018

Remove vestigial traces of Form-Not-Secure experiment

The Form Not Secure experiment never launched and was removed,
but two strings and a header definition were left behind. This
change removes them.

BUG= 838578 

Change-Id: Iea4a16df8f68cee45846794f5631c38368a9f7bf
Reviewed-on: https://chromium-review.googlesource.com/c/1381611
Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Commit-Queue: Eric Lawrence <elawrence@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617541}
[modify] https://crrev.com/d54c3199e689a7dfbbccd5943e75eb7f9947dc1d/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/d54c3199e689a7dfbbccd5943e75eb7f9947dc1d/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/d54c3199e689a7dfbbccd5943e75eb7f9947dc1d/components/security_state/core/security_state.h

Project Member

Comment 4 by bugdroid1@chromium.org, Dec 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e8cc63df8c8fad24e0d1ba5631148c5c9b8f23e

commit 2e8cc63df8c8fad24e0d1ba5631148c5c9b8f23e
Author: Eric Lawrence <elawrence@chromium.org>
Date: Tue Dec 18 20:20:36 2018

Remove three obsoleted experiments from fieldtrial config

Three experiements are no longer present in Chromium but are still
listed in the fieldtrial configuration. Remove

 1. HTTP Not Secure in-form warnings
 2. Dino-game birthday mode
 3. Security Chip animation

Bug:  838578 ,846473
Change-Id: I1cbfc2c28fff01ed81e67fd6481876ecab82aade
Reviewed-on: https://chromium-review.googlesource.com/c/1382705
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Eric Lawrence <elawrence@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617602}
[modify] https://crrev.com/2e8cc63df8c8fad24e0d1ba5631148c5c9b8f23e/testing/variations/fieldtrial_testing_config.json

Sign in to add a comment