Issue metadata
Sign in to add a comment
|
History: Add centered Loading Indicator |
||||||||||||||||||||||
Issue descriptionAdd centered Loading Indicator, add and MDC UIActivity indicator in the center (as in Bookmarks) for when the data is being loaded.
,
May 9 2018
The NextAction date has arrived: 2018-05-09
,
Jun 13 2018
,
Jun 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/22065f24bafe9322eb6404fe412eb6e38616ddb7 commit 22065f24bafe9322eb6404fe412eb6e38616ddb7 Author: sczs@chromium.org <sczs@chromium.org> Date: Thu Jun 14 02:19:19 2018 [ios] Creates TableViewLoadingView, adds it to HistoryTableVC. - Creates TableViewLoadingView, which is added as a backgroundView of ChromeTableVC. - HistoryTableVC adds this TableViewLoadingView instead of implementing its own. - Re-adds searching property to HistoryTableVC. Screenshot: https://drive.google.com/open?id=1gXnkLADyKrv3hqtijU7Su9t8gW0hR7el Bug: 838577 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id494826f4bd522062f7d30bf4c6e7e81ceba6370 Reviewed-on: https://chromium-review.googlesource.com/1041187 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#567095} [modify] https://crrev.com/22065f24bafe9322eb6404fe412eb6e38616ddb7/ios/chrome/browser/ui/history/history_table_view_controller.mm [modify] https://crrev.com/22065f24bafe9322eb6404fe412eb6e38616ddb7/ios/chrome/browser/ui/history/history_ui_egtest.mm [modify] https://crrev.com/22065f24bafe9322eb6404fe412eb6e38616ddb7/ios/chrome/browser/ui/table_view/BUILD.gn [modify] https://crrev.com/22065f24bafe9322eb6404fe412eb6e38616ddb7/ios/chrome/browser/ui/table_view/chrome_table_view_controller.h [modify] https://crrev.com/22065f24bafe9322eb6404fe412eb6e38616ddb7/ios/chrome/browser/ui/table_view/chrome_table_view_controller.mm [add] https://crrev.com/22065f24bafe9322eb6404fe412eb6e38616ddb7/ios/chrome/browser/ui/table_view/table_view_loading_view.h [add] https://crrev.com/22065f24bafe9322eb6404fe412eb6e38616ddb7/ios/chrome/browser/ui/table_view/table_view_loading_view.mm
,
Jun 14 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by sczs@chromium.org
, May 1 2018Status: Started (was: Assigned)