New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 838572 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

RenderFrame is initialized before WebLocalFrame in CreateChildFrame

Project Member Reported by jkarlin@chromium.org, May 1 2018

Issue description

Creating a child frame results in the RenderFrame initializing (and creating RenderFrameObservers) before the LocalFrame has been created. That doesn't happen when creating the main frame or provisional frames.

Today's CreateChildFrame:

LocalFrameClientImpl::CreateFrame
  . WebLocalFrameImpl::CreateChildFrame
    . RenderFrameImpl::CreateChildFrame
      . child_render_frame->Initialize
    . child_web_local_frame->InitializeCoreFrame


I propose that we create a new WebFrameClient::InitializeFrame function so that we have the following:

LocalFrameClientImpl::CreateFrame
  . WebLocalFrameImpl::CreateChildFrame
    . RenderFrameImpl::CreateChildFrame
    . child_web_local_frame->InitializeCoreFrame()
    . child_client->InitializeFrame()


 
Status: WontFix (was: Started)
By initializing the WebLocalFrame before the RenderFrameObservers, the observers miss some of the early messages from WebLocalFrame, like the creation of the about:blank document. Seems risky to change that so I'm abandoning this.

Sign in to add a comment