New issue
Advanced search Search tips

Issue 838570 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-05-04
OS: Linux
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Can not longer search for stock tickers

Reported by chrisinc...@gmail.com, May 1 2018

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.181 Safari/537.36

Steps to reproduce the problem:
1. In address bar type stock ticker like nasdaq:goog
2. Press enter

What is the expected behavior?
Google search opens with google stock ticker

What went wrong?
Chrome attempts to open a device called nasdaq

Did this work before? Yes v66

Chrome version: 67.0.3396.18 (Official Build) beta (64-bit)  Channel: beta
OS Version: Mint 18
Flash Version: Shockwave Flash 29.0 r0
 
Labels: Needs-Bisect Needs-Triage-M67
Components: -UI UI>Browser>Omnibox
Components: UI>Browser>Navigation
Labels: -Pri-2 -Needs-Bisect ReleaseBlock-Stable Triaged-ET Target-68 M-67 Target-67 FoundIn-67 RegressedIn-67 hasbisect FoundIn-68 Pri-1
Owner: davidbienvenu@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on reported version 67.0.3396.18 and latest chrome 68.0.3416.0 using Ubuntu 14.04, for per-revision bisect got perf build error, hence providing chromium bisect info
Note: Issue is not seen on Mac and Windows
Bisect Info:
================
Good build: 67.0.3393.0
Bad build: 67.0.3394.0

You are probably looking for a change made after 549603 (known good), but no later than 549607 (first known bad).
https://chromium.googlesource.com/chromium/src/+log/3fa650bf8b19336ebb3e6748296bb060df592442..6fcc593c5778cabefd4ea1eeaaacedb14dc8eba0
Suspecting: https://chromium.googlesource.com/chromium/src/+/6fcc593c5778cabefd4ea1eeaaacedb14dc8eba0
Reviewed-on: https://chromium-review.googlesource.com/966896

@David Bienvenu: Please confirm the issue and help in re-assigning if it is not related to your change.
Adding ReleaseBlock-Stable as it is seems a recent break, feel free to remove it if not applicable.

Thanks!
Cc: thomasanderson@chromium.org
It's certainly related to my change - nasdaq:goog looks like a url scheme. On linux, we don't have a mechanism for telling if it really is a scheme or not, which is why this only happens on linux. Perhaps the best approach would be to not do this on Linux, and go back to the previous behavior of always defaulting to search; cc'ing thomasanderson@ for his input.
Always defaulting to search on Linux sgtm.  I also ran into this issue recently when typing "define:word" into the search bar expecting to have the dictionary definition of "word" brought up.
*** Bulk Edit ***
M67 Stable promotion is coming soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. 

If fix is already merged to M67 and nothing else is pending, pls mark the bug as fixed. Thank you.
Project Member

Comment 7 by bugdroid1@chromium.org, May 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bedfe9fc6251abcd690b8b048f59c21ced9800a0

commit bedfe9fc6251abcd690b8b048f59c21ced9800a0
Author: David Bienvenu <davidbienvenu@chromium.org>
Date: Thu May 03 18:50:25 2018

Fix Linux omnibox handling of text with schemes

Fixes a regression in Linux handling of omnibox text like dict:word.
Regression caused omnibox to default to treating it as a url. This
CL makes Linux default to treating it as search text.

Regression introduced in https://chromium-review.googlesource.com/c/chromium/src/+/966896

Bug:  838570 
Change-Id: I26be4279605ded6e3aed4e631f503e2b60551283
Reviewed-on: https://chromium-review.googlesource.com/1040881
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555829}
[modify] https://crrev.com/bedfe9fc6251abcd690b8b048f59c21ced9800a0/chrome/browser/autocomplete/chrome_autocomplete_scheme_classifier.cc

Labels: Merge-Request-67
This is a low risk fix, basically reverting to the previous behavior on Linux.
NextAction: 2018-05-04
Pls update the bug after verifying on canary. We don't have canary for Linux but you will be able to verify on daily M68 build which gets trigger at 8:00 PM PT.
🙂 Great work thanks all
Labels: TE-Verified-M68 TE-Verified-68.0.3419.0
Able to reproduce this issue on Ubuntu 14.04 on the reported version 67.0.3396.18 and the issue is fixed on the latest Canary 68.0.3419.0 as per the original comment.

When entering nasdaq:goog in omnibox, google stock ticker is opened.
Attached is the screen shot for reference.

Hence adding TE verified labels as the fix is working as intended.

Thanks..
838570-M68.png
232 KB View Download
The NextAction date has arrived: 2018-05-04
thx - I also tried it on the latest Chromium build on linux and the fix is working as expected.
Labels: -Merge-Request-67 Merge-Approved-67
Approving merge to M67 branch 3396 based on comments #9, #12 and #14. Pls merge ASAP.

Pls mark the bug as fixed if nothing else is pending after the merge. Thank you.
Project Member

Comment 16 by bugdroid1@chromium.org, May 4 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ef6adb502db9be0e649235b31723b70415a5398

commit 2ef6adb502db9be0e649235b31723b70415a5398
Author: David Bienvenu <davidbienvenu@chromium.org>
Date: Fri May 04 17:27:35 2018

Fix Linux omnibox handling of text with schemes

Fixes a regression in Linux handling of omnibox text like dict:word.
Regression caused omnibox to default to treating it as a url. This
CL makes Linux default to treating it as search text.

Regression introduced in https://chromium-review.googlesource.com/c/chromium/src/+/966896

Bug:  838570 
Change-Id: I26be4279605ded6e3aed4e631f503e2b60551283
Reviewed-on: https://chromium-review.googlesource.com/1040881
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#555829}(cherry picked from commit bedfe9fc6251abcd690b8b048f59c21ced9800a0)
Reviewed-on: https://chromium-review.googlesource.com/1044405
Cr-Commit-Position: refs/branch-heads/3396@{#479}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/2ef6adb502db9be0e649235b31723b70415a5398/chrome/browser/autocomplete/chrome_autocomplete_scheme_classifier.cc

Status: Fixed (was: Assigned)
pbos was kind enough to land this for me - marking fixed.
Labels: TE-Verified-M67 TE-Verified-67.0.3396.40
Able to reproduce this issue on Ubuntu 17.10 on the reported version 67.0.3396.18 and the issue is fixed on the latest M-67 build 67.0.3396.40 as per the original comment.

When entering nasdaq:goog in omnibox, google stock ticker is opened.
Attached is the screen shot for reference.

Hence adding TE verified labels as the fix is working as intended.

Thanks..
838570-M67.png
570 KB View Download

Sign in to add a comment