New issue
Advanced search Search tips

Issue 838561 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature

Blocking:
issue 690202



Sign in to add a comment

System Information Preview should support Copy and Search

Project Member Reported by tnagel@chromium.org, May 1 2018

Issue description

Chrome Version: 65.0.3325.209 (Official Build) (64-bit)
OS: Chrome (I didn't check other platforms)

What steps will reproduce the problem?
(1) Hit Alt+Shift+I
(2) Click "system and app information"
--> System Information Preview shows
(3) Ctrl-F or Ctrl-A

What is the expected result?
Text should be searchable and copyable.

What happens instead?
Text isn't searchable and copyable.


Ahmed, I've copied you because I saw your name in the git log of feedback.js -- may I ask you to take a look?
 
Rationale: The preview is a huge wall of text. Search seems necessary for meaningful review by users. And copy seems relevant so that users may keep a record of what they sent to Google.
Cc: -afakhry@chromium.org weifangsun@chromium.org glevin@chromium.org
Labels: -Type-Bug Type-Feature
Owner: afakhry@chromium.org
Status: Assigned (was: Untriaged)
+weifangsun@ as the owner PM of the Feedback app. Making the contents of the System Info window copy-able can be done if it's OK from a privacy standpoint +glevin. However, adding a search bar is a UI change and although it can be done now, it'd be better to incorporate it with a future redesign of the app UI.
Blocking: 690202
Personally, I think this is a privacy improvement.  The current "wall of text" is near impenetrable to the average user.  The ability to search or copy the text would make the info much more usable, and help users better discern what we're sending in feedback reports.  Also, tnagel@ has a lot of privacy wisdom, so generally if he requests it, it's probably okay privacy-wise :-)
Thanks Ahmed and Greg! :)

I think restoring copy functionality (ideally in conjunction with "select all", i.e. Ctrl+A Ctrl+C) would go a long way. It remember being able to copy the contents a while back.
You can copy and search the contents if you go to chrome://system. The contents are essentially the same, although the feedback info may contain a bit more data, and its contents are scrubbed of any PII.
Thanks! A user might be explicitly interested in observing the effect of that scrubbing...
Project Member

Comment 8 by bugdroid1@chromium.org, May 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95043ec454d90c98c9882935340c4fb7211d472b

commit 95043ec454d90c98c9882935340c4fb7211d472b
Author: Ahmed Fakhry <afakhry@google.com>
Date: Wed May 02 20:58:59 2018

Make contents of the Feedback sys info window selectable and copyable

BUG=838561

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7c4874880c80706327d97cbf86cef54c940abd6b
Reviewed-on: https://chromium-review.googlesource.com/1040348
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555509}
[modify] https://crrev.com/95043ec454d90c98c9882935340c4fb7211d472b/chrome/browser/resources/feedback/css/sys_info.css

The contents are now selectable and copyable on ToT.
Thanks a lot! I guess it makes sense to keep the bug open for the remaining search part?
Yes, agreed.
Labels: Hotlist-PrivacyLiaison
Labels: -Hotlist-PrivacyLiaison Hotlist-Privacy-Followup

Sign in to add a comment