New issue
Advanced search Search tips

Issue 838545 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Omnibox: Focus on omnibox, clears some URLs

Project Member Reported by edwardjung@chromium.org, May 1 2018

Issue description

Chrome Version: (copy from chrome://version)
OS: MacOS 68.0.3410.0 

What steps will reproduce the problem?
(1) chrome://flags/#omnibox-ui-hide-steady-state-url-scheme-and-subdomains enabled
(2) Go to: https://bugs.chromium.org/p/chromium/issues/list
(3) Click in the omnibox

What is the expected result?
URL is selected.

What happens instead?
URL is cleared from the omnibox, the suggestions list is displayed.

Only certain URLs are affected. For example google.com works per normal

Other test URLs
- https://www.cyclerevolutionfestival.com/
- https://developer.mozilla.org/en-US/


I've turned on MacViews too, so this could be the problem. I couldn't reproduce on Windows or CrOS.

 
focus-hides-URL-bug.mov
450 KB View Download
focus-hides-URL-bug.gif
2.2 MB View Download
drive-by: likely has to do with zero suggest
Status: Assigned (was: Untriaged)
 Issue 841570  has been merged into this issue.
I've been experiencing this as well. Forgot I had this flag enabled for a few minutes.

It seems to happen more often for me on double-click. I don't know whether I've seen it on single-click.
Labels: -Pri-2 M-68 OS-Linux Pri-1
Thank you for c#4. I wasn't able to reproduce this before. 

I can now reproduce this with the double-click on both Linux and Mac.
Project Member

Comment 6 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b614de5808201edc2755712bc41848b4bc101adb

commit b614de5808201edc2755712bc41848b4bc101adb
Author: Tommy C. Li <tommycli@chromium.org>
Date: Wed May 16 02:10:09 2018

Omnibox UI Experiments: Steady State Elisions - Fix clear on ZeroSuggest

There's a bug where if the user double-clicks fast on a segment of the
elided URL, before the ZeroSuggest popup has a chance to popup, the
Omnibox will be cleared when the popup comes up.

This is because we were not properly updating the OmniboxEditModel's
user_text_ string when we unelided the URL. This CL fixes that.

Bug:  838545 ,  797354 
Change-Id: I55f69cd912243494f55b5e00a45d94b1ea01a221
Reviewed-on: https://chromium-review.googlesource.com/1056387
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558927}
[modify] https://crrev.com/b614de5808201edc2755712bc41848b4bc101adb/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
[modify] https://crrev.com/b614de5808201edc2755712bc41848b4bc101adb/chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc
[modify] https://crrev.com/b614de5808201edc2755712bc41848b4bc101adb/components/omnibox/browser/omnibox_edit_model.h

Status: Fixed (was: Assigned)
Should be fixed now.
Issue 843457 has been merged into this issue.
Fix should be in versions 3433.0 and later.
Verified this issue on Chrome #68.0.3436.0 and didn't observe the issue on Mac 10.13, Windows 10 and Debian Rodete.

Thanks!

Sign in to add a comment