elf_reader_linux_unittest.cc fails on the android asan bot |
|||
Issue descriptionhttps://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.clang%2FToTAndroidASan%2F762%2F%2B%2Frecipes%2Fsteps%2Fbase_unittests%2F0%2Fstdout C 128.565s Main [FAIL] ElfReaderTest.ReadElfLibraryName: C 128.565s Main [ RUN ] ElfReaderTest.ReadElfLibraryName C 128.565s Main ../../base/debug/elf_reader_linux_unittest.cc:64: Failure C 128.565s Main Expected equality of these values: C 128.565s Main kLibraryName C 128.565s Main Which is: "lib_base_unittests__library.so" C 128.565s Main *name C 128.565s Main Which is: "lib_base_unittests__library.cr.so" C 128.565s Main Stack trace: C 128.565s Main C 128.565s Main [ FAILED ] ElfReaderTest.ReadElfLibraryName (18 ms) C 128.565s Main [----------] 1 test from ElfReaderTest (18 ms total) C 128.565s Main C 128.565s Main [----------] Global test environment tear-down C 128.565s Main [==========] 1 test from 1 test case ran. (19 ms total) C 128.565s Main [ PASSED ] 0 tests. C 128.565s Main [ FAILED ] 1 test, listed below: C 128.565s Main [ FAILED ] ElfReaderTest.ReadElfLibraryName afaik so files have always been called .cr.so in Android builds (agrieve, is that true)? So we probably just need to fix the expectation on Android? Oh, it's new here: https://chromium.googlesource.com/chromium/src/+/b7b4a541dc81ed20a32d086c23d57889e74ab1e4%5E%21/#F3 It has an android ifdef, but apparently that's wrong? Maybe it's not always .cr.so?
,
May 1 2018
,
May 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c4b57166775e1047348dca26640d783bc559e20 commit 0c4b57166775e1047348dca26640d783bc559e20 Author: Siddhartha <ssid@chromium.org> Date: Tue May 01 22:57:09 2018 Fix ElfReaderTest.ReadElfLibraryName on android component builds Android component builds have .cr.so in library names. Make the test for library name less strict by checking only for substring match. BUG= 838544 Change-Id: If7958fdc70e8429e93aff098fcb8baca2ff6c456 Reviewed-on: https://chromium-review.googlesource.com/1038228 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#555212} [modify] https://crrev.com/0c4b57166775e1047348dca26640d783bc559e20/base/debug/elf_reader_linux_unittest.cc
,
May 1 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by thestig@chromium.org
, May 1 2018