CrSettingsMetricsReportingTest.All, CrSettingsPersonalizationOptionsTest.OfficialBuild fail in official builds |
|||||
Issue descriptione.g. on https://ci.chromium.org/buildbot/chromium.clang/ToTWin64/1397 , https://ci.chromium.org/buildbot/chromium.clang/ToTWin/1445 The .All test started here: https://ci.chromium.org/buildbot/chromium.clang/ToTWin/1423 So that's due to https://chromium.googlesource.com/chromium/src/+/526c72543e40d1ea182f9c6db1db7490cdbb4293 [ RUN ] CrSettingsMetricsReportingTest.All [4472:4848:0427/191527.661:WARNING:discovery_network_list_win.cc(195)] Failed to open Wlan client handle: 1062 [4472:1788:0427/191527.669:WARNING:chrome_browser_main_win.cc(630)] Command line too long for RegisterApplicationRestart: --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=CrSettingsMetricsReportingTest.All --single_process --test-launcher-bot-mode --test-launcher-output="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir3056_12697\results3056_15310\test_results.xml" --test-launcher-summary-output="e:\b\swarm_slave\w\iof4cw43\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir3056_12697\d3056_22553" --disable-offline-auto-reload --enable-blink-features=MojoJSTest --no-first-run --no-default-browser-check --enable-logging=stderr --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --ipc-connection-timeout=30 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --disable-compositor-ukm-for-tests --enable-features=TestFeatureForBrowserTest1 --disable-features=NetworkPrediction,TestFeatureForBrowserTest2 --flag-switches-begin --flag-switches-end --restore-last-session about:blank [4472:1788:0427/191528.530:INFO:CONSOLE(1225)] "Running TestCase CrSettingsMetricsReportingTest.All", source: file:///E:/b/swarm_slave/w/ir/chrome/test/data/webui/test_api.js (1225) [4472:1788:0427/191528.765:ERROR:CONSOLE(48)] "Mocha test failed: metrics reporting changes to whether metrics reporting is enabled/managed TypeError: Cannot read property 'checked' of undefined at file:///E:/b/swarm_slave/w/ir/chrome/test/data/webui/settings/metrics_reporting_tests.js:26:71 ", source: file:///E:/b/swarm_slave/w/ir/chrome/test/data/webui/mocha_adapter.js (48) [4472:1788:0427/191528.802:ERROR:CONSOLE(48)] "Mocha test failed: metrics reporting metrics reporting restart button AssertionError: expected false to be true at Function.assert.isTrue (file:///E:/b/swarm_slave/w/ir/third_party/chaijs/chai.js:2423:31) at assertTrue (file:///E:/b/swarm_slave/w/ir/chrome/test/data/webui/test_api.js:853:17) at file:///E:/b/swarm_slave/w/ir/chrome/test/data/webui/settings/metrics_reporting_tests.js:86:7 ", source: file:///E:/b/swarm_slave/w/ir/chrome/test/data/webui/mocha_adapter.js (48) [4472:1788:0427/191528.805:ERROR:web_ui_test_handler.cc(82)] Test Errors: 2/2 tests had failed assertions. [4472:1788:0427/191528.805:ERROR:web_ui_browser_test.cc(475)] CONDITION FAILURE: encountered javascript console error(s): [4472:1788:0427/191528.805:ERROR:web_ui_browser_test.cc(477)] JS ERROR: '[4472:1788:0427/191528.765:ERROR:CONSOLE(48)] "Mocha test failed: metrics reporting changes to whether metrics reporting is enabled/managed TypeError: Cannot read property 'checked' of undefined at file:///E:/b/swarm_slave/w/ir/chrome/test/data/webui/settings/metrics_reporting_tests.js:26:71 ", source: file:///E:/b/swarm_slave/w/ir/chrome/test/data/webui/mocha_adapter.js (48) ' [4472:1788:0427/191528.805:ERROR:web_ui_browser_test.cc(477)] JS ERROR: '[4472:1788:0427/191528.802:ERROR:CONSOLE(48)] "Mocha test failed: metrics reporting metrics reporting restart button AssertionError: expected false to be true at Function.assert.isTrue (file:///E:/b/swarm_slave/w/ir/third_party/chaijs/chai.js:2423:31) at assertTrue (file:///E:/b/swarm_slave/w/ir/chrome/test/data/webui/test_api.js:853:17) at file:///E:/b/swarm_slave/w/ir/chrome/test/data/webui/settings/metrics_reporting_tests.js:86:7 ", source: file:///E:/b/swarm_slave/w/ir/chrome/test/data/webui/mocha_adapter.js (48) ' [4472:1788:0427/191528.805:ERROR:web_ui_browser_test.cc(479)] JS call assumed failed, because JS console error(s) found. gen/chrome/test/data/webui/settings/cr_settings_browsertest-gen.cc(2833): error: Value of: RunJavascriptTestF( true, "CrSettingsMetricsReportingTest", "All") Actual: false Expected: true Stack trace: Backtrace: StackTraceGetter::CurrentStackTrace [0x017A62F8+40] testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop [0x017AEF71+69] testing::internal::AssertHelper::operator= [0x017AEBD6+48] CrSettingsMetricsReportingTest_All_Test::RunTestOnMainThread [0x0175E1D8+680] content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x02DFC395+357] ChromeBrowserMainParts::PreMainMessageLoopRunImpl [0x03388172+3300] ChromeBrowserMainParts::PreMainMessageLoopRun [0x033873D1+145] content::BrowserMainLoop::PreMainMessageLoopRun [0x01F28E44+68] content::StartupTaskRunner::RunAllTasksNow [0x0219E911+23] content::BrowserMainLoop::CreateStartupTasks [0x01F27F29+615] content::BrowserMainRunnerImpl::Initialize [0x01F2AC04+100] content::BrowserMain [0x01F264FA+138] content::RunNamedProcessTypeMain [0x02C85C73+123] content::ContentMainRunnerImpl::Run [0x02C860AE+142] service_manager::Main [0x03DF7926+698] content::ContentMain [0x02C85B9F+51] content::BrowserTestBase::SetUp [0x02DFC16A+1498] [4472:1788:0427/191530.473:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown. [4472:1788:0427/191530.473:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown. [ FAILED ] CrSettingsMetricsReportingTest.All, where TypeParam = and GetParam() = (2893 ms) [ RUN ] CrSettingsPersonalizationOptionsTest.OfficialBuild [4264:6108:0501/034504.679:ERROR:install_util.cc(589)] Unable to create registry key HKLM\SOFTWARE\Policies\Google\Chrome for reading result=2 [4264:5548:0501/034504.730:WARNING:discovery_network_list_win.cc(195)] Failed to open Wlan client handle: 1062 [4264:6108:0501/034504.731:WARNING:chrome_browser_main_win.cc(630)] Command line too long for RegisterApplicationRestart: --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=CrSettingsPersonalizationOptionsTest.OfficialBuild --single_process --test-launcher-bot-mode --test-launcher-output="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4036_6079\results4036_19280\test_results.xml" --test-launcher-summary-output="e:\b\s\w\ioybwyu_\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4036_6079\d4036_20534" --disable-offline-auto-reload --enable-blink-features=MojoJSTest --no-first-run --no-default-browser-check --enable-logging=stderr --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --ipc-connection-timeout=30 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --disable-compositor-ukm-for-tests --enable-features=TestFeatureForBrowserTest1 --disable-features=NetworkPrediction,TestFeatureForBrowserTest2 --flag-switches-begin --flag-switches-end --restore-last-session about:blank [4264:6108:0501/034505.540:INFO:CONSOLE(1225)] "Running TestCase CrSettingsPersonalizationOptionsTest.OfficialBuild", source: file:///E:/b/s/w/ir/chrome/test/data/webui/test_api.js (1225) [4264:6108:0501/034505.728:ERROR:CONSOLE(48)] "Mocha test failed: SafeBrowsingExtendedReportingOfficialBuild displaying toggles depending on unified consent AssertionError: expected 6 to equal 7 at Function.assert.strictEqual (file:///E:/b/s/w/ir/third_party/chaijs/chai.js:2277:32) at assertEquals (file:///E:/b/s/w/ir/chrome/test/data/webui/test_api.js:892:17) at Context.<anonymous> (file:///E:/b/s/w/ir/chrome/test/data/webui/settings/personalization_options_test.js:92:9) ", source: file:///E:/b/s/w/ir/chrome/test/data/webui/mocha_adapter.js (48) [4264:6108:0501/034505.728:ERROR:web_ui_test_handler.cc(82)] Test Errors: 1/1 tests had failed assertions. [4264:6108:0501/034505.728:ERROR:web_ui_browser_test.cc(475)] CONDITION FAILURE: encountered javascript console error(s): [4264:6108:0501/034505.728:ERROR:web_ui_browser_test.cc(477)] JS ERROR: '[4264:6108:0501/034505.728:ERROR:CONSOLE(48)] "Mocha test failed: SafeBrowsingExtendedReportingOfficialBuild displaying toggles depending on unified consent AssertionError: expected 6 to equal 7 at Function.assert.strictEqual (file:///E:/b/s/w/ir/third_party/chaijs/chai.js:2277:32) at assertEquals (file:///E:/b/s/w/ir/chrome/test/data/webui/test_api.js:892:17) at Context.<anonymous> (file:///E:/b/s/w/ir/chrome/test/data/webui/settings/personalization_options_test.js:92:9) ", source: file:///E:/b/s/w/ir/chrome/test/data/webui/mocha_adapter.js (48) ' [4264:6108:0501/034505.728:ERROR:web_ui_browser_test.cc(479)] JS call assumed failed, because JS console error(s) found. gen/chrome/test/data/webui/settings/cr_settings_browsertest-gen.cc(1202): error: Value of: RunJavascriptTestF( true, "CrSettingsPersonalizationOptionsTest", "OfficialBuild") Actual: false Expected: true Stack trace: Backtrace: testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop [0x0000000140156697+87] testing::internal::AssertHelper::operator= [0x000000014015621E+78] CrSettingsPersonalizationOptionsTest_OfficialBuild_Test::RunTestOnMainThread [0x00000001400E1798+1256] content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x0000000141C410FD+477] ChromeBrowserMainParts::PreMainMessageLoopRunImpl [0x00000001422BDBB5+4565] ChromeBrowserMainParts::PreMainMessageLoopRun [0x00000001422BC8D6+182] content::BrowserMainLoop::PreMainMessageLoopRun [0x00000001409E8755+85] content::StartupTaskRunner::RunAllTasksNow [0x0000000140CD2A3C+28] content::BrowserMainLoop::CreateStartupTasks [0x00000001409E7350+736] content::BrowserMainRunnerImpl::Initialize [0x00000001409EAA0E+126] content::BrowserMain [0x00000001409E5050+176] content::ContentMainRunnerImpl::Run [0x0000000141A88B75+277] service_manager::Main [0x0000000142E1AB6E+1134] content::ContentMain [0x0000000141A88531+65] content::BrowserTestBase::SetUp [0x0000000141C40E0D+1757] InProcessBrowserTest::SetUp [0x0000000141BA7F1C+428] [4264:6108:0501/034506.321:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown. [4264:6108:0501/034506.321:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown. [ FAILED ] CrSettingsPersonalizationOptionsTest.OfficialBuild, where TypeParam = and GetParam() = (1657 ms)
,
May 1 2018
,
May 2 2018
Just to update: CrSettingsMetricsReportingTest.All, CrSettingsPersonalizationOptionsTest.OfficialBuild fail in official desktop builds observed on Win ASAN, Win clang, Win64 clang . Link to the builder: ------------------ https://uberchromegw.corp.google.com/i/official.desktop/builders/win-clang https://uberchromegw.corp.google.com/i/official.desktop/builders/win64-clang https://uberchromegw.corp.google.com/i/official.desktop/builders/win-asan Link to the error: ----------------- https://logs.chromium.org/v/?s=chrome%2Fbb%2Fofficial.desktop%2Fwin-clang%2F964%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Fstdout https://logs.chromium.org/v/?s=chrome%2Fbb%2Fofficial.desktop%2Fwin64-clang%2F963%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Fstdout https://logs.chromium.org/v/?s=chrome%2Fbb%2Fofficial.desktop%2Fwin-asan%2F953%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Fstdout Thanks..!
,
May 2 2018
,
May 2 2018
For CrSettingsPersonalizationOptionsTest the CL to fix is currently in review https://chromium-review.googlesource.com/c/chromium/src/+/1037925.
,
May 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5a0a04a16a2bad309c880c6840c127644ada0f59 commit 5a0a04a16a2bad309c880c6840c127644ada0f59 Author: Scott Chen <scottchen@chromium.org> Date: Wed May 02 20:56:53 2018 WebUI: fix CrSettingsPersonalizationOptionsTest.* and CrSettingsMetricsReportingTest.All The test broke when some <settings-toggle-button>s in settings Privacy page was moved to a new element. The original CL (1022716) did not break trybots because the problematic tests only run for branded builds. Bug: 838543 Change-Id: Iadc8076f870bdca9831e52e7fa5929052f95c038 Reviewed-on: https://chromium-review.googlesource.com/1037925 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#555506} [modify] https://crrev.com/5a0a04a16a2bad309c880c6840c127644ada0f59/chrome/test/data/webui/settings/metrics_reporting_tests.js [modify] https://crrev.com/5a0a04a16a2bad309c880c6840c127644ada0f59/chrome/test/data/webui/settings/personalization_options_test.js [modify] https://crrev.com/5a0a04a16a2bad309c880c6840c127644ada0f59/chrome/test/data/webui/settings/test_privacy_page_browser_proxy.js
,
May 2 2018
Both should be fixed |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by thakis@chromium.org
, May 1 2018