Crostini app notifications are not showing up anywhere. We likely have to implement https://developer.gnome.org/notification-spec/ and forward those messages to the notification manager in chrome.
Tim or myself will look into this one soon; I'll assign it to the proper person at that point.
My intern will work on this. Thanks!
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d7ed512a06dd88c86c416df97afb701317485a9 commit 3d7ed512a06dd88c86c416df97afb701317485a9 Author: Toshiki Kikuchi <toshikikikuchi@google.com> Date: Wed Aug 29 01:30:23 2018 Add new wayland-protocol, notification-shell-unstable-v1. This new protocol allows clients to create desktop notification on host. The get_notification_surface and zcr_notification_shell_surface_v1 interface (changed name to avoid name conflict) are just a copy of request and interface related to notification for ARC++ in remote-shell. The create_notification is a new request and will be used by notification forwarding from Crostini apps. BUG=chromium:838531 TEST=Build passes. Change-Id: I7072b7fdefc55160fc2fc37147dd7bb7186e1d61 Reviewed-on: https://chromium-review.googlesource.com/1192473 Commit-Queue: Toshiki Kikuchi <toshikikikuchi@google.com> Reviewed-by: David Reveman <reveman@chromium.org> Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#586983} [modify] https://crrev.com/3d7ed512a06dd88c86c416df97afb701317485a9/third_party/wayland-protocols/BUILD.gn [modify] https://crrev.com/3d7ed512a06dd88c86c416df97afb701317485a9/third_party/wayland-protocols/README.chromium [add] https://crrev.com/3d7ed512a06dd88c86c416df97afb701317485a9/third_party/wayland-protocols/include/protocol/notification-shell-unstable-v1-client-protocol.h [add] https://crrev.com/3d7ed512a06dd88c86c416df97afb701317485a9/third_party/wayland-protocols/include/protocol/notification-shell-unstable-v1-server-protocol.h [add] https://crrev.com/3d7ed512a06dd88c86c416df97afb701317485a9/third_party/wayland-protocols/protocol/notification-shell-v1-protocol.c [add] https://crrev.com/3d7ed512a06dd88c86c416df97afb701317485a9/third_party/wayland-protocols/unstable/notification-shell/README [add] https://crrev.com/3d7ed512a06dd88c86c416df97afb701317485a9/third_party/wayland-protocols/unstable/notification-shell/notification-shell-unstable-v1.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/e5a994f49d1b8ab99e1f9afceb059453f996fa81 commit e5a994f49d1b8ab99e1f9afceb059453f996fa81 Author: Toshiki Kikuchi <toshikikikuchi@google.com> Date: Fri Sep 07 14:18:00 2018 vm_tools: notificationd: Add notificationd project notificationd is a new daemon which catches the notification request from Crostini apps via D-BUS and forwards it to Chrome OS (host) via Wayland. This is an initial commit for the project. BUG=chromium:838531 TEST=DBusServiceTest.*, manual verification of behavior Change-Id: I489fdc67944380509b3b5439be688c121847da35 Reviewed-on: https://chromium-review.googlesource.com/1179508 Commit-Ready: Toshiki Kikuchi <toshikikikuchi@google.com> Tested-by: Toshiki Kikuchi <toshikikikuchi@google.com> Reviewed-by: Chirantan Ekbote <chirantan@chromium.org> [add] https://crrev.com/e5a994f49d1b8ab99e1f9afceb059453f996fa81/vm_tools/notificationd/notification_shell_client.cc [add] https://crrev.com/e5a994f49d1b8ab99e1f9afceb059453f996fa81/vm_tools/notificationd/notification_shell_client.h [add] https://crrev.com/e5a994f49d1b8ab99e1f9afceb059453f996fa81/vm_tools/notificationd/dbus_service.h [add] https://crrev.com/e5a994f49d1b8ab99e1f9afceb059453f996fa81/vm_tools/notificationd/notificationd.cc [add] https://crrev.com/e5a994f49d1b8ab99e1f9afceb059453f996fa81/vm_tools/notificationd/dbus_service.cc [add] https://crrev.com/e5a994f49d1b8ab99e1f9afceb059453f996fa81/vm_tools/notificationd/notification_daemon.cc [add] https://crrev.com/e5a994f49d1b8ab99e1f9afceb059453f996fa81/vm_tools/notificationd/notification_daemon.h [add] https://crrev.com/e5a994f49d1b8ab99e1f9afceb059453f996fa81/vm_tools/notificationd/dbus_service_test.cc [add] https://crrev.com/e5a994f49d1b8ab99e1f9afceb059453f996fa81/vm_tools/notificationd/README.md [add] https://crrev.com/e5a994f49d1b8ab99e1f9afceb059453f996fa81/vm_tools/notificationd/protocol/notification-shell-unstable-v1.xml [modify] https://crrev.com/e5a994f49d1b8ab99e1f9afceb059453f996fa81/vm_tools/guest.gypi [add] https://crrev.com/e5a994f49d1b8ab99e1f9afceb059453f996fa81/vm_tools/notificationd/dbus_interface.h
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/33fcbdf87abe82d1cef57ea166550a5519165f6d commit 33fcbdf87abe82d1cef57ea166550a5519165f6d Author: Toshiki Kikuchi <toshikikikuchi@google.com> Date: Mon Sep 10 05:09:05 2018 vm_tools: notificationd: Add virtwl support This allows notificationd to communicate with host OS via virtwl. BUG=chromium:838531 TEST=Existing tests pass, manual verification of behavior Change-Id: Ic6ebe0e4146cfa77e3db4589a0e073599e957d1f Reviewed-on: https://chromium-review.googlesource.com/1213103 Commit-Ready: Toshiki Kikuchi <toshikikikuchi@google.com> Tested-by: Toshiki Kikuchi <toshikikikuchi@google.com> Reviewed-by: David Reveman <reveman@chromium.org> Reviewed-by: Chirantan Ekbote <chirantan@chromium.org> [modify] https://crrev.com/33fcbdf87abe82d1cef57ea166550a5519165f6d/vm_tools/notificationd/notification_shell_client.h [modify] https://crrev.com/33fcbdf87abe82d1cef57ea166550a5519165f6d/vm_tools/notificationd/notification_daemon.cc [modify] https://crrev.com/33fcbdf87abe82d1cef57ea166550a5519165f6d/vm_tools/notificationd/notification_daemon.h [modify] https://crrev.com/33fcbdf87abe82d1cef57ea166550a5519165f6d/vm_tools/notificationd/notification_shell_client.cc [modify] https://crrev.com/33fcbdf87abe82d1cef57ea166550a5519165f6d/vm_tools/notificationd/notificationd.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/c5421230c65bf5c332e1a4c8ecdb43f0c57f8ca5 commit c5421230c65bf5c332e1a4c8ecdb43f0c57f8ca5 Author: Toshiki Kikuchi <toshikikikuchi@google.com> Date: Mon Sep 10 11:29:59 2018 vm_guest_tools: add notificationd Add the notificationd in VM container. Also, add tests for notificationd. BUG=chromium:838531 TEST=cros_workon_make --board=tatl vm_guest_tools --test --install Change-Id: Ifca7e46de5eb3667a202b740c6a1fea0e0a35029 Reviewed-on: https://chromium-review.googlesource.com/1214967 Commit-Ready: Toshiki Kikuchi <toshikikikuchi@google.com> Tested-by: Toshiki Kikuchi <toshikikikuchi@google.com> Reviewed-by: David Reveman <reveman@chromium.org> [modify] https://crrev.com/c5421230c65bf5c332e1a4c8ecdb43f0c57f8ca5/chromeos-base/vm_guest_tools/vm_guest_tools-9999.ebuild
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/5f5975cb7894c6546d8ca7f46968f7a11df56772 commit 5f5975cb7894c6546d8ca7f46968f7a11df56772 Author: Toshiki Kikuchi <toshikikikuchi@google.com> Date: Mon Sep 10 11:29:59 2018 termina_container_tools: install notificationd Install notificationd in /opt/google/cros-containers. BUG=chromium:838531 TEST=emerge-tatl termina_container_tools Change-Id: Id818465d98379de9a5f1c8ae8c9f06d9f7f8648b Reviewed-on: https://chromium-review.googlesource.com/1214969 Commit-Ready: Toshiki Kikuchi <toshikikikuchi@google.com> Tested-by: Toshiki Kikuchi <toshikikikuchi@google.com> Reviewed-by: David Reveman <reveman@chromium.org> [rename] https://crrev.com/5f5975cb7894c6546d8ca7f46968f7a11df56772/chromeos-base/termina_container_tools/termina_container_tools-0.0.1-r10.ebuild [modify] https://crrev.com/5f5975cb7894c6546d8ca7f46968f7a11df56772/chromeos-base/termina_container_tools/termina_container_tools-0.0.1.ebuild
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/containers/cros-container-guest-tools/+/8ca6db6bfca261d336f19ad90c07620e037e8daf commit 8ca6db6bfca261d336f19ad90c07620e037e8daf Author: Toshiki Kikuchi <toshikikikuchi@google.com> Date: Thu Sep 13 08:23:08 2018 cros-notificationd: add initial package Add D-Bus on-demand service specification for notificationd. BUG=chromium:838531 TEST=install package and find notificationd is automatically launched by D-Bus requests Change-Id: I497a5e30c298773140b651ea157ac16363c905e4 Reviewed-on: https://chromium-review.googlesource.com/1218102 Commit-Ready: Toshiki Kikuchi <toshikikikuchi@google.com> Tested-by: Toshiki Kikuchi <toshikikikuchi@google.com> Reviewed-by: Stephen Barber <smbarber@chromium.org> [add] https://crrev.com/8ca6db6bfca261d336f19ad90c07620e037e8daf/cros-notificationd/BUILD [add] https://crrev.com/8ca6db6bfca261d336f19ad90c07620e037e8daf/cros-notificationd/org.freedesktop.Notifications.service [add] https://crrev.com/8ca6db6bfca261d336f19ad90c07620e037e8daf/cros-notificationd/deb-description [modify] https://crrev.com/8ca6db6bfca261d336f19ad90c07620e037e8daf/cros-guest-tools/BUILD
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/09840d4383392bb8752f4c83adcac9c34f7cec4b commit 09840d4383392bb8752f4c83adcac9c34f7cec4b Author: Toshiki Kikuchi <toshikikikuchi@google.com> Date: Tue Sep 18 07:38:35 2018 exo: initial support of notification-shell-unstable protocol This CL introduce the support of notification-shell-unstable protocol defined in wayland-protocols repo. This allows create_notification requests used in notification support from Crostini apps, as initial support. BUG=chromium:838531 TEST=Emit requests from a client (e.g. notificationd) Change-Id: Ia9ca9e0ed77882e56a67cc1afa5f5915f19de626 Reviewed-on: https://chromium-review.googlesource.com/1220848 Commit-Queue: Toshiki Kikuchi <toshikikikuchi@google.com> Reviewed-by: David Reveman <reveman@chromium.org> Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#591963} [modify] https://crrev.com/09840d4383392bb8752f4c83adcac9c34f7cec4b/components/exo/wayland/BUILD.gn [modify] https://crrev.com/09840d4383392bb8752f4c83adcac9c34f7cec4b/components/exo/wayland/server.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7c2894d5bb3fe5137c3e9acbc8f96306898be4f3 commit 7c2894d5bb3fe5137c3e9acbc8f96306898be4f3 Author: Toshiki Kikuchi <toshikikikuchi@google.com> Date: Wed Oct 10 01:02:09 2018 exo/wayland: add notification interface to notification-shell-unstable protocol This CL adds notification interface that controls notification created by create_notification, and allows Exosphere to handle this request. BUG=chromium:838531 TEST=NotificationTest.*, manual verification Change-Id: If89cc87040b7c93b0941870010a32a71dd586b11 Reviewed-on: https://chromium-review.googlesource.com/c/1233100 Commit-Queue: Toshiki Kikuchi <toshikikikuchi@google.com> Reviewed-by: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#598157} [modify] https://crrev.com/7c2894d5bb3fe5137c3e9acbc8f96306898be4f3/components/exo/BUILD.gn [add] https://crrev.com/7c2894d5bb3fe5137c3e9acbc8f96306898be4f3/components/exo/notification.cc [add] https://crrev.com/7c2894d5bb3fe5137c3e9acbc8f96306898be4f3/components/exo/notification.h [add] https://crrev.com/7c2894d5bb3fe5137c3e9acbc8f96306898be4f3/components/exo/notification_unittest.cc [modify] https://crrev.com/7c2894d5bb3fe5137c3e9acbc8f96306898be4f3/components/exo/wayland/BUILD.gn [modify] https://crrev.com/7c2894d5bb3fe5137c3e9acbc8f96306898be4f3/components/exo/wayland/server.cc [modify] https://crrev.com/7c2894d5bb3fe5137c3e9acbc8f96306898be4f3/third_party/wayland-protocols/include/protocol/notification-shell-unstable-v1-client-protocol.h [modify] https://crrev.com/7c2894d5bb3fe5137c3e9acbc8f96306898be4f3/third_party/wayland-protocols/include/protocol/notification-shell-unstable-v1-server-protocol.h [modify] https://crrev.com/7c2894d5bb3fe5137c3e9acbc8f96306898be4f3/third_party/wayland-protocols/protocol/notification-shell-v1-protocol.c [modify] https://crrev.com/7c2894d5bb3fe5137c3e9acbc8f96306898be4f3/third_party/wayland-protocols/unstable/notification-shell/notification-shell-unstable-v1.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/1e956a21f871e451f7cd5aed99a804e79b305efa commit 1e956a21f871e451f7cd5aed99a804e79b305efa Author: Toshiki Kikuchi <toshikikikuchi@google.com> Date: Wed Oct 10 16:45:00 2018 vm_tools: notificationd: Add closed event support This CL allows to handle notification closed event from Wayland compositor and forward it to D-Bus clients using NotificationClosed signal defined in org.freedesktop.Notifications. This CL also updates notification-shell-unstable-v1.xml to be synchronized with Chrome side. So, this CL must not be landed before landing CL:1233100 BUG=chromium:838531 TEST=DBusServiceTest.NotificationClosedSignal Change-Id: I3fb62872fc135bf996786e6dc77947661b77a8c6 Reviewed-on: https://chromium-review.googlesource.com/1258744 Commit-Ready: Toshiki Kikuchi <toshikikikuchi@google.com> Tested-by: Toshiki Kikuchi <toshikikikuchi@google.com> Reviewed-by: David Reveman <reveman@chromium.org> Reviewed-by: Chirantan Ekbote <chirantan@chromium.org> [modify] https://crrev.com/1e956a21f871e451f7cd5aed99a804e79b305efa/vm_tools/notificationd/notification_shell_client.cc [add] https://crrev.com/1e956a21f871e451f7cd5aed99a804e79b305efa/vm_tools/notificationd/notification_shell_interface.h [modify] https://crrev.com/1e956a21f871e451f7cd5aed99a804e79b305efa/vm_tools/notificationd/notification_shell_client.h [modify] https://crrev.com/1e956a21f871e451f7cd5aed99a804e79b305efa/vm_tools/notificationd/dbus_service.h [modify] https://crrev.com/1e956a21f871e451f7cd5aed99a804e79b305efa/vm_tools/notificationd/dbus_service.cc [modify] https://crrev.com/1e956a21f871e451f7cd5aed99a804e79b305efa/vm_tools/notificationd/notification_daemon.cc [modify] https://crrev.com/1e956a21f871e451f7cd5aed99a804e79b305efa/vm_tools/notificationd/notification_daemon.h [modify] https://crrev.com/1e956a21f871e451f7cd5aed99a804e79b305efa/vm_tools/notificationd/dbus_service_test.cc [modify] https://crrev.com/1e956a21f871e451f7cd5aed99a804e79b305efa/vm_tools/notificationd/protocol/notification-shell-unstable-v1.xml [modify] https://crrev.com/1e956a21f871e451f7cd5aed99a804e79b305efa/vm_tools/guest.gypi
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/9c697c525056af736c29ccf8be77b202884a4e77 commit 9c697c525056af736c29ccf8be77b202884a4e77 Author: Toshiki Kikuchi <toshikikikuchi@google.com> Date: Thu Oct 11 15:55:56 2018 vm_tools: notificationd: Add close notification support This CL allows to handle CloseNotification D-Bus request defined in org.freedesktop.Notifications using close request of notification interface defined in notification-shell-unstable protocol. BUG=chromium:838531 TEST=DBusServiceTest.CloseNotification Change-Id: I31aeb78dfcb636a1edb408a16f083b355e26ca60 Reviewed-on: https://chromium-review.googlesource.com/1233020 Commit-Ready: Toshiki Kikuchi <toshikikikuchi@google.com> Tested-by: Toshiki Kikuchi <toshikikikuchi@google.com> Reviewed-by: Chirantan Ekbote <chirantan@chromium.org> [modify] https://crrev.com/9c697c525056af736c29ccf8be77b202884a4e77/vm_tools/notificationd/notification_shell_client.cc [modify] https://crrev.com/9c697c525056af736c29ccf8be77b202884a4e77/vm_tools/notificationd/notification_shell_client.h [modify] https://crrev.com/9c697c525056af736c29ccf8be77b202884a4e77/vm_tools/notificationd/dbus_service.h [modify] https://crrev.com/9c697c525056af736c29ccf8be77b202884a4e77/vm_tools/notificationd/dbus_service.cc [modify] https://crrev.com/9c697c525056af736c29ccf8be77b202884a4e77/vm_tools/notificationd/notification_daemon.cc [modify] https://crrev.com/9c697c525056af736c29ccf8be77b202884a4e77/vm_tools/notificationd/notification_daemon.h [modify] https://crrev.com/9c697c525056af736c29ccf8be77b202884a4e77/vm_tools/notificationd/dbus_service_test.cc [modify] https://crrev.com/9c697c525056af736c29ccf8be77b202884a4e77/vm_tools/notificationd/dbus_interface.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e518bda4a9d8f3e1e232de4af938e7b7c2c2c940 commit e518bda4a9d8f3e1e232de4af938e7b7c2c2c940 Author: Toshiki Kikuchi <toshikikikuchi@google.com> Date: Wed Oct 24 01:45:34 2018 exo/wayland: add buttons and clicked event to notification-shell-unstable protocol This CL allows to show the notification with buttons in create_notification request, and allows Exosphere to handle this request. Also, this CL adds clicked event for that protocol. BUG=chromium:838531 TEST=NotificationTest.*, manual verification Change-Id: Ib7d0693695afac5c732a8c0808a9b3250fa7a327 Reviewed-on: https://chromium-review.googlesource.com/c/1276045 Commit-Queue: Toshiki Kikuchi <toshikikikuchi@google.com> Reviewed-by: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#602213} [modify] https://crrev.com/e518bda4a9d8f3e1e232de4af938e7b7c2c2c940/components/exo/notification.cc [modify] https://crrev.com/e518bda4a9d8f3e1e232de4af938e7b7c2c2c940/components/exo/notification.h [modify] https://crrev.com/e518bda4a9d8f3e1e232de4af938e7b7c2c2c940/components/exo/notification_unittest.cc [modify] https://crrev.com/e518bda4a9d8f3e1e232de4af938e7b7c2c2c940/components/exo/wayland/server.cc [modify] https://crrev.com/e518bda4a9d8f3e1e232de4af938e7b7c2c2c940/third_party/wayland-protocols/include/protocol/notification-shell-unstable-v1-client-protocol.h [modify] https://crrev.com/e518bda4a9d8f3e1e232de4af938e7b7c2c2c940/third_party/wayland-protocols/include/protocol/notification-shell-unstable-v1-server-protocol.h [modify] https://crrev.com/e518bda4a9d8f3e1e232de4af938e7b7c2c2c940/third_party/wayland-protocols/protocol/notification-shell-v1-protocol.c [modify] https://crrev.com/e518bda4a9d8f3e1e232de4af938e7b7c2c2c940/third_party/wayland-protocols/unstable/notification-shell/notification-shell-unstable-v1.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/df97bdaccbc727582b99906d35457bc3c7604caf commit df97bdaccbc727582b99906d35457bc3c7604caf Author: Toshiki Kikuchi <toshikikikuchi@google.com> Date: Wed Oct 24 20:02:59 2018 vm_tools: notificationd: Add notification actions support This CL allows to handle "actions" parameter of the Notify request defined in org.freedesktop.Notifications. These actions are converted to buttons parameters of create_notification request in notification-shell-unstable protocol. Also, this CL allows to forward clicked event in notification-shell-unstable protocol to ActionInvoked signal in org.freedesktop.Notifications. Because this CL updates notification-shell-unstable-v1.xml to be synchronized with Chrome side, this CL must not be landed before landing CL:1276045. BUG=chromium:838531 TEST=DBusServiceTest.ActionInvokedSignal Change-Id: Ibb925bce06452f339303db58028ca6f4bbe82b2e Reviewed-on: https://chromium-review.googlesource.com/1278672 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Toshiki Kikuchi <toshikikikuchi@google.com> Reviewed-by: Chirantan Ekbote <chirantan@chromium.org> [modify] https://crrev.com/df97bdaccbc727582b99906d35457bc3c7604caf/vm_tools/notificationd/notification_shell_client.cc [modify] https://crrev.com/df97bdaccbc727582b99906d35457bc3c7604caf/vm_tools/notificationd/notification_shell_interface.h [modify] https://crrev.com/df97bdaccbc727582b99906d35457bc3c7604caf/vm_tools/notificationd/notification_shell_client.h [modify] https://crrev.com/df97bdaccbc727582b99906d35457bc3c7604caf/vm_tools/notificationd/dbus_service.h [modify] https://crrev.com/df97bdaccbc727582b99906d35457bc3c7604caf/vm_tools/notificationd/dbus_service.cc [modify] https://crrev.com/df97bdaccbc727582b99906d35457bc3c7604caf/vm_tools/notificationd/notification_daemon.cc [modify] https://crrev.com/df97bdaccbc727582b99906d35457bc3c7604caf/vm_tools/notificationd/notification_daemon.h [modify] https://crrev.com/df97bdaccbc727582b99906d35457bc3c7604caf/vm_tools/notificationd/dbus_service_test.cc [modify] https://crrev.com/df97bdaccbc727582b99906d35457bc3c7604caf/vm_tools/notificationd/protocol/notification-shell-unstable-v1.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/4cd535c89489bb09d07689c908cc1a958f94c75b commit 4cd535c89489bb09d07689c908cc1a958f94c75b Author: Toshiki Kikuchi <toshikikikuchi@google.com> Date: Wed Oct 24 20:03:00 2018 vm_tools: notificationd: Fix notification id to start from one According to the specification of org.freedesktop.Notifications, notification ids should start from one instead of zero. This CL fixes the initial value of notification id to follow the spec. In previous implementation, notification ids start from zero. BUG=chromium:838531 TEST=manual Change-Id: I86972dfb6a3218464cb92a91cae5cc7ba89bbf39 Reviewed-on: https://chromium-review.googlesource.com/1290409 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Toshiki Kikuchi <toshikikikuchi@google.com> Reviewed-by: Chirantan Ekbote <chirantan@chromium.org> [modify] https://crrev.com/4cd535c89489bb09d07689c908cc1a958f94c75b/vm_tools/notificationd/notification_daemon.h
Issue 867449 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/299403d8628dfa90646f5c7b9bf915060d112759 commit 299403d8628dfa90646f5c7b9bf915060d112759 Author: Toshiki Kikuchi <toshikikikuchi@google.com> Date: Thu Oct 25 14:54:20 2018 vm_tools: notificationd: Add replace notification support This CL allows to handle "replaces_id" parameter of the Notify request defined in org.freedesktop.Notifications. If replaces_id is given, the notificationd tries to replace the visible notification with the given notification id if it exists. BUG=chromium:838531 TEST=existing tests pass Change-Id: Ia98362143b31773925cedae00060add9d39f43a9 Reviewed-on: https://chromium-review.googlesource.com/1290410 Commit-Ready: Toshiki Kikuchi <toshikikikuchi@google.com> Tested-by: Toshiki Kikuchi <toshikikikuchi@google.com> Reviewed-by: David Reveman <reveman@chromium.org> Reviewed-by: Chirantan Ekbote <chirantan@chromium.org> [modify] https://crrev.com/299403d8628dfa90646f5c7b9bf915060d112759/vm_tools/notificationd/notification_daemon.cc
Comment 1 by reve...@chromium.org
, May 1 2018