Manual bisect: https://chromium.googlesource.com/chromium/src/+log/1fd3911f58d6b5696b4f212922b7260886156d68..bf802aa687ff50a9f4017376cf92da49915f6f8b

Maybe caused by https://chromium.googlesource.com/chromium/src/+/e35ec3e14e0dab0496ebfe1c9b63ff5973e33c0a ?

+kylixrd@ Can you please check, if this is an intended behavior or not?

Thanks :-)
Mehmet

[Mac triage] Assigning to kylixrd@, feel free to unassign if it's not your change!

The change was the size of the highlight circle for the tab close button. This is per the new Refresh spec. In order to keep the number of vector icons to a minimum and keep the code simpler, the new spec is being used for all modes.

For now the size will change, but the white-on-red hovered/pressed version will be reinstated.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27ac53b91957a56030f9b9228c57a549def13dd1

commit 27ac53b91957a56030f9b9228c57a549def13dd1
Author: Allen Bauer <kylixrd@chromium.org>
Date: Wed May 02 15:26:40 2018

In the non-newer material mode, made the close (X) white for the hovered and pressed states.

Bug:  838523 
Change-Id: Ifbe36e9b0a6b1ffad61da0f977ba7660d18f4e55
Reviewed-on: https://chromium-review.googlesource.com/1037904
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555395}
[modify] https://crrev.com/27ac53b91957a56030f9b9228c57a549def13dd1/chrome/browser/ui/views/tabs/tab_close_button.cc
[modify] https://crrev.com/27ac53b91957a56030f9b9228c57a549def13dd1/chrome/browser/ui/views/tabs/tab_close_button.h

Hi kylixrd@, thanks for the fix. I checked the latest Snapshot #555402 and it seems that you change has broken the hover state in MacViews and in MDRefresh mode. Looks like the pressed state is fine. Can you please take a look again or let me know, if I should open e new report for it.


Thanks :-)
Mehmet

Deleted: MacViews_hover_state.png 23.0 KB

	MacViews_hover_state.png 23.0 KB View Download

Deleted: MDRefresh_hover_state.png 22.5 KB

	MDRefresh_hover_state.png 22.5 KB View Download

Deleted: MacViews_pressed_state.png 21.3 KB

	MacViews_pressed_state.png 21.3 KB View Download

Deleted: MDRefresh_pressed_state.png 20.0 KB

	MDRefresh_pressed_state.png 20.0 KB View Download

mehmet@ - Since this is only in MDRefresh mode, please open a new bug. Do you see the same issue on non-Mac platforms?

kylixrd@: Thanks for your feedback. This is not MDRefresh-Only. This happens also in MacViews-Browser (please see my screenshot MacViews_hover_state.png in comment#7). Shall I open a new report anyway?

Unfortunately I have only a Mac to test it :-(

Verified the fix on Mac 10.13.1 using Chrome version #68.0.3418.0 as per the comment #0.
Attaching screen shot for reference.
Observed that a white X and a brighter red color is seen when mouse hovered over the tab's close button.
Hence, the fix is working as expected. 
Adding the verified labels.
Note: Able to reproduce the issue on chrome version 68.0.3416.0.

Thanks...!!

Deleted: 838523 CL Verif.png 366 KB

	838523 CL Verif.png 366 KB View Download

kylixrd@: fyi - the issue i mentioned in comment #7 is fixed for me in latest Canary in MacViews and MDrefresh- probably fixed with  issue 839000 . Thanks :)