New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 838520 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 10
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

mash_unittests failing on chromium.memory/Linux Chromium OS ASan LSan Tests (1)

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, May 1 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of mgiuca@chromium.org

mash_unittests failing on chromium.memory/Linux Chromium OS ASan LSan Tests (1)

Builders failed on: 
- Linux Chromium OS ASan LSan Tests (1): 
  https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29


 
Cc: penghuang@chromium.org sky@chromium.org
Owner: sadrul@chromium.org
Status: Assigned (was: Available)
Failing a DCHECK in window_port_mus.cc:

[22235:22235:0426/034347.563463:40134524576:FATAL:window_port_mus.cc(314)] Check failed: window_mus_type() == WindowMusType::TOP_LEVEL_IN_WM || window_mus_type() == WindowMusType::EMBED_IN_OWNER.

Test was written by sky@ in 2016. DCHECK was added by penghuang in r472841 (2017).

Most likely CL is sadrul@ r551180 which updated a bunch of logic around this, about 2 weeks ago. Seems to only have started flaking more recently than that, though. Assigning to sadrul to investigate.

Disabling the test.
 Issue 838519  has been merged into this issue.
Project Member

Comment 3 by bugdroid1@chromium.org, May 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e65322c96d561a0843abda29e92f6372fb84974

commit 8e65322c96d561a0843abda29e92f6372fb84974
Author: Matt Giuca <mgiuca@chromium.org>
Date: Tue May 01 07:49:19 2018

Disable WindowManagerServiceTest.OpenWindow on ASan.

Flaky on Linux Chromium OS ASan LSan bots.

Bug:  838520 
Tbr: jamescook@chromium.org
Change-Id: I3438154f2231c202bd0f5a292905fc53ead02586
Reviewed-on: https://chromium-review.googlesource.com/1037046
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Commit-Queue: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555014}
[modify] https://crrev.com/8e65322c96d561a0843abda29e92f6372fb84974/ash/window_manager_unittest.cc

Labels: -Sheriff-Chromium
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f76e64ab0b989f724ae60e0c2f61175cd84c50cd

commit f76e64ab0b989f724ae60e0c2f61175cd84c50cd
Author: Scott Violet <sky@chromium.org>
Date: Fri Jul 20 05:17:03 2018

chromeos: nukes mash_unittests

All interesting tests have been moved into ash_unittest and/or nuked.

BUG=842365, 725095 , 838520 
TEST=covered by tests

Change-Id: I27069966c2ea214a071371b7959f4e44b533dd83
Reviewed-on: https://chromium-review.googlesource.com/1142622
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576786}
[modify] https://crrev.com/f76e64ab0b989f724ae60e0c2f61175cd84c50cd/ash/BUILD.gn
[modify] https://crrev.com/f76e64ab0b989f724ae60e0c2f61175cd84c50cd/ash/app_launch_unittest.cc
[modify] https://crrev.com/f76e64ab0b989f724ae60e0c2f61175cd84c50cd/ash/ash_service.cc
[rename] https://crrev.com/f76e64ab0b989f724ae60e0c2f61175cd84c50cd/ash/ash_service_unittest.cc
[delete] https://crrev.com/749ae1edb70c73899710bba0bd5c66e9606c00af/ash/display/display_synchronizer_unittest.cc
[modify] https://crrev.com/f76e64ab0b989f724ae60e0c2f61175cd84c50cd/ash/main.cc
[delete] https://crrev.com/749ae1edb70c73899710bba0bd5c66e9606c00af/ash/wm/top_level_window_factory_mash_unittest.cc
[modify] https://crrev.com/f76e64ab0b989f724ae60e0c2f61175cd84c50cd/mash/BUILD.gn
[modify] https://crrev.com/f76e64ab0b989f724ae60e0c2f61175cd84c50cd/mash/OWNERS
[delete] https://crrev.com/749ae1edb70c73899710bba0bd5c66e9606c00af/mash/test/DEPS
[delete] https://crrev.com/749ae1edb70c73899710bba0bd5c66e9606c00af/mash/test/mash_test_suite.cc
[delete] https://crrev.com/749ae1edb70c73899710bba0bd5c66e9606c00af/mash/test/mash_test_suite.h
[delete] https://crrev.com/749ae1edb70c73899710bba0bd5c66e9606c00af/mash/test/mash_unittests.cc
[delete] https://crrev.com/749ae1edb70c73899710bba0bd5c66e9606c00af/mash/unittests_manifest.json
[modify] https://crrev.com/f76e64ab0b989f724ae60e0c2f61175cd84c50cd/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/f76e64ab0b989f724ae60e0c2f61175cd84c50cd/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/f76e64ab0b989f724ae60e0c2f61175cd84c50cd/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/f76e64ab0b989f724ae60e0c2f61175cd84c50cd/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/f76e64ab0b989f724ae60e0c2f61175cd84c50cd/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/f76e64ab0b989f724ae60e0c2f61175cd84c50cd/ui/aura/mus/in_flight_change.cc
[modify] https://crrev.com/f76e64ab0b989f724ae60e0c2f61175cd84c50cd/ui/aura/mus/window_tree_client.cc
[modify] https://crrev.com/f76e64ab0b989f724ae60e0c2f61175cd84c50cd/ui/aura/mus/window_tree_client.h

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb3102cf8efe4af75e40d01e293a809439d5d279

commit cb3102cf8efe4af75e40d01e293a809439d5d279
Author: Scott Violet <sky@chromium.org>
Date: Thu Aug 09 22:27:20 2018

chromeos: enable a couple of tests on memory sanitizers

These now pass because of adding kOverrideUseSoftwareGLForTests in
AshTestSuite.

BUG= 838520 ,  725095 
TEST=test only changes

Change-Id: I070d5749486338e2fd72815b4dd75d13a391204f
Reviewed-on: https://chromium-review.googlesource.com/1169535
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581921}
[modify] https://crrev.com/cb3102cf8efe4af75e40d01e293a809439d5d279/ash/app_launch_unittest.cc
[modify] https://crrev.com/cb3102cf8efe4af75e40d01e293a809439d5d279/ash/ash_service_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment