https://ci.chromium.org/buildbot/chromium.lkgr/ASan%20Debug%20%2832-bit%20x86%20with%20V8-ARM%29/ and https://ci.chromium.org/buildbot/chromium.lkgr/TSAN%20Debug/ The culprit is likely https://chromium-review.googlesource.com/c/chromium/src/+/1012194
[33578/33630] LINK ./chrome FAILED: chrome python "../../build/toolchain/gcc_link_wrapper.py" --output="./chrome" -- ../../third_party/llvm-build/Release+Asserts/bin/clang++ -pie -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -fuse-ld=lld -m64 -Werror -Wl,--gdb-index -nostdlib++ --sysroot=../../build/linux/debian_sid_amd64-sysroot -L../../build/linux/debian_sid_amd64-sysroot/usr/local/lib/x86_64-linux-gnu -Wl,-rpath-link=../../build/linux/debian_sid_amd64-sysroot/usr/local/lib/x86_64-linux-gnu -L../../build/linux/debian_sid_amd64-sysroot/lib/x86_64-linux-gnu -Wl,-rpath-link=../../build/linux/debian_sid_amd64-sysroot/lib/x86_64-linux-gnu -L../../build/linux/debian_sid_amd64-sysroot/usr/lib/x86_64-linux-gnu -Wl,-rpath-link=../../build/linux/debian_sid_amd64-sysroot/usr/lib/x86_64-linux-gnu -fsanitize=thread -Wl,-rpath-link=. -Wl,--disable-new-dtags -Wl,-rpath=\$ORIGIN/. -Wl,-rpath-link=. -Wl,--export-dynamic -Wl,-u_sanitizer_options_link_helper -fsanitize=thread -o "./chrome" -Wl,--start-group @"./chrome.rsp" ./libembedder.so ./libc++.so ./libbase.so ./libui_base.so ./libui_data_pack.so ./libskia.so ./libgfx.so ./libcolor_space.so ./libgeometry_skia.so ./libgfx_switches.so ./libgeometry.so ./libicui18n.so ./libicuuc.so ./libanimation.so ./libcodec.so ./librange.so ./libevents_base.so ./libplatform.so ./libkeycodes_x11.so ./libui_base_x.so ./libbindings.so ./libbindings_base.so ./libmojo_public_system_cpp.so ./libmojo_public_system.so ./libmessage_support.so ./libmojo_mojom_bindings.so ./libmojo_mojom_bindings_shared.so ./libmojo_base_mojom_shared.so ./libmojo_base_mojom.so ./libmojo_base_lib.so ./libmojo_base_shared_typemap_traits.so ./libbase_i18n.so ./libipc.so ./libipc_mojom.so ./libipc_mojom_shared.so ./libprotobuf_lite.so ./liburl.so ./libnet.so ./libcrcrypto.so ./libboringssl.so ./libcontent_public_common_mojo_bindings_shared.so ./libblink_mojo_bindings_shared.so ./libblink_android_mojo_bindings_shared.so ./libservice_manager_mojom_shared.so ./libservice_manager_mojom_constants_shared.so ./libmojom_platform_shared.so ./libcontent.so ./libcc.so ./libcc_base.so ./libcc_paint.so ./libcc_debug.so ./libviz_common.so ./libviz_resource_format.so ./libgpu.so ./libcrash_key.so ./libgfx_ipc.so ./libgfx_ipc_geometry.so ./liburl_ipc.so ./libservice_manager_mojom.so ./libservice_manager_mojom_constants.so ./libservice_manager_cpp_types.so ./libmedia.so ./libshared_memory_support.so ./libleveldatabase.so ./libmetrics_cpp.so ./libservice_manager_cpp.so ./libgfx_ipc_color.so ./libevents.so ./libui_base_ime.so ./libblink_common.so ./libmojom_core_shared.so ./libnetwork_cpp_base.so ./libnetwork_cpp.so ./libcontent_common_mojo_bindings_shared.so ./libgfx_ipc_skia.so ./libdisplay.so ./libdisplay_types.so ./libcapture_base.so ./libaccessibility.so ./libaura.so ./libcompositor.so ./libsurface.so ./libnetwork_service.so ./libsandbox.so ./libembedder_switches.so ./libmojo_edk.so ./libmojo_edk_ports.so ./libresource_coordinator_cpp.so ./libresource_coordinator_cpp_base.so ./libresource_coordinator_public_mojom.so ./libresource_coordinator_public_mojom_shared.so ./libstorage_common.so ./libtracing_cpp.so ./libtracing_mojom.so ./libtracing_mojom_shared.so ./libperfetto.so ./libpublic.so ./libinterfaces_shared.so ./libstorage_browser.so ./libprefs.so ./libkeyed_service_core.so ./libdbus.so ./libwebdata_common.so ./libsql.so ./libcloud_policy_proto_generated_compile.so ./libpolicy_component.so ./libpolicy_proto.so ./libcommon.so ./libnetwork_session_configurator.so ./libchromium_sqlite3.so ./libnative_theme.so ./libgl_wrapper.so ./libui_message_center_cpp.so ./libppapi_shared.so ./liburl_matcher.so ./libbluetooth.so ./libdevice_event_log.so ./libdevice_base.so ./libkeyboard.so ./libprinting.so ./libsandbox_services.so ./libkeyed_service_content.so ./libsessions.so ./libshell_dialogs.so ./libonc.so ./libuser_prefs.so ./libffmpeg.so ./libviews.so ./libgcm.so ./libdomain_reliability.so ./libui_touch_selection.so ./libproxy_config.so ./libmanager.so ./libmessage_center.so ./libfontconfig.so ./libx11_events_platform.so ./libdevices.so ./libevents_devices_x11.so ./libevents_x.so ./libgfx_x11.so ./libwebview.so ./libstartup_tracing.so ./libui_devtools.so ./libuser_manager.so ./libgesture_detection.so ./libsnapshot.so ./libweb_dialogs.so ./libsuid_sandbox_client.so ./libseccomp_bpf.so ./libdevice_features.so ./libgtk3ui.so ./libbrowser_ui_views.so ./libwm.so ./libui_views_mus_lib.so ./libgles2.so ./libgles2_implementation.so ./libraster.so ./libwm_public.so ./libppapi_proxy.so ./libcaptive_portal.so ./libcapture_lib.so ./libgeolocation.so ./libmidi.so ./libmedia_mojo_services.so ./libmedia_gpu.so ./libcc_animation.so ./libdevice_vr.so ./libdevice_vr_mojo_bindings.so ./libdevice_vr_mojo_bindings_shared.so ./libgl_init.so ./libppapi_host.so ./libgin.so ./libv8.so ./libblink_controller.so ./libblink_core.so ./libblink_core_mojo_bindings_shared.so ./libmojo_base_mojom_blink.so ./libwtf.so ./libblink_platform.so ./libresource_coordinator_public_mojom_blink.so ./libservice_manager_mojom_blink.so ./libservice_manager_mojom_constants_blink.so ./libblink_modules.so ./libnet_with_v8.so ./libdiscardable_memory_client.so ./libfreetype_harfbuzz.so ./libv8_libplatform.so ./libheadless.so -Wl,--end-group -ldl -lpthread -lrt -lX11 -lX11-xcb -lxcb -lXcomposite -lXcursor -lXdamage -lXext -lXfixes -lXi -lXrender -lXtst -lgmodule-2.0 -lgobject-2.0 -lgthread-2.0 -lglib-2.0 -lnss3 -lnssutil3 -lsmime3 -lplds4 -lplc4 -lnspr4 -lcups -ldbus-1 -lexpat -lgio-2.0 -lm /b/c/b/TSAN_Debug/src/out/Debug/../../third_party/llvm-build/Release+Asserts/bin/ld.lld: error: undefined symbol: service_manager::ZygoteHost::GetInstance() >>> referenced by memory_details.cc:345 (../../chrome/browser/memory_details.cc:345) >>> browser/memory_details.o:(MemoryDetails::CollectChildInfoOnUIThread()) in archive obj/chrome/browser/libbrowser.a /b/c/b/TSAN_Debug/src/out/Debug/../../third_party/llvm-build/Release+Asserts/bin/ld.lld: error: undefined symbol: service_manager::ZygoteHost::GetInstance() >>> referenced by sandbox_internals_ui.cc:34 (../../chrome/browser/ui/webui/sandbox_internals_ui.cc:34) >>> ui/sandbox_internals_ui.o:((anonymous namespace)::SetSandboxStatusData(content::WebUIDataSource*)) in archive obj/chrome/browser/ui/libui.a clang: error: linker command failed with exit code 1 (use -v to see invocation)
According to calamity@ this also breaks local compiles of Chromium. Reverting the likely culprit linked above.
Another CL landed after this one which is causing merge conflicts with the revert: https://chromium-review.googlesource.com/c/chromium/src/+/1030876
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/11ab394e56836cf983a58de8626c8ec63e2198ec commit 11ab394e56836cf983a58de8626c8ec63e2198ec Author: Matt Giuca <mgiuca@chromium.org> Date: Tue May 01 05:24:25 2018 Revert "Handle error return from zygote recvmsg call." This reverts commit 86ed44e053ece378ccbb0c2425e4163c65164f9f. Reason for revert: Blocking revert of r554902. Original change's description: > Handle error return from zygote recvmsg call. > > This trips a check far away from the actual issue. The CHECK is too > strong and prevents executing the error handling path beneath it. > > Shuffle a few blocks and comments around so that the flow makes > more sense and is easier to read, and initial fork failures are > caught earlier. > > Bug: 835778 > Change-Id: I46b960f9fd1095f5fc5224bf9cc80703e8fc325f > Reviewed-on: https://chromium-review.googlesource.com/1030876 > Commit-Queue: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#554949} TBR=dcheng@chromium.org,jln@chromium.org,jam@chromium.org,tsepez@chromium.org Change-Id: I877d3610bd75eaa1176189319923bcc75b794781 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 835778 , 838498 Reviewed-on: https://chromium-review.googlesource.com/1036983 Reviewed-by: Matt Giuca <mgiuca@chromium.org> Commit-Queue: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#554999} [modify] https://crrev.com/11ab394e56836cf983a58de8626c8ec63e2198ec/services/service_manager/zygote/zygote_linux.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/35f7133120bbe69c2f68512d3d3d82c6a39ba35e commit 35f7133120bbe69c2f68512d3d3d82c6a39ba35e Author: Matt Giuca <mgiuca@chromium.org> Date: Tue May 01 05:28:23 2018 Revert "Move zygote code to service_manager" This reverts commit dbe3973e8ff5eb249dd35474b69f9316c15ca1f0. Reason for revert: Broke compile on LKGR and local builds. See https://crbug.com/838498 . Original change's description: > Move zygote code to service_manager > > This CL moves the zygote code from content/ to > services/service_manager/zygote. This involves moving some switches from > content_switches.h to services/service_manager/embedder/switches.h and > moving some codes from content/public/common/result_codes.h to the new > services/service_manager/embedder/result_codes.h. > > Bug: 831846 > Change-Id: I9776a30412ea43c2c7f511967d2b7d05f18aa841 > Reviewed-on: https://chromium-review.googlesource.com/1012194 > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Scott Graham <scottmg@chromium.org> > Reviewed-by: Ken Rockot <rockot@chromium.org> > Reviewed-by: Stephen Lanham <slan@chromium.org> > Reviewed-by: Eric Seckler <eseckler@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Commit-Queue: Jay Civelli <jcivelli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#554902} TBR=avi@chromium.org,sky@chromium.org,dschuff@chromium.org,jcivelli@chromium.org,rockot@chromium.org,slan@chromium.org,scottmg@chromium.org,rsesek@chromium.org,eseckler@chromium.org Change-Id: I318b3d8d74520b1fa7eda3d6d612d54e9dc2f040 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 831846 , 838498 Reviewed-on: https://chromium-review.googlesource.com/1036706 Commit-Queue: Matt Giuca <mgiuca@chromium.org> Reviewed-by: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#555001} [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/android_webview/browser/aw_browser_main_parts.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/apps/DEPS [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/DEPS [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/android/java/DEPS [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/android/javatests/DEPS [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/app/DEPS [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/app/chrome_crash_reporter_client.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/app/chrome_main_delegate.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/app/chrome_main_delegate.h [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/browser/DEPS [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/browser/chrome_browser_main.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/browser/chrome_browser_main_posix.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/browser/chrome_browser_main_win.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/browser/memory_details.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/browser/resource_coordinator/tab_manager_delegate_chromeos.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/browser/ui/uninstall_browser_prompt.h [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/browser/ui/views/uninstall_view.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/browser/ui/webui/sandbox_internals_ui.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/common/DEPS [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/common/thread_profiler.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/gpu/DEPS [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/installer/setup/uninstall.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/renderer/DEPS [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/renderer/pepper/pepper_flash_font_file_host.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/service/DEPS [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/service/service_utility_process_host.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/utility/DEPS [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chrome/utility/importer/firefox_importer_unittest_utils_mac.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chromecast/app/DEPS [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chromecast/app/android/DEPS [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chromecast/app/android/crash_handler.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chromecast/app/cast_main_delegate.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chromecast/app/linux/cast_crash_reporter_client.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chromecast/browser/DEPS [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/chromecast/browser/cast_content_browser_client.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/components/crash/content/app/breakpad_linux.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/components/crash/content/app/crashpad_linux.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/components/nacl/DEPS [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/components/nacl/broker/BUILD.gn [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/components/nacl/broker/nacl_broker_listener.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/components/nacl/browser/BUILD.gn [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/components/nacl/browser/nacl_broker_host_win.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/components/nacl/browser/nacl_process_host.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/components/nacl/common/BUILD.gn [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/components/nacl/common/nacl_service.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/components/nacl/loader/BUILD.gn [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/components/nacl/loader/nacl_helper_linux.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/components/nacl/loader/nacl_listener.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/components/nacl/loader/nonsfi/nonsfi_listener.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/components/nacl/zygote/nacl_fork_delegate_linux.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/components/nacl/zygote/nacl_fork_delegate_linux.h [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/BUILD.gn [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/DEPS [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/app/content_main_runner.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/app/content_service_manager_main_delegate.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/browser/BUILD.gn [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/browser/browser_child_process_host_impl.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/browser/browser_main_loop.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/browser/child_process_launcher.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/browser/child_process_launcher_helper.h [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/browser/child_process_launcher_helper_fuchsia.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/browser/child_process_launcher_helper_linux.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/browser/child_process_launcher_helper_mac.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/browser/child_process_launcher_helper_posix.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/browser/child_process_launcher_helper_win.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/browser/gpu/gpu_process_host.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/browser/ppapi_plugin_process_host.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/browser/renderer_host/pepper/pepper_truetype_font_linux.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/browser/utility_process_host.cc [rename] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/browser/zygote_host/zygote_communication_linux.cc [rename] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/browser/zygote_host/zygote_communication_linux.h [rename] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/browser/zygote_host/zygote_handle_linux.cc [rename] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/browser/zygote_host/zygote_host_impl_linux.cc [rename] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/browser/zygote_host/zygote_host_impl_linux.h [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/child/BUILD.gn [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/child/child_process_sandbox_support_impl_linux.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/child/child_thread_impl.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/common/BUILD.gn [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/common/common_sandbox_support_linux.cc [add] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/common/send_zygote_child_ping_linux.cc [rename] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/common/zygote_commands_linux.h [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/gpu/BUILD.gn [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/gpu/gpu_main.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/public/android/BUILD.gn [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/public/app/content_main_delegate.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/public/app/content_main_delegate.h [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/public/browser/BUILD.gn [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/public/browser/browser_main_parts.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/public/browser/child_process_termination_info.h [rename] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/public/browser/zygote_host_linux.h [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/public/common/BUILD.gn [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/public/common/common_sandbox_support_linux.h [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/public/common/content_descriptors.h [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/public/common/content_switches.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/public/common/content_switches.h [add] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/public/common/mojo_channel_switches.cc [add] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/public/common/mojo_channel_switches.h [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/public/common/result_codes.h [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/public/common/sandboxed_process_launcher_delegate.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/public/common/sandboxed_process_launcher_delegate.h [add] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/public/common/send_zygote_child_ping_linux.h [rename] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/public/common/zygote_features.gni [rename] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/public/common/zygote_fork_delegate_linux.h [rename] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/public/common/zygote_handle.h [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/renderer/BUILD.gn [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/renderer/renderer_main.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/shell/BUILD.gn [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/shell/DEPS [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/shell/app/shell_crash_reporter_client.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/shell/app/shell_main_delegate.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/shell/browser/shell_browser_main_parts.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/shell/browser/shell_content_browser_client.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/zygote/OWNERS [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/zygote/zygote_browsertest.cc [rename] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/zygote/zygote_linux.cc [rename] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/zygote/zygote_linux.h [add] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/zygote/zygote_main.h [rename] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/content/zygote/zygote_main_linux.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/extensions/shell/app/DEPS [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/extensions/shell/app/shell_crash_reporter_client.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/extensions/shell/app/shell_main_delegate.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/extensions/shell/app/shell_main_delegate.h [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/extensions/shell/browser/shell_browser_main_parts.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/headless/DEPS [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/headless/lib/browser/headless_content_browser_client.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/headless/lib/headless_content_main_delegate.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/headless/lib/headless_crash_reporter_client.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/services/service_manager/embedder/BUILD.gn [delete] https://crrev.com/82fd02342d240c3f6d728b0cbd35d7841338d0d0/services/service_manager/embedder/descriptors.h [delete] https://crrev.com/82fd02342d240c3f6d728b0cbd35d7841338d0d0/services/service_manager/embedder/result_codes.h [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/services/service_manager/embedder/switches.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/services/service_manager/embedder/switches.h [delete] https://crrev.com/82fd02342d240c3f6d728b0cbd35d7841338d0d0/services/service_manager/zygote/BUILD.gn [delete] https://crrev.com/82fd02342d240c3f6d728b0cbd35d7841338d0d0/services/service_manager/zygote/DEPS [delete] https://crrev.com/82fd02342d240c3f6d728b0cbd35d7841338d0d0/services/service_manager/zygote/OWNERS [delete] https://crrev.com/82fd02342d240c3f6d728b0cbd35d7841338d0d0/services/service_manager/zygote/common/common_sandbox_support_linux.cc [delete] https://crrev.com/82fd02342d240c3f6d728b0cbd35d7841338d0d0/services/service_manager/zygote/common/common_sandbox_support_linux.h [delete] https://crrev.com/82fd02342d240c3f6d728b0cbd35d7841338d0d0/services/service_manager/zygote/common/send_zygote_child_ping_linux.cc [delete] https://crrev.com/82fd02342d240c3f6d728b0cbd35d7841338d0d0/services/service_manager/zygote/common/send_zygote_child_ping_linux.h [delete] https://crrev.com/82fd02342d240c3f6d728b0cbd35d7841338d0d0/services/service_manager/zygote/zygote_main.h [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/tools/ipc_fuzzer/message_replay/DEPS [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/tools/ipc_fuzzer/message_replay/replay_process.cc [modify] https://crrev.com/35f7133120bbe69c2f68512d3d3d82c6a39ba35e/tools/metrics/histograms/enums.xml
Should be reverted now.
Comment 1 by infe...@chromium.org
, May 1 2018