New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 838493 link

Starred by 1 user
Status: Fixed
Owner:
█ jamwalla@chromium.org
Last visit > 30 days ago
Closed: May 2018
Cc:
paulmiller@chromium.org
changwan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Presubmit warnings for multiple definitions of PSBImpl

Project Member Reported by ntfschr@chromium.org, May 1 2018 
When I run git cl upload, I get some presubmit warnings if I touched PlatformServiceBridgeImpl:

$ git cl upload
Running presubmit upload checks ...
WARNING: multiple definitions of org.chromium.android_webview.PlatformServiceBridgeImpl:
    [redacted].../src/clank/android_webview/java/src/org/chromium/android_webview/PlatformServiceBridgeImpl.java
    [redacted].../src/android_webview/java/src/org/chromium/android_webview/PlatformServiceBridgeImpl.java


We intentionally keep multiple definitions for this class, so we should whitelist the class to suppress the warning (see bfaa38b87ab0e1105d38dc7551fafc2b573cb3c5 for an example). More details for whitelisting can be found in  issue 778442 .

This is a follow-up to  issue 682070 , so I'm passing to jamwalla@.
Project Member

Comment 1 by bugdroid1@chromium.org, May 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f31ae6cb1d48fd0996eeac8b8292cf516a7f79ac

commit f31ae6cb1d48fd0996eeac8b8292cf516a7f79ac
Author: James Wallace-Lee <jamwalla@chromium.org>
Date: Tue May 01 23:30:20 2018

Exclude PlatformServiceBridgeImpl from presubmit warning

There are two different implementations of PlatformServiceBridge, both
called PlatformServiceBridgeImpl. (One is downstream.) This CL excludes
the class from the "multiple definitions" presubmit warning.

Bug:  838493 
Change-Id: Iaef896f4f04c203497638af01d40f4aaee930919
Reviewed-on: https://chromium-review.googlesource.com/938305
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555225}
[modify] https://crrev.com/f31ae6cb1d48fd0996eeac8b8292cf516a7f79ac/PRESUBMIT.py

Comment 2 by jamwalla@chromium.org, May 1 2018

Status: Fixed (was: Assigned)
Thanks Nate! Forgot about this last bit, should be fixed now.

Comment 3 by alek...@chromium.org, May 7 2018 

No manual verification is needed per Nate.
►

Sign in to add a comment