Issue metadata
Sign in to add a comment
|
9.2%-1004.5% regression in smoothness.sync_scroll.key_mobile_sites_smooth at 554596:554624 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
May 1 2018
๐ Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14b08203c40000
,
May 1 2018
๐ Couldn't reproduce a difference. https://pinpoint-dot-chromeperf.appspot.com/job/14b08203c40000
,
May 3 2018
๐ Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14ee7133c40000
,
May 3 2018
๐ Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/14ee7133c40000 Do not throttle BeginMainFrame on SubmitCompositorFrameAck by sunnyps@chromium.org https://chromium.googlesource.com/chromium/src/+/3e2200faabd08eb0768c5a13604f60e7061410f8 Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
May 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d79596806759a857e72a476ecc883a650c3327d commit 3d79596806759a857e72a476ecc883a650c3327d Author: Sunny Sachanandani <sunnyps@chromium.org> Date: Fri May 11 04:17:31 2018 Revert "Do not throttle BeginMainFrame on SubmitCompositorFrameAck" This reverts commit 3e2200faabd08eb0768c5a13604f60e7061410f8. Reason for revert: Caused some regressions. piman@ and I have been rethinking how throttling works. Might make sense to hold this off until we have a solid plan. Original change's description: > Do not throttle BeginMainFrame on SubmitCompositorFrameAck > > The original motivation for this code was to workaround early swap ack > on freon, but since freon isn't a thing anymore and we have a display > compositor that actually performs the swap, it should be ok to get rid > of it. This should improve throughput similar to main frame before > activation. > > R=โbrianderson > BUG= 311213 > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I5108c74a57ba201d25999989de8da4c7f81a5176 > Reviewed-on: https://chromium-review.googlesource.com/1031892 > Reviewed-by: Brian Anderson <brianderson@chromium.org> > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> > Cr-Commit-Position: refs/heads/master@{#554547} TBR=brianderson@chromium.org,sunnyps@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 311213 ,838469, 838462 ,838461,838460, 838458 Change-Id: I600b48b3b24a213954b563347dc3dc87dd143ad2 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1054987 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#557791} [modify] https://crrev.com/3d79596806759a857e72a476ecc883a650c3327d/cc/scheduler/scheduler_settings.cc [modify] https://crrev.com/3d79596806759a857e72a476ecc883a650c3327d/cc/scheduler/scheduler_settings.h [modify] https://crrev.com/3d79596806759a857e72a476ecc883a650c3327d/cc/scheduler/scheduler_state_machine.cc [modify] https://crrev.com/3d79596806759a857e72a476ecc883a650c3327d/cc/scheduler/scheduler_state_machine_unittest.cc [modify] https://crrev.com/3d79596806759a857e72a476ecc883a650c3327d/cc/scheduler/scheduler_unittest.cc
,
May 14 2018
Reverted the change that caused this regression. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, May 1 2018