Issue metadata
Sign in to add a comment
|
3%-4% regression in speedometer at 554055:554219 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
May 1 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/15f5c08dc40000
,
May 3 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/1488d553c40000
,
May 3 2018
📍 Found significant differences after each of 2 commits. https://pinpoint-dot-chromeperf.appspot.com/job/1488d553c40000 [ios] make recent tabs disclosure view point up and down by thegreenfrog@chromium.org https://chromium.googlesource.com/chromium/src/+/7057986ca9e3de962e1059f63ea1942741b1ce3f [Omnibox] Fetch and draw entity images by dschuyler@chromium.org https://chromium.googlesource.com/chromium/src/+/c7affc0317e0e19db6af29707cf68c012e17e145 Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
May 4 2018
hablich, you're listed as the owner of speedometer. Can you help us understand what it measures so we can understand whether and how these pinpointed changes may be related? The first only affects iOS so it almost certainly isn't involved. The second I'm pretty sure doesn't touch Android and generally doesn't do anything without an experimental flag enabled though it's possible we overlooked something. But I'm not really clear on whether speedometer measures some aspect of UI performance or startup speed or what.
,
May 7 2018
Speedometer measures JS framework performance and renderer responsiveness. It is very sensitive to V8 performance and Bindings/DOM performance. https://browserbench.org/Speedometer/ is the one that is regressing. There is also a revised version. Seems like it recovered again though. Potentially this was only a bot flake?
,
May 7 2018
Thanks for the explanation, hablich. I don't think either of the culprit CLs would be expected to have an effect on JS or rendered performance. But out of curiosity, what are you looking at where the graph recovered? Most still look elevated to me at https://chromeperf.appspot.com/group_report?bug_id=838455.
,
May 8 2018
I was looking at the pinpoint result in https://pinpoint-dot-chromeperf.appspot.com/job/1488d553c40000. Seems you are right, the graph has indeed not recovered.
,
May 21 2018
#8 fyi, that link just gives me an error 500. hablich@, do you foresee a way that a change in the Omnibox (the address bar UI outside of the HTML content) would cause a performance regression for Speedometer?
,
May 23 2018
Not really, especially as we are running the test in the content shell AFAIK anyway.
,
Jun 8 2018
It looks like the graphs mentioned in #1 have recovered. hablich@ is this still an issue?
,
Jun 11 2018
Nope, thanks for investigating. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, May 1 2018