New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 838454 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: May 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

0.3%-0.6% regression in sizes at 554129:554135

Project Member Reported by m...@chromium.org, May 1 2018

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=838454

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=49a13e0b628bf2ca958784ffafb76cd89ed458af73d69f7a95235aa86ef1744e


Bot(s) for this bug's original alert(s):

linux
mac
win

Comment 2 by m...@chromium.org, May 3 2018

Cc: -m...@chromium.org kozyatinskiy@chromium.org serg...@chromium.org hablich@chromium.org
Owner: machenb...@chromium.org
Status: Assigned (was: Untriaged)
Looks like a size regression occurred with a v8 autoroll. Assigning to V8 folks for further triage...

https://chromium.googlesource.com/chromium/src/+/98eb4947531658548004a76ced588517a8a32998%5E%21/#F0

Comment 3 by kozy@chromium.org, May 3 2018

Cc: machenb...@chromium.org
Owner: jgruber@chromium.org
Hey Jakob, may it be your CL [1]?

[1] https://chromium-review.googlesource.com/c/v8/v8/+/1030550
Cc: -machenb...@chromium.org jarin@chromium.org
+ perf sheriff
Status: WontFix (was: Assigned)
Yes, my CL in #3 will increase the size of libv8.so (and static chrome builds). It moves code from the snapshot into the binary. At runtime, this is a net win since binary-embedded code only exists once instead of once per isolate.
Cc: -serg...@chromium.org m...@chromium.org
miu, please use Blink>JavaScript when sending bugs to V8 and Infra>Client>V8 when  V8 infra support is needed. For regressions, CCing current perf sheriff is also useful: http://shortn/_d3V8V0adV1 (sorry, internal only).

Sign in to add a comment